diff mbox series

[v1] examples/fips_validation: fix parsing SHA test type from JSON vector

Message ID 20220812114910.1032234-1-gmuthukrishn@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series [v1] examples/fips_validation: fix parsing SHA test type from JSON vector |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Gowrishankar Muthukrishnan Aug. 12, 2022, 11:49 a.m. UTC 
  Store SHA test type in its own interim info struct instead of AES.

Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA")

Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
 examples/fips_validation/fips_validation_sha.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Brian Dooley Sept. 23, 2022, 4:25 p.m. UTC | #1 
> -----Original Message-----
> From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> Sent: Friday, August 12, 2022 12:49 PM
> To: dev@dpdk.org
> Cc: Anoob Joseph <anoobj@marvell.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>; Dooley, Brian <brian.dooley@intel.com>; Akhil
> Goyal <gakhil@marvell.com>; Gowrishankar Muthukrishnan
> <gmuthukrishn@marvell.com>
> Subject: [PATCH v1] examples/fips_validation: fix parsing SHA test type from
> JSON vector
> 
> Store SHA test type in its own interim info struct instead of AES.
> 
> Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA")
> 
> Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> ---
>  examples/fips_validation/fips_validation_sha.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/examples/fips_validation/fips_validation_sha.c
> b/examples/fips_validation/fips_validation_sha.c
> index dff552586f..75b073c15d 100644
> --- a/examples/fips_validation/fips_validation_sha.c
> +++ b/examples/fips_validation/fips_validation_sha.c
> @@ -259,7 +259,7 @@ parse_test_sha_json_test_type(void)
> 
>  	for (i = 0; i < RTE_DIM(sha_test_types); i++)
>  		if (strstr(type_str, sha_test_types[i].desc)) {
> -			info.interim_info.aes_data.test_type =
> +			info.interim_info.sha_data.test_type =
>  				sha_test_types[i].type;
>  			break;
>  		}
> --
> 2.25.1

LGTM

Tested-by: Brian Dooley <brian.dooley@intel.com>
Akhil Goyal Oct. 7, 2022, 10:40 a.m. UTC | #2 
> > Subject: [PATCH v1] examples/fips_validation: fix parsing SHA test type from
> > JSON vector
> >
> > Store SHA test type in its own interim info struct instead of AES.
> >
> > Fixes: d5c247145c2 ("examples/fips_validation: add parsing for SHA")
> >
> > Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> > ---
> Tested-by: Brian Dooley <brian.dooley@intel.com>

Applied to dpdk-next-crypto

Thanks.
diff mbox series

Patch

diff --git a/examples/fips_validation/fips_validation_sha.c b/examples/fips_validation/fips_validation_sha.c
index dff552586f..75b073c15d 100644
--- a/examples/fips_validation/fips_validation_sha.c
+++ b/examples/fips_validation/fips_validation_sha.c
@@ -259,7 +259,7 @@  parse_test_sha_json_test_type(void)
 
 	for (i = 0; i < RTE_DIM(sha_test_types); i++)
 		if (strstr(type_str, sha_test_types[i].desc)) {
-			info.interim_info.aes_data.test_type =
+			info.interim_info.sha_data.test_type =
 				sha_test_types[i].type;
 			break;
 		}