net/ice: remove deprecated VF flow action
Checks
Commit Message
From: Zhichao Zeng <zhichaox.zeng@intel.com>
According to the ABI and API Deprecation, remove deprecated VF action
as hard-to-use / ambiguous.
Action REPRESENTED_PORT should be used instead.
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
doc/guides/nics/features/ice.ini | 1 -
drivers/net/ice/ice_switch_filter.c | 22 ----------------------
2 files changed, 23 deletions(-)
Comments
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Wednesday, August 10, 2022 2:50 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Zeng, ZhichaoX <zhichaox.zeng@intel.com>;
> Zhang, Qi Z <qi.z.zhang@intel.com>
> Subject: [PATCH] net/ice: remove deprecated VF flow action
>
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> According to the ABI and API Deprecation, remove deprecated VF action as
> hard-to-use / ambiguous.
>
> Action REPRESENTED_PORT should be used instead.
>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -81,5 +81,4 @@ mark = Y
passthru = Y
queue = Y
rss = Y
-vf = Y
represented_port = Y
@@ -1619,7 +1619,6 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
struct ice_adv_rule_info *rule_info)
{
const struct rte_flow_action_ethdev *act_ethdev;
- const struct rte_flow_action_vf *act_vf;
const struct rte_flow_action *action;
const struct rte_eth_dev *repr_dev;
enum rte_flow_action_type action_type;
@@ -1629,26 +1628,6 @@ ice_switch_parse_dcf_action(struct ice_dcf_adapter *ad,
RTE_FLOW_ACTION_TYPE_END; action++) {
action_type = action->type;
switch (action_type) {
- case RTE_FLOW_ACTION_TYPE_VF:
- rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
- act_vf = action->conf;
-
- if (act_vf->id >= ad->real_hw.num_vfs &&
- !act_vf->original) {
- rte_flow_error_set(error,
- EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
- actions,
- "Invalid vf id");
- return -rte_errno;
- }
-
- if (act_vf->original)
- rule_info->sw_act.vsi_handle =
- ad->real_hw.avf.bus.func;
- else
- rule_info->sw_act.vsi_handle = act_vf->id;
- break;
-
case RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT:
rule_info->sw_act.fltr_act = ICE_FWD_TO_VSI;
act_ethdev = action->conf;
@@ -1812,7 +1791,6 @@ ice_switch_check_action(const struct rte_flow_action *actions,
RTE_FLOW_ACTION_TYPE_END; action++) {
action_type = action->type;
switch (action_type) {
- case RTE_FLOW_ACTION_TYPE_VF:
case RTE_FLOW_ACTION_TYPE_RSS:
case RTE_FLOW_ACTION_TYPE_QUEUE:
case RTE_FLOW_ACTION_TYPE_DROP: