From patchwork Wed Jun 29 03:34:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawen Wu X-Patchwork-Id: 113534 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 77183A0572; Wed, 29 Jun 2022 05:26:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C7FB400D7; Wed, 29 Jun 2022 05:26:22 +0200 (CEST) Received: from smtpbg156.qq.com (smtpbg156.qq.com [15.184.82.18]) by mails.dpdk.org (Postfix) with ESMTP id 9875540042 for ; Wed, 29 Jun 2022 05:26:20 +0200 (CEST) X-QQ-mid: bizesmtp71t1656473175t06a3q1u Received: from wxdbg.localdomain.com ( [183.129.236.74]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 29 Jun 2022 11:26:07 +0800 (CST) X-QQ-SSF: 01400000000000G0Q000000A0000000 X-QQ-FEAT: tT+hSpUa2sqbVeqPU81eNQSE1cpBugekbblEvRYWVvi03iomlMEuYkB06WY2Z rXoAREr9pp4AOjWhVI/upjRz4J9CoziLpTLqwelJ3XChW3+qyRciozE0WER5Iro5+/VD+CX /+/BwDi+tOiP+ccJt1/ZzBwYOv9CD7oCgmgXATVviE3vX9Mt9V9g2kixfEQxEgGLlAqV7by efdfhE+YXEueuh91UbSDmbyTlEKjurZHTChAofLHy4tERL9KO7OW1hKpzy0/EMEJC0GS/es WKTb1AY9LKXDUE1oiiQOSmvd81AR7PTA56mMyqZN4aDGBXp+2b/1R87bg/8gEGgX3Q5VJKq 4IpzzPr1dKiL9txcYI= X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu Subject: [PATCH 1/2] net/txgbe: fix customized devices probe failure Date: Wed, 29 Jun 2022 11:34:16 +0800 Message-Id: <20220629033417.958443-1-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign9 X-QQ-Bgrelay: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The devices with OEM subsystem vendor ID failed to be initialized, because flash was read before memory address was set. Fixes: 138d869e41c0 ("net/txgbe: support OEM subsystem vendor ID") Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index dc8c3c70a9..9dc9948219 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -591,6 +591,8 @@ eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) rte_eth_copy_pci_info(eth_dev, pci_dev); + hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; + /* Vendor and Device ID need to be set before init of shared code */ hw->device_id = pci_dev->id.device_id; hw->vendor_id = pci_dev->id.vendor_id; @@ -607,7 +609,6 @@ eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused) } hw->subsystem_device_id = (u16)ssid >> 8 | (u16)ssid << 8; } - hw->hw_addr = (void *)pci_dev->mem_resource[0].addr; hw->allow_unsupported_sfp = 1; /* Reserve memory for interrupt status block */