diff mbox series

[1/2] net/txgbe: fix customized devices probe failure

Message ID 20220629033417.958443-1-jiawenwu@trustnetic.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [1/2] net/txgbe: fix customized devices probe failure |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Jiawen Wu June 29, 2022, 3:34 a.m. UTC 
  The devices with OEM subsystem vendor ID failed to be initialized,
because flash was read before memory address was set.

Fixes: 138d869e41c0 ("net/txgbe: support OEM subsystem vendor ID")

Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
 drivers/net/txgbe/txgbe_ethdev.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit June 30, 2022, 8:10 a.m. UTC | #1 
On 6/29/2022 4:34 AM, Jiawen Wu wrote:
> The devices with OEM subsystem vendor ID failed to be initialized,
> because flash was read before memory address was set.
> 
> Fixes: 138d869e41c0 ("net/txgbe: support OEM subsystem vendor ID")
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Series applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index dc8c3c70a9..9dc9948219 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -591,6 +591,8 @@  eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
 
 	rte_eth_copy_pci_info(eth_dev, pci_dev);
 
+	hw->hw_addr = (void *)pci_dev->mem_resource[0].addr;
+
 	/* Vendor and Device ID need to be set before init of shared code */
 	hw->device_id = pci_dev->id.device_id;
 	hw->vendor_id = pci_dev->id.vendor_id;
@@ -607,7 +609,6 @@  eth_txgbe_dev_init(struct rte_eth_dev *eth_dev, void *init_params __rte_unused)
 		}
 		hw->subsystem_device_id = (u16)ssid >> 8 | (u16)ssid << 8;
 	}
-	hw->hw_addr = (void *)pci_dev->mem_resource[0].addr;
 	hw->allow_unsupported_sfp = 1;
 
 	/* Reserve memory for interrupt status block */