[2/4] vhost: restore device information in log messages
Checks
Commit Message
device information in the log messages was dropped.
Fixes: 52ade97e3641 ("vhost: fix physical address mapping")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/vhost/vhost_user.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
Comments
Hi David,
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Monday, June 27, 2022 5:27 PM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; Wang,
> YuanX <yuanx.wang@intel.com>; Ding, Xuan <xuan.ding@intel.com>
> Subject: [PATCH 2/4] vhost: restore device information in log messages
>
> device information in the log messages was dropped.
>
> Fixes: 52ade97e3641 ("vhost: fix physical address mapping")
Should we add cc-stable tag in this case as it's 22.03 commit?
Last time when I asked Ferruh, he said although now we don't maintain
non-LTS release, we should still add this tag. Not sure this changed
or not.
For the patch:
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/vhost/vhost_user.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c
> index 2b9a3b69fa..f324f822d6 100644
> --- a/lib/vhost/vhost_user.c
> +++ b/lib/vhost/vhost_user.c
> @@ -144,7 +144,8 @@ async_dma_map(struct virtio_net *dev, bool do_map)
> return;
>
> /* DMA mapping errors won't stop
> VHOST_USER_SET_MEM_TABLE. */
> - VHOST_LOG_CONFIG(ERR, "DMA engine map failed\n");
> + VHOST_LOG_CONFIG(ERR, "(%s) DMA engine map
> failed\n",
> + dev->ifname);
> }
> }
>
> @@ -160,7 +161,8 @@ async_dma_map(struct virtio_net *dev, bool do_map)
> if (rte_errno == EINVAL)
> return;
>
> - VHOST_LOG_CONFIG(ERR, "DMA engine unmap failed\n");
> + VHOST_LOG_CONFIG(ERR, "(%s) DMA engine unmap
> failed\n",
> + dev->ifname);
> }
> }
> }
> @@ -945,7 +947,8 @@ add_one_guest_page(struct virtio_net *dev, uint64_t
> guest_phys_addr,
> dev->max_guest_pages * sizeof(*page),
> RTE_CACHE_LINE_SIZE);
> if (dev->guest_pages == NULL) {
> - VHOST_LOG_CONFIG(ERR, "cannot realloc guest_pages\n");
> + VHOST_LOG_CONFIG(ERR, "(%s) cannot realloc
> guest_pages\n",
> + dev->ifname);
> rte_free(old_pages);
> return -1;
> }
> --
> 2.36.1
On Wed, Jun 29, 2022 at 3:34 PM Xia, Chenbo <chenbo.xia@intel.com> wrote:
>
> Hi David,
>
> > -----Original Message-----
> > From: David Marchand <david.marchand@redhat.com>
> > Sent: Monday, June 27, 2022 5:27 PM
> > To: dev@dpdk.org
> > Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>; Wang,
> > YuanX <yuanx.wang@intel.com>; Ding, Xuan <xuan.ding@intel.com>
> > Subject: [PATCH 2/4] vhost: restore device information in log messages
> >
> > device information in the log messages was dropped.
> >
> > Fixes: 52ade97e3641 ("vhost: fix physical address mapping")
>
> Should we add cc-stable tag in this case as it's 22.03 commit?
> Last time when I asked Ferruh, he said although now we don't maintain
> non-LTS release, we should still add this tag. Not sure this changed
> or not.
No objection for leaks and other important fixes.
Here, this patch is only fixing some log messages, so I did not see the need.
In any case, I am fine with both options and this can be added when
the patch is applied by sub-tree maintainer.
>
> For the patch:
>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Thanks Chenbo!
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Wednesday, June 29, 2022 9:45 PM
> To: Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; Wang, YuanX
> <yuanx.wang@intel.com>; Ding, Xuan <xuan.ding@intel.com>;
> ferruh.yigit@xilinx.com
> Subject: Re: [PATCH 2/4] vhost: restore device information in log messages
>
> On Wed, Jun 29, 2022 at 3:34 PM Xia, Chenbo <chenbo.xia@intel.com> wrote:
> >
> > Hi David,
> >
> > > -----Original Message-----
> > > From: David Marchand <david.marchand@redhat.com>
> > > Sent: Monday, June 27, 2022 5:27 PM
> > > To: dev@dpdk.org
> > > Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> Wang,
> > > YuanX <yuanx.wang@intel.com>; Ding, Xuan <xuan.ding@intel.com>
> > > Subject: [PATCH 2/4] vhost: restore device information in log messages
> > >
> > > device information in the log messages was dropped.
> > >
> > > Fixes: 52ade97e3641 ("vhost: fix physical address mapping")
> >
> > Should we add cc-stable tag in this case as it's 22.03 commit?
> > Last time when I asked Ferruh, he said although now we don't maintain
> > non-LTS release, we should still add this tag. Not sure this changed
> > or not.
>
> No objection for leaks and other important fixes.
Good to know we are aligned :)
> Here, this patch is only fixing some log messages, so I did not see the
> need.
OK. Make sense to me
Thanks,
Chenbo
>
> In any case, I am fine with both options and this can be added when
> the patch is applied by sub-tree maintainer.
>
> >
> > For the patch:
> >
> > Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
>
> Thanks Chenbo!
>
>
> --
> David Marchand
@@ -144,7 +144,8 @@ async_dma_map(struct virtio_net *dev, bool do_map)
return;
/* DMA mapping errors won't stop VHOST_USER_SET_MEM_TABLE. */
- VHOST_LOG_CONFIG(ERR, "DMA engine map failed\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) DMA engine map failed\n",
+ dev->ifname);
}
}
@@ -160,7 +161,8 @@ async_dma_map(struct virtio_net *dev, bool do_map)
if (rte_errno == EINVAL)
return;
- VHOST_LOG_CONFIG(ERR, "DMA engine unmap failed\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) DMA engine unmap failed\n",
+ dev->ifname);
}
}
}
@@ -945,7 +947,8 @@ add_one_guest_page(struct virtio_net *dev, uint64_t guest_phys_addr,
dev->max_guest_pages * sizeof(*page),
RTE_CACHE_LINE_SIZE);
if (dev->guest_pages == NULL) {
- VHOST_LOG_CONFIG(ERR, "cannot realloc guest_pages\n");
+ VHOST_LOG_CONFIG(ERR, "(%s) cannot realloc guest_pages\n",
+ dev->ifname);
rte_free(old_pages);
return -1;
}