[v3,18/18] vhost: remove unneeded header includes

Message ID 20220617190835.1126602-19-sean.morrissey@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series remove IWYU flagged headers |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-aarch64-unit-testing fail Testing issues
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing fail Testing issues
ci/github-robot: build fail github build: failed
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing warning Testing issues

Commit Message

Sean Morrissey June 17, 2022, 7:08 p.m. UTC
  These header includes have been flagged by the iwyu_tool
and removed.

Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
---
 lib/vhost/vhost.h      | 2 --
 lib/vhost/vhost_user.h | 1 -
 2 files changed, 3 deletions(-)
  

Comments

Chenbo Xia June 20, 2022, 1:42 a.m. UTC | #1
> -----Original Message-----
> From: Morrissey, Sean <sean.morrissey@intel.com>
> Sent: Saturday, June 18, 2022 3:09 AM
> To: Maxime Coquelin <maxime.coquelin@redhat.com>; Xia, Chenbo
> <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Morrissey, Sean <sean.morrissey@intel.com>
> Subject: [PATCH v3 18/18] vhost: remove unneeded header includes
> 
> These header includes have been flagged by the iwyu_tool
> and removed.
> 
> Signed-off-by: Sean Morrissey <sean.morrissey@intel.com>
> ---
>  lib/vhost/vhost.h      | 2 --
>  lib/vhost/vhost_user.h | 1 -
>  2 files changed, 3 deletions(-)
> 
> diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
> index 14235aaf81..4ebcb7448a 100644
> --- a/lib/vhost/vhost.h
> +++ b/lib/vhost/vhost.h
> @@ -7,10 +7,8 @@
>  #include <stdint.h>
>  #include <stdio.h>
>  #include <stdbool.h>
> -#include <sys/types.h>
>  #include <sys/queue.h>
>  #include <unistd.h>
> -#include <linux/vhost.h>
>  #include <linux/virtio_net.h>
>  #include <sys/socket.h>
>  #include <linux/if.h>
> diff --git a/lib/vhost/vhost_user.h b/lib/vhost/vhost_user.h
> index c4d091e175..8ecca68597 100644
> --- a/lib/vhost/vhost_user.h
> +++ b/lib/vhost/vhost_user.h
> @@ -6,7 +6,6 @@
>  #define _VHOST_NET_USER_H
> 
>  #include <stdint.h>
> -#include <linux/vhost.h>
> 
>  #include "rte_vhost.h"
> 
> --
> 2.25.1

Acked-by: Chenbo Xia <chenbo.xia@intel.com>
  

Patch

diff --git a/lib/vhost/vhost.h b/lib/vhost/vhost.h
index 14235aaf81..4ebcb7448a 100644
--- a/lib/vhost/vhost.h
+++ b/lib/vhost/vhost.h
@@ -7,10 +7,8 @@ 
 #include <stdint.h>
 #include <stdio.h>
 #include <stdbool.h>
-#include <sys/types.h>
 #include <sys/queue.h>
 #include <unistd.h>
-#include <linux/vhost.h>
 #include <linux/virtio_net.h>
 #include <sys/socket.h>
 #include <linux/if.h>
diff --git a/lib/vhost/vhost_user.h b/lib/vhost/vhost_user.h
index c4d091e175..8ecca68597 100644
--- a/lib/vhost/vhost_user.h
+++ b/lib/vhost/vhost_user.h
@@ -6,7 +6,6 @@ 
 #define _VHOST_NET_USER_H
 
 #include <stdint.h>
-#include <linux/vhost.h>
 
 #include "rte_vhost.h"