diff mbox series

test/ipsec: fix performance test failure

Message ID 20220617171842.2788040-1-vladimir.medvedkin@intel.com (mailing list archive)
State Changes Requested, archived
Delegated to: akhil goyal
Headers
Series test/ipsec: fix performance test failure |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/intel-Testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing fail Testing issues
ci/iol-x86_64-unit-testing fail Testing issues
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS

Commit Message

Vladimir Medvedkin June 17, 2022, 5:18 p.m. UTC 
  This patch initializes with 0 rte_ipsec_sa_prm inside the ipsec_sa struct.
Before it was passed uninitialized to rte_ipsec_sa_init(),
which does not check whether prm->ipsec_xform.esn.value is greater
than sa->sqn_mask.

Bugzilla ID: 1023
Fixes: f7f3ac6dcbe2 ("test/ipsec: add performance cases")
Cc: savinay.dharmappa@intel.com
Cc: stable@dpdk.org

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 app/test/test_ipsec_perf.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Akhil Goyal June 21, 2022, 11:08 a.m. UTC | #1 
> This patch initializes with 0 rte_ipsec_sa_prm inside the ipsec_sa struct.
> Before it was passed uninitialized to rte_ipsec_sa_init(),
> which does not check whether prm->ipsec_xform.esn.value is greater
> than sa->sqn_mask.
> 
> Bugzilla ID: 1023
> Fixes: f7f3ac6dcbe2 ("test/ipsec: add performance cases")
> Cc: savinay.dharmappa@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
Please fix compilation issues reported by CI

../app/test/test_ipsec_perf.c: In function 'test_libipsec_perf':
../app/test/test_ipsec_perf.c:595:9: error: missing braces around initializer [-Werror=missing-braces]
  struct ipsec_sa sa_out = { 0 };
         ^
../app/test/test_ipsec_perf.c:595:9: error: (near initialization for 'sa_out.ss') [-Werror=missing-braces]
../app/test/test_ipsec_perf.c:596:9: error: missing braces around initializer [-Werror=missing-braces]
  struct ipsec_sa sa_in = { 0 };
         ^
../app/test/test_ipsec_perf.c:596:9: error: (near initialization for 'sa_in.ss') [-Werror=missing-braces]
cc1: all warnings being treated as errors
diff mbox series

Patch

diff --git a/app/test/test_ipsec_perf.c b/app/test/test_ipsec_perf.c
index 346a851648..580cad00f6 100644
--- a/app/test/test_ipsec_perf.c
+++ b/app/test/test_ipsec_perf.c
@@ -592,8 +592,8 @@  testsuite_teardown(void)
 static int
 test_libipsec_perf(void)
 {
-	struct ipsec_sa sa_out;
-	struct ipsec_sa sa_in;
+	struct ipsec_sa sa_out = { 0 };
+	struct ipsec_sa sa_in = { 0 };
 	uint32_t i;
 	int ret;