diff mbox series

[v2,12/14] cryptodev: clarify rsa verify with none padding

Message ID	20220525155324.9288-13-arkadiuszx.kusztal@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	akhil goyal
Headers	From: Arek Kusztal <arkadiuszx.kusztal@intel.com> To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal <arkadiuszx.kusztal@intel.com> Subject: [PATCH v2 12/14] cryptodev: clarify rsa verify with none padding Date: Wed, 25 May 2022 16:53:22 +0100 Message-Id: <20220525155324.9288-13-arkadiuszx.kusztal@intel.com> In-Reply-To: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> References: <20220525155324.9288-1-arkadiuszx.kusztal@intel.com> Precedence: list Errors-To: dev-bounces@dpdk.org
Series	cryptodev: rsa, dh, ecdh changes \| [v2,00/14] cryptodev: rsa, dh, ecdh changes [v2,01/14] cryptodev: redefine ec group enum [v2,02/14] cryptodev: reduce number of comments in asym xform [v2,03/14] cryptodev: separate key exchange operation enum [v2,04/14] cryptodev: remove comment about using ephemeral key in dsa [v2,05/14] cryptodev: clarify usage of private key in dh [v2,06/14] cryptodev: move dh type from xform to dh op [v2,07/14] cryptodev: add elliptic curve diffie hellman [v2,08/14] cryptodev: add public key verify option [v2,09/14] cryptodev: add asym op flags [v2,10/14] cryptodev: clarify usage of rsa padding hash [v2,11/14] cryptodev: move RSA padding into separate struct [v2,12/14] cryptodev: clarify rsa verify with none padding [v2,13/14] cryptodev: add salt length and optional label [v2,14/14] cryptodev: add asym algorithms capabilities

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Arkadiusz Kusztal May 25, 2022, 3:53 p.m. UTC

  - Clarified where should output be stored of signature
decryption with padding none.
PMD is not able to know what padding algorithm was used,
therefore decrypted signature should be returned to the user.

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 lib/cryptodev/rte_crypto_asym.h | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

Comments

Akhil Goyal May 26, 2022, 12:06 p.m. UTC | #1

> - Clarified where should output be stored of signature
> decryption with padding none.
> PMD is not able to know what padding algorithm was used,
> therefore decrypted signature should be returned to the user.
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
>  lib/cryptodev/rte_crypto_asym.h | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
> index ee0988d3cf..9f7fba3758 100644
> --- a/lib/cryptodev/rte_crypto_asym.h
> +++ b/lib/cryptodev/rte_crypto_asym.h
> @@ -372,8 +372,6 @@ struct rte_crypto_rsa_op_param {
>  	 * (i.e. must be at least RSA key size). The message.length
>  	 * field should be 0 and will be overwritten by the PMD
>  	 * with the decrypted length.
> -	 *
> -	 * All data is in Octet-string network byte order format.
>  	 */
Patch description and title does not match with this change.

> 
>  	rte_crypto_param cipher;
> @@ -388,7 +386,8 @@ struct rte_crypto_rsa_op_param {
>  	 * at least RSA key size). The cipher.length field should
>  	 * be 0 and will be overwritten by the PMD with the encrypted length.
>  	 *
> -	 * All data is in Octet-string network byte order format.
> +	 * When RTE_CRYPTO_RSA_PADDING_NONE and
> RTE_CRYPTO_ASYM_OP_VERIFY
> +	 * selected, this is an output of decrypted signature.
>  	 */
> 
>  	rte_crypto_param sign;
> @@ -402,8 +401,6 @@ struct rte_crypto_rsa_op_param {
>  	 * with enough memory to hold signature output (i.e. must be
>  	 * at least RSA key size). The sign.length field should
>  	 * be 0 and will be overwritten by the PMD with the signature length.
> -	 *
> -	 * All data is in Octet-string network byte order format.
>  	 */
> 
>  	struct rte_crypto_rsa_padding padding;
> --
> 2.13.6

Arkadiusz Kusztal May 26, 2022, 12:15 p.m. UTC | #2

> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, May 26, 2022 2:07 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org
> Cc: Zhang, Roy Fan <roy.fan.zhang@intel.com>
> Subject: RE: [EXT] [PATCH v2 12/14] cryptodev: clarify rsa verify with none
> padding
> 
> > - Clarified where should output be stored of signature decryption with
> > padding none.
> > PMD is not able to know what padding algorithm was used, therefore
> > decrypted signature should be returned to the user.
> >
> > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> > ---
> >  lib/cryptodev/rte_crypto_asym.h | 7 ++-----
> >  1 file changed, 2 insertions(+), 5 deletions(-)
> >
> > diff --git a/lib/cryptodev/rte_crypto_asym.h
> > b/lib/cryptodev/rte_crypto_asym.h index ee0988d3cf..9f7fba3758 100644
> > --- a/lib/cryptodev/rte_crypto_asym.h
> > +++ b/lib/cryptodev/rte_crypto_asym.h
> > @@ -372,8 +372,6 @@ struct rte_crypto_rsa_op_param {
> >  	 * (i.e. must be at least RSA key size). The message.length
> >  	 * field should be 0 and will be overwritten by the PMD
> >  	 * with the decrypted length.
> > -	 *
> > -	 * All data is in Octet-string network byte order format.
> >  	 */
> Patch description and title does not match with this change.
I will add a comment to commit message then.
> 
> >
> >  	rte_crypto_param cipher;
> > @@ -388,7 +386,8 @@ struct rte_crypto_rsa_op_param {
> >  	 * at least RSA key size). The cipher.length field should
> >  	 * be 0 and will be overwritten by the PMD with the encrypted length.
> >  	 *
> > -	 * All data is in Octet-string network byte order format.
> > +	 * When RTE_CRYPTO_RSA_PADDING_NONE and
> > RTE_CRYPTO_ASYM_OP_VERIFY
> > +	 * selected, this is an output of decrypted signature.
> >  	 */
> >
> >  	rte_crypto_param sign;
> > @@ -402,8 +401,6 @@ struct rte_crypto_rsa_op_param {
> >  	 * with enough memory to hold signature output (i.e. must be
> >  	 * at least RSA key size). The sign.length field should
> >  	 * be 0 and will be overwritten by the PMD with the signature length.
> > -	 *
> > -	 * All data is in Octet-string network byte order format.
> >  	 */
> >
> >  	struct rte_crypto_rsa_padding padding;
> > --
> > 2.13.6

diff mbox series

Patch

diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
index ee0988d3cf..9f7fba3758 100644
--- a/lib/cryptodev/rte_crypto_asym.h
+++ b/lib/cryptodev/rte_crypto_asym.h
@@ -372,8 +372,6 @@  struct rte_crypto_rsa_op_param {
 	 * (i.e. must be at least RSA key size). The message.length
 	 * field should be 0 and will be overwritten by the PMD
 	 * with the decrypted length.
-	 *
-	 * All data is in Octet-string network byte order format.
 	 */
 
 	rte_crypto_param cipher;
@@ -388,7 +386,8 @@  struct rte_crypto_rsa_op_param {
 	 * at least RSA key size). The cipher.length field should
 	 * be 0 and will be overwritten by the PMD with the encrypted length.
 	 *
-	 * All data is in Octet-string network byte order format.
+	 * When RTE_CRYPTO_RSA_PADDING_NONE and RTE_CRYPTO_ASYM_OP_VERIFY
+	 * selected, this is an output of decrypted signature.
 	 */
 
 	rte_crypto_param sign;
@@ -402,8 +401,6 @@  struct rte_crypto_rsa_op_param {
 	 * with enough memory to hold signature output (i.e. must be
 	 * at least RSA key size). The sign.length field should
 	 * be 0 and will be overwritten by the PMD with the signature length.
-	 *
-	 * All data is in Octet-string network byte order format.
 	 */
 
 	struct rte_crypto_rsa_padding padding;