Message ID | 20220520055445.40063-10-arkadiuszx.kusztal@intel.com (mailing list archive) |
---|---|
State | Changes Requested, archived |
Delegated to: | akhil goyal |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 91D5AA0503; Fri, 20 May 2022 09:03:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5436E42B99; Fri, 20 May 2022 09:02:57 +0200 (CEST) Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id D3E6B42BA4 for <dev@dpdk.org>; Fri, 20 May 2022 09:02:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653030176; x=1684566176; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=mWOK1Tx0KX4pcSfhm1H7qCicJDMSUDa3PXfpv3z42Dk=; b=OY1DxGN9V9SYrQpRobLLCAHDcwr312ThglPqe132zXCjsuHHa2Db1IBs bdE81aMpJZujWpOc/XA9Ff0FVR+Z1Wi4sU3RGcLnp4ERRi63Uw5S5BtMD SalC0lqMeNTiNW44DOYP53ez8CV/jWmMjCQc1ZvCXtLiIrbQ+7roga94T m1OT1gaQWgbLh62EU8U5ouB+YTX1AC1n8Q0OWXOxCW059rGsJRA0suOh2 f1uyjDgG0k2/3r0mH1FG201sQ5DqSEJGad6LUDzmNoQo2iTGS2fbO0ctI jwPOhv6HdK5VniZ+Rflna31Z+/1ZHtUN7H64HkeitXKV8qEembVBnrQbl Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10352"; a="333140279" X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="333140279" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 May 2022 00:02:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,238,1647327600"; d="scan'208";a="599058162" Received: from silpixa00399302.ir.intel.com ([10.237.214.136]) by orsmga008.jf.intel.com with ESMTP; 20 May 2022 00:02:53 -0700 From: Arek Kusztal <arkadiuszx.kusztal@intel.com> To: dev@dpdk.org Cc: gakhil@marvell.com, anoobj@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal <arkadiuszx.kusztal@intel.com> Subject: [PATCH 09/40] cryptodev: remove unnecessary zero assignement Date: Fri, 20 May 2022 06:54:14 +0100 Message-Id: <20220520055445.40063-10-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> References: <20220520055445.40063-1-arkadiuszx.kusztal@intel.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
cryptodev: rsa, dh, ecdh changes
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | warning | coding style issues |
Commit Message
Arkadiusz Kusztal
May 20, 2022, 5:54 a.m. UTC
- removed unnecessary zero assignement in rsa padding enum.
Even it is set correctly it should be made consistent with
other enums in cryptodev. Therefore assignement to zero was
removed.
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
lib/cryptodev/rte_crypto_asym.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
Comments
> - removed unnecessary zero assignement in rsa padding enum. > Even it is set correctly it should be made consistent with > other enums in cryptodev. Therefore assignement to zero was > removed. > > Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com> > --- > lib/cryptodev/rte_crypto_asym.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h > index 0fc9f49b87..270619acf2 100644 > --- a/lib/cryptodev/rte_crypto_asym.h > +++ b/lib/cryptodev/rte_crypto_asym.h > @@ -116,11 +116,12 @@ enum rte_crypto_asym_ke_type { > * Padding types for RSA signature. > */ > enum rte_crypto_rsa_padding_type { > - RTE_CRYPTO_RSA_PADDING_NONE = 0, > + RTE_CRYPTO_RSA_PADDING_NONE, > /**< RSA no padding scheme */ > RTE_CRYPTO_RSA_PADDING_PKCS1_5, > - /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. For signatures block type > 01, > - * for encryption block type 02 are used. > + /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. > + * For signatures block type 01, for encryption > + * block type 02 are used. This change is not required or make it a separate patch. > */ > RTE_CRYPTO_RSA_PADDING_OAEP, > /**< RSA PKCS#1 OAEP padding scheme */ > -- > 2.13.6
diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index 0fc9f49b87..270619acf2 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -116,11 +116,12 @@ enum rte_crypto_asym_ke_type { * Padding types for RSA signature. */ enum rte_crypto_rsa_padding_type { - RTE_CRYPTO_RSA_PADDING_NONE = 0, + RTE_CRYPTO_RSA_PADDING_NONE, /**< RSA no padding scheme */ RTE_CRYPTO_RSA_PADDING_PKCS1_5, - /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. For signatures block type 01, - * for encryption block type 02 are used. + /**< RSA PKCS#1 PKCS1-v1_5 padding scheme. + * For signatures block type 01, for encryption + * block type 02 are used. */ RTE_CRYPTO_RSA_PADDING_OAEP, /**< RSA PKCS#1 OAEP padding scheme */