diff mbox series

[v2,5/5] baseband/fpga_5gnr_fec: remove filler from HARQ

Message ID 20220520030556.3475133-6-hernan.vargas@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series baseband/fpga_5gnr: maintenance changes to fpga_5gnr PMD |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing fail Testing issues
ci/intel-Testing success Testing PASS

Commit Message

Vargas, Hernan May 20, 2022, 3:05 a.m. UTC 
  From: Hernan <hernan.vargas@intel.com>

Removed filler bits from HARQ calculation on the N3000 FPGA since these
are already taken out by the deratematching step.
The change is only an optimization with no functional impact, no change
required on stable branches.

Signed-off-by: Hernan <hernan.vargas@intel.com>
---
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chautru, Nicolas May 24, 2022, 12:21 a.m. UTC | #1 
Thanks Hernan

> -----Original Message-----
> From: Vargas, Hernan <hernan.vargas@intel.com>
> Sent: Thursday, May 19, 2022 8:06 PM
> To: dev@dpdk.org; gakhil@marvell.com; trix@redhat.com
> Cc: Chautru, Nicolas <nicolas.chautru@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Vargas, Hernan <hernan.vargas@intel.com>
> Subject: [PATCH v2 5/5] baseband/fpga_5gnr_fec: remove filler from HARQ
> 
> From: Hernan <hernan.vargas@intel.com>
> 
> Removed filler bits from HARQ calculation on the N3000 FPGA since these are
> already taken out by the deratematching step.
> The change is only an optimization with no functional impact, no change
> required on stable branches.
> 
> Signed-off-by: Hernan <hernan.vargas@intel.com>

Reviewed-by: Nicolas Chautru <nicolas.chautru@intel.com>

> ---
>  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> index d678695a3c..82ae6ba678 100644
> --- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> +++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
> @@ -1844,7 +1844,7 @@ enqueue_ldpc_dec_one_op_cb(struct fpga_queue
> *q, struct rte_bbdev_dec_op *op,
>  		else
>  			l = k0 + e + dec->n_filler;
>  		harq_out_length = RTE_MIN(RTE_MAX(harq_in_length, l),
> -				dec->n_cb - dec->n_filler);
> +				dec->n_cb);
>  		dec->harq_combined_output.length = harq_out_length;
>  	}
> 
> --
> 2.25.1
diff mbox series

Patch

diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
index d678695a3c..82ae6ba678 100644
--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c
@@ -1844,7 +1844,7 @@  enqueue_ldpc_dec_one_op_cb(struct fpga_queue *q, struct rte_bbdev_dec_op *op,
 		else
 			l = k0 + e + dec->n_filler;
 		harq_out_length = RTE_MIN(RTE_MAX(harq_in_length, l),
-				dec->n_cb - dec->n_filler);
+				dec->n_cb);
 		dec->harq_combined_output.length = harq_out_length;
 	}