diff mbox series

[02/12] event/octeontx: fix SSO fastpath

Message ID	20220517173941.189330-2-hkalra@marvell.com (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Harman Kalra <hkalra@marvell.com> To: <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com> CC: Harman Kalra <hkalra@marvell.com> Subject: [PATCH 02/12] event/octeontx: fix SSO fastpath Date: Tue, 17 May 2022 23:09:31 +0530 Message-ID: <20220517173941.189330-2-hkalra@marvell.com> In-Reply-To: <20220517173941.189330-1-hkalra@marvell.com> References: <20220517173941.189330-1-hkalra@marvell.com> MIME-Version: 1.0 Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	[01/12] config: add thundert83 config \| [01/12] config: add thundert83 config [02/12] event/octeontx: fix SSO fastpath [03/12] net/octeontx: fix port close [04/12] net/octeontx: setting link attributes [05/12] net/octeontx: handle port reconfiguration [06/12] net/thunderx: implement polling of link state change [07/12] net/thunderx: reset Rx DMAC control register [08/12] net/thunderx: setting link attributes [09/12] net/octeontx: implement xstats [10/12] net/octeontx: support allmulticast [11/12] net/thunderx: device attach from secondary [12/12] net/thunderx: populate max and min MTU values

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Harman Kalra May 17, 2022, 5:39 p.m. UTC

  Segmentation fault is observed as soon as any dpdk application
with ethdev event is launched. Handling the event types
appropriately.

Fixes: 8dc6c2f12ecf ("crypto/octeontx: add crypto adapter data path")

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 drivers/event/octeontx/ssovf_worker.h | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff mbox series

Patch

diff --git a/drivers/event/octeontx/ssovf_worker.h b/drivers/event/octeontx/ssovf_worker.h
index e6ee292688..1e906bf694 100644
--- a/drivers/event/octeontx/ssovf_worker.h
+++ b/drivers/event/octeontx/ssovf_worker.h
@@ -179,16 +179,20 @@  ssows_get_work(struct ssows *ws, struct rte_event *ev, const uint16_t flag)
 	ev->event = sched_type_queue | (get_work0 & 0xffffffff);
 
 	if (get_work1) {
-		if (ev->event_type == RTE_EVENT_TYPE_ETHDEV)
-			get_work1 = (uintptr_t)ssovf_octeontx_wqe_to_pkt(
-				get_work1, (ev->event >> 20) & 0x7F, flag,
-				ws->lookup_mem);
-		else if (ev->event_type == RTE_EVENT_TYPE_CRYPTODEV)
+		if (ev->event_type == RTE_EVENT_TYPE_ETHDEV) {
+			ev->mbuf = ssovf_octeontx_wqe_to_pkt(
+			     get_work1, (ev->event >> 20) & 0x7F, flag,
+			     ws->lookup_mem);
+		} else if (ev->event_type == RTE_EVENT_TYPE_CRYPTODEV) {
 			get_work1 = otx_crypto_adapter_dequeue(get_work1);
-		ev->u64 = get_work1;
-	} else if (unlikely((get_work0 & 0xFFFFFFFF) == 0xFFFFFFFF)) {
-		ssovf_octeontx_wqe_free(get_work1);
-		return 0;
+			ev->u64 = get_work1;
+		} else {
+			if (unlikely((get_work0 & 0xFFFFFFFF) == 0xFFFFFFFF)) {
+				ssovf_octeontx_wqe_free(get_work1);
+				return 0;
+			}
+			ev->u64 = get_work1;
+		}
 	}
 
 	return !!get_work1;