[v4] net/ixgbe: promote MDIO API
Checks
Commit Message
From: Zhichao Zeng <zhichaox.zeng@intel.com>
Promote the MDIO APIs to be stable.
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
drivers/net/ixgbe/rte_pmd_ixgbe.h | 5 -----
drivers/net/ixgbe/version.map | 10 +++++-----
2 files changed, 5 insertions(+), 10 deletions(-)
Comments
Hi, Ray, David:
What is your opinion on this patch?
Regards,
Zhichao
-----Original Message-----
From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
Sent: Tuesday, April 19, 2022 7:06 PM
To: dev@dpdk.org
Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; mdr@ashroe.eu; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
Subject: [DPDK v4] net/ixgbe: promote MDIO API
From: Zhichao Zeng <zhichaox.zeng@intel.com>
Promote the MDIO APIs to be stable.
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
drivers/net/ixgbe/rte_pmd_ixgbe.h | 5 -----
drivers/net/ixgbe/version.map | 10 +++++-----
2 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index eef6f6661c..426fe5845b 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
* - (-ENODEV) if *port* invalid.
* - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
*/
-__rte_experimental
int
rte_pmd_ixgbe_mdio_lock(uint16_t port);
@@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
* - (-ENOTSUP) if hardware doesn't support.
* - (-ENODEV) if *port* invalid.
*/
-__rte_experimental
int
rte_pmd_ixgbe_mdio_unlock(uint16_t port);
@@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
* - (-ENODEV) if *port* invalid.
* - (IXGBE_ERR_PHY) If PHY read command failed
*/
-__rte_experimental
int
rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
uint32_t dev_type, uint16_t *phy_data); @@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
* - (-ENODEV) if *port* invalid.
* - (IXGBE_ERR_PHY) If PHY read command failed
*/
-__rte_experimental
int
rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
uint32_t dev_type, uint16_t phy_data); @@ -725,7 +721,6 @@ enum {
* - (-ENODEV) if *port* invalid.
* - (-ENOTSUP) if hardware doesn't support this feature.
*/
-__rte_experimental
int
rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map index bca5cc5826..f0f29d8749 100644
--- a/drivers/net/ixgbe/version.map
+++ b/drivers/net/ixgbe/version.map
@@ -16,6 +16,10 @@ DPDK_22 {
rte_pmd_ixgbe_macsec_enable;
rte_pmd_ixgbe_macsec_select_rxsa;
rte_pmd_ixgbe_macsec_select_txsa;
+ rte_pmd_ixgbe_mdio_lock;
+ rte_pmd_ixgbe_mdio_unlock;
+ rte_pmd_ixgbe_mdio_unlocked_read;
+ rte_pmd_ixgbe_mdio_unlocked_write;
rte_pmd_ixgbe_ping_vf;
rte_pmd_ixgbe_set_all_queues_drop_en;
rte_pmd_ixgbe_set_tc_bw_alloc;
@@ -31,6 +35,7 @@ DPDK_22 {
rte_pmd_ixgbe_set_vf_vlan_filter;
rte_pmd_ixgbe_set_vf_vlan_insert;
rte_pmd_ixgbe_set_vf_vlan_stripq;
+ rte_pmd_ixgbe_upd_fctrl_sbp;
local: *;
};
@@ -40,9 +45,4 @@ EXPERIMENTAL {
rte_pmd_ixgbe_get_fdir_info;
rte_pmd_ixgbe_get_fdir_stats;
- rte_pmd_ixgbe_mdio_lock;
- rte_pmd_ixgbe_mdio_unlock;
- rte_pmd_ixgbe_mdio_unlocked_read;
- rte_pmd_ixgbe_mdio_unlocked_write;
- rte_pmd_ixgbe_upd_fctrl_sbp;
};
--
2.25.1
Zeng, ZhichaoX <zhichaox.zeng@intel.com> writes:
> Hi, Ray, David:
>
> What is your opinion on this patch?
>
> Regards,
> Zhichao
>
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Tuesday, April 19, 2022 7:06 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue <haiyue.wang@intel.com>; mdr@ashroe.eu; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Subject: [DPDK v4] net/ixgbe: promote MDIO API
>
> From: Zhichao Zeng <zhichaox.zeng@intel.com>
>
> Promote the MDIO APIs to be stable.
>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> ---
> drivers/net/ixgbe/rte_pmd_ixgbe.h | 5 -----
> drivers/net/ixgbe/version.map | 10 +++++-----
> 2 files changed, 5 insertions(+), 10 deletions(-)
>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
> -----Original Message-----
> From: Ray Kinsella <mdr@ashroe.eu>
> Sent: Tuesday, April 26, 2022 6:12 PM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; David Marchand <david.marchand@redhat.com>
> Subject: Re: [DPDK v4] net/ixgbe: promote MDIO API
>
>
> Zeng, ZhichaoX <zhichaox.zeng@intel.com> writes:
>
> > Hi, Ray, David:
> >
> > What is your opinion on this patch?
> >
> > Regards,
> > Zhichao
> >
> > -----Original Message-----
> > From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Sent: Tuesday, April 19, 2022 7:06 PM
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Wang, Haiyue
> <haiyue.wang@intel.com>; mdr@ashroe.eu; Zeng, ZhichaoX
> <zhichaox.zeng@intel.com>
> > Subject: [DPDK v4] net/ixgbe: promote MDIO API
> >
> > From: Zhichao Zeng <zhichaox.zeng@intel.com>
> >
> > Promote the MDIO APIs to be stable.
> >
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
> > ---
> > drivers/net/ixgbe/rte_pmd_ixgbe.h | 5 -----
> > drivers/net/ixgbe/version.map | 10 +++++-----
> > 2 files changed, 5 insertions(+), 10 deletions(-)
> >
>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
Applied to dpdk-next-net-intel.
Thanks
Qi
@@ -586,7 +586,6 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
* - (-ENODEV) if *port* invalid.
* - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
*/
-__rte_experimental
int
rte_pmd_ixgbe_mdio_lock(uint16_t port);
@@ -600,7 +599,6 @@ rte_pmd_ixgbe_mdio_lock(uint16_t port);
* - (-ENOTSUP) if hardware doesn't support.
* - (-ENODEV) if *port* invalid.
*/
-__rte_experimental
int
rte_pmd_ixgbe_mdio_unlock(uint16_t port);
@@ -622,7 +620,6 @@ rte_pmd_ixgbe_mdio_unlock(uint16_t port);
* - (-ENODEV) if *port* invalid.
* - (IXGBE_ERR_PHY) If PHY read command failed
*/
-__rte_experimental
int
rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
uint32_t dev_type, uint16_t *phy_data);
@@ -646,7 +643,6 @@ rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
* - (-ENODEV) if *port* invalid.
* - (IXGBE_ERR_PHY) If PHY read command failed
*/
-__rte_experimental
int
rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
uint32_t dev_type, uint16_t phy_data);
@@ -725,7 +721,6 @@ enum {
* - (-ENODEV) if *port* invalid.
* - (-ENOTSUP) if hardware doesn't support this feature.
*/
-__rte_experimental
int
rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
@@ -16,6 +16,10 @@ DPDK_22 {
rte_pmd_ixgbe_macsec_enable;
rte_pmd_ixgbe_macsec_select_rxsa;
rte_pmd_ixgbe_macsec_select_txsa;
+ rte_pmd_ixgbe_mdio_lock;
+ rte_pmd_ixgbe_mdio_unlock;
+ rte_pmd_ixgbe_mdio_unlocked_read;
+ rte_pmd_ixgbe_mdio_unlocked_write;
rte_pmd_ixgbe_ping_vf;
rte_pmd_ixgbe_set_all_queues_drop_en;
rte_pmd_ixgbe_set_tc_bw_alloc;
@@ -31,6 +35,7 @@ DPDK_22 {
rte_pmd_ixgbe_set_vf_vlan_filter;
rte_pmd_ixgbe_set_vf_vlan_insert;
rte_pmd_ixgbe_set_vf_vlan_stripq;
+ rte_pmd_ixgbe_upd_fctrl_sbp;
local: *;
};
@@ -40,9 +45,4 @@ EXPERIMENTAL {
rte_pmd_ixgbe_get_fdir_info;
rte_pmd_ixgbe_get_fdir_stats;
- rte_pmd_ixgbe_mdio_lock;
- rte_pmd_ixgbe_mdio_unlock;
- rte_pmd_ixgbe_mdio_unlocked_read;
- rte_pmd_ixgbe_mdio_unlocked_write;
- rte_pmd_ixgbe_upd_fctrl_sbp;
};