drivers/net/ixgbe: remove expired symbols

Message ID 20220412142706.831243-1-zhichaox.zeng@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers
Series drivers/net/ixgbe: remove expired symbols |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Zeng, ZhichaoX April 12, 2022, 2:27 p.m. UTC
From: zhichao zeng <zhichaox.zeng@intel.com>

Remove expired experimental symbols.

Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
 drivers/net/ixgbe/version.map     | 10 +++++-----
 2 files changed, 10 insertions(+), 20 deletions(-)
  

Comments

Wang, Haiyue April 12, 2022, 7:23 a.m. UTC | #1
> -----Original Message-----
> From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Sent: Tuesday, April 12, 2022 22:27
> To: Wang, Haiyue <haiyue.wang@intel.com>
> Cc: dev@dpdk.org; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Subject: [DPDK] drivers/net/ixgbe: remove expired symbols
> 
> From: zhichao zeng <zhichaox.zeng@intel.com>
> 
> Remove expired experimental symbols.

The git commit can be enhanced like:

Title: net/ixgbe: promote MDIO API

Promote the MDIO APIs to be stable.

> 
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 10 insertions(+), 20 deletions(-)
> 


> diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
> index bca5cc5826..b2063df1bb 100644
> --- a/drivers/net/ixgbe/version.map
> +++ b/drivers/net/ixgbe/version.map
> @@ -31,6 +31,11 @@ DPDK_22 {
>  	rte_pmd_ixgbe_set_vf_vlan_filter;
>  	rte_pmd_ixgbe_set_vf_vlan_insert;
>  	rte_pmd_ixgbe_set_vf_vlan_stripq;
> +	rte_pmd_ixgbe_mdio_lock;
> +	rte_pmd_ixgbe_mdio_unlock;
> +	rte_pmd_ixgbe_mdio_unlocked_read;
> +	rte_pmd_ixgbe_mdio_unlocked_write;

Put the above under ' rte_pmd_ixgbe_macsec_select_txsa;'

This is in alphabet order.

> +	rte_pmd_ixgbe_upd_fctrl_sbp;
> 
>  	local: *;
>  };
> @@ -40,9 +45,4 @@ EXPERIMENTAL {
> 
>  	rte_pmd_ixgbe_get_fdir_info;
>  	rte_pmd_ixgbe_get_fdir_stats;
> -	rte_pmd_ixgbe_mdio_lock;
> -	rte_pmd_ixgbe_mdio_unlock;
> -	rte_pmd_ixgbe_mdio_unlocked_read;
> -	rte_pmd_ixgbe_mdio_unlocked_write;
> -	rte_pmd_ixgbe_upd_fctrl_sbp;
>  };
> --
> 2.25.1
  
Bruce Richardson April 12, 2022, 8:38 a.m. UTC | #2
On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.zeng@intel.com wrote:
> From: zhichao zeng <zhichaox.zeng@intel.com>
> 
> Remove expired experimental symbols.
> 
> Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
>  drivers/net/ixgbe/version.map     | 10 +++++-----
>  2 files changed, 10 insertions(+), 20 deletions(-)
> 
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> index eef6f6661c..4f1fe6029d 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
>   *   - (-ENODEV) if *port* invalid.
>   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
>   */
> -__rte_experimental
> -int
> -rte_pmd_ixgbe_mdio_lock(uint16_t port);
> +int rte_pmd_ixgbe_mdio_lock(uint16_t port);
>  

I don't see the value in rewriting the prototypes to be all on one line as
part of this change. Just remove the experimental tag line in this patch,
to keep the diff as small as possible.

/Bruce
  
David Marchand April 12, 2022, 8:47 a.m. UTC | #3
On Tue, Apr 12, 2022 at 9:23 AM Wang, Haiyue <haiyue.wang@intel.com> wrote:
>
> > -----Original Message-----
> > From: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Sent: Tuesday, April 12, 2022 22:27
> > To: Wang, Haiyue <haiyue.wang@intel.com>
> > Cc: dev@dpdk.org; Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> > Subject: [DPDK] drivers/net/ixgbe: remove expired symbols
> >
> > From: zhichao zeng <zhichaox.zeng@intel.com>
> >
> > Remove expired experimental symbols.
>
> The git commit can be enhanced like:
>
> Title: net/ixgbe: promote MDIO API
>
> Promote the MDIO APIs to be stable.

Please, use get-maintainer.sh when sending patches, it will
automatically Cc relevant people.
Adding Ray in the loop.
  
Wang, Haiyue April 12, 2022, 8:52 a.m. UTC | #4
> -----Original Message-----
> From: Richardson, Bruce <bruce.richardson@intel.com>
> Sent: Tuesday, April 12, 2022 16:39
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
> Subject: Re: [DPDK] drivers/net/ixgbe: remove expired symbols
> 
> On Tue, Apr 12, 2022 at 02:27:06PM +0000, zhichaox.zeng@intel.com wrote:
> > From: zhichao zeng <zhichaox.zeng@intel.com>
> >
> > Remove expired experimental symbols.
> >
> > Signed-off-by: zhichao zeng <zhichaox.zeng@intel.com>
> > ---
> >  drivers/net/ixgbe/rte_pmd_ixgbe.h | 20 +++++---------------
> >  drivers/net/ixgbe/version.map     | 10 +++++-----
> >  2 files changed, 10 insertions(+), 20 deletions(-)
> >
> > diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > index eef6f6661c..4f1fe6029d 100644
> > --- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
> > @@ -586,9 +586,7 @@ int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
> >   *   - (-ENODEV) if *port* invalid.
> >   *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
> >   */
> > -__rte_experimental
> > -int
> > -rte_pmd_ixgbe_mdio_lock(uint16_t port);
> > +int rte_pmd_ixgbe_mdio_lock(uint16_t port);
> >
> 
> I don't see the value in rewriting the prototypes to be all on one line as
> part of this change. Just remove the experimental tag line in this patch,
> to keep the diff as small as possible.

+1, yes, clean patch. ;-)

> 
> /Bruce
  

Patch

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.h b/drivers/net/ixgbe/rte_pmd_ixgbe.h
index eef6f6661c..4f1fe6029d 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.h
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.h
@@ -586,9 +586,7 @@  int rte_pmd_ixgbe_bypass_wd_reset(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_SWFW_SYNC) If sw/fw semaphore acquisition failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_lock(uint16_t port);
+int rte_pmd_ixgbe_mdio_lock(uint16_t port);
 
 /**
  * Release swfw semaphore lock used for MDIO access
@@ -600,9 +598,7 @@  rte_pmd_ixgbe_mdio_lock(uint16_t port);
  *   - (-ENOTSUP) if hardware doesn't support.
  *   - (-ENODEV) if *port* invalid.
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlock(uint16_t port);
+int rte_pmd_ixgbe_mdio_unlock(uint16_t port);
 
 /**
  * Read PHY register using MDIO without MDIO lock
@@ -622,9 +618,7 @@  rte_pmd_ixgbe_mdio_unlock(uint16_t port);
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
+int rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
 				 uint32_t dev_type, uint16_t *phy_data);
 
 /**
@@ -646,9 +640,7 @@  rte_pmd_ixgbe_mdio_unlocked_read(uint16_t port, uint32_t reg_addr,
  *   - (-ENODEV) if *port* invalid.
  *   - (IXGBE_ERR_PHY) If PHY read command failed
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
+int rte_pmd_ixgbe_mdio_unlocked_write(uint16_t port, uint32_t reg_addr,
 				  uint32_t dev_type, uint16_t phy_data);
 
 /**
@@ -725,9 +717,7 @@  enum {
  *   - (-ENODEV) if *port* invalid.
  *   - (-ENOTSUP) if hardware doesn't support this feature.
  */
-__rte_experimental
-int
-rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
+int rte_pmd_ixgbe_upd_fctrl_sbp(uint16_t port, int enable);
 
 /**
  * Get port fdir info
diff --git a/drivers/net/ixgbe/version.map b/drivers/net/ixgbe/version.map
index bca5cc5826..b2063df1bb 100644
--- a/drivers/net/ixgbe/version.map
+++ b/drivers/net/ixgbe/version.map
@@ -31,6 +31,11 @@  DPDK_22 {
 	rte_pmd_ixgbe_set_vf_vlan_filter;
 	rte_pmd_ixgbe_set_vf_vlan_insert;
 	rte_pmd_ixgbe_set_vf_vlan_stripq;
+	rte_pmd_ixgbe_mdio_lock;
+	rte_pmd_ixgbe_mdio_unlock;
+	rte_pmd_ixgbe_mdio_unlocked_read;
+	rte_pmd_ixgbe_mdio_unlocked_write;
+	rte_pmd_ixgbe_upd_fctrl_sbp;
 
 	local: *;
 };
@@ -40,9 +45,4 @@  EXPERIMENTAL {
 
 	rte_pmd_ixgbe_get_fdir_info;
 	rte_pmd_ixgbe_get_fdir_stats;
-	rte_pmd_ixgbe_mdio_lock;
-	rte_pmd_ixgbe_mdio_unlock;
-	rte_pmd_ixgbe_mdio_unlocked_read;
-	rte_pmd_ixgbe_mdio_unlocked_write;
-	rte_pmd_ixgbe_upd_fctrl_sbp;
 };