examples/vhost: fix floating point exception when there is no VMDQ
Checks
Commit Message
If the VMDQ limits is 0, a divide-by-zero error occurs.
This patch replaces throwing a floating point exception with
a normal error message.
Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
---
examples/vhost/main.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
Hi Yuan,
> -----Original Message-----
> From: Wang, YuanX <yuanx.wang@intel.com>
> Sent: Tuesday, April 12, 2022 12:35 AM
> To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> <xingguang.he@intel.com>; Wang, YuanX <yuanx.wang@intel.com>
> Subject: [PATCH] examples/vhost: fix floating point exception when there
> is no VMDQ
Based on the error reported by devtools/check-git-log.sh
Title better be: examples/vhost: fix floating point exception when no VMDq
>
> If the VMDQ limits is 0, a divide-by-zero error occurs.
> This patch replaces throwing a floating point exception with
> a normal error message.
Pls add fix and cc-stable tag.
Thanks,
Chenbo
>
> Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> ---
> examples/vhost/main.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index d94fabb060..815ac1cd57 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -400,6 +400,10 @@ port_init(uint16_t port)
>
> return retval;
> }
> + if (dev_info.max_vmdq_pools == 0) {
> + RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDQ info.\n");
> + return -1;
> + }
>
> rxconf = &dev_info.default_rxconf;
> txconf = &dev_info.default_txconf;
> --
> 2.25.1
Hi Chenbo,
> -----Original Message-----
> From: Xia, Chenbo <chenbo.xia@intel.com>
> Sent: Monday, May 16, 2022 8:57 PM
> To: Wang, YuanX <yuanx.wang@intel.com>; maxime.coquelin@redhat.com
> Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> <xingguang.he@intel.com>
> Subject: RE: [PATCH] examples/vhost: fix floating point exception when
> there is no VMDQ
>
> Hi Yuan,
>
> > -----Original Message-----
> > From: Wang, YuanX <yuanx.wang@intel.com>
> > Sent: Tuesday, April 12, 2022 12:35 AM
> > To: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>
> > Cc: dev@dpdk.org; Hu, Jiayu <jiayu.hu@intel.com>; He, Xingguang
> > <xingguang.he@intel.com>; Wang, YuanX <yuanx.wang@intel.com>
> > Subject: [PATCH] examples/vhost: fix floating point exception when
> > there is no VMDQ
>
> Based on the error reported by devtools/check-git-log.sh
>
> Title better be: examples/vhost: fix floating point exception when no VMDq
>
> >
> > If the VMDQ limits is 0, a divide-by-zero error occurs.
> > This patch replaces throwing a floating point exception with a normal
> > error message.
>
> Pls add fix and cc-stable tag.
Thanks for the comments, will fix it in next version.
Regards,
Yuan
>
> Thanks,
> Chenbo
>
> >
> > Signed-off-by: Yuan Wang <yuanx.wang@intel.com>
> > ---
> > examples/vhost/main.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/examples/vhost/main.c b/examples/vhost/main.c index
> > d94fabb060..815ac1cd57 100644
> > --- a/examples/vhost/main.c
> > +++ b/examples/vhost/main.c
> > @@ -400,6 +400,10 @@ port_init(uint16_t port)
> >
> > return retval;
> > }
> > + if (dev_info.max_vmdq_pools == 0) {
> > + RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDQ info.\n");
> > + return -1;
> > + }
> >
> > rxconf = &dev_info.default_rxconf;
> > txconf = &dev_info.default_txconf;
> > --
> > 2.25.1
@@ -400,6 +400,10 @@ port_init(uint16_t port)
return retval;
}
+ if (dev_info.max_vmdq_pools == 0) {
+ RTE_LOG(ERR, VHOST_PORT, "Failed to get VMDQ info.\n");
+ return -1;
+ }
rxconf = &dev_info.default_rxconf;
txconf = &dev_info.default_txconf;