From patchwork Mon Mar 7 22:39:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Honnappa Nagarahalli X-Patchwork-Id: 108588 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6A249A0093; Mon, 7 Mar 2022 23:39:56 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CD9AB426D6; Mon, 7 Mar 2022 23:39:55 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 9C58F4122E; Mon, 7 Mar 2022 23:39:54 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id E58941570; Mon, 7 Mar 2022 14:39:53 -0800 (PST) Received: from dp6132.usa.Arm.com (dp6132.usa.arm.com [10.118.91.150]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D9FBD3FA5D; Mon, 7 Mar 2022 14:39:53 -0800 (PST) From: Honnappa Nagarahalli To: dev@dpdk.org, honnappa.nagarahalli@arm.com, lijuan.tu@intel.com, juraj.linkes@pantheon.tech, ohilyard@iol.unh.edu, david.marchand@redhat.com, thomas@monjalon.net, david.hunt@intel.com Cc: ruifeng.wang@arm.com, nd@arm.com, bruce.richardson@intel.com, reshma.pattan@intel.com, stable@dpdk.org Subject: [PATCH] examples/distributor: one Tx queue is enough Date: Mon, 7 Mar 2022 22:39:46 +0000 Message-Id: <20220307223946.578201-1-honnappa.nagarahalli@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Distributor application creates one Tx queue per core. However the transmit is done only from a single core. Hence creating one Tx queue is enough. Fixes: 07db4a975094 ("examples/distributor: new sample app") Cc: bruce.richardson@intel.com Cc: reshma.pattan@intel.com Cc: stable@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Ruifeng Wang Acked-by: Bruce Richardson --- DTS test cases make this change to DPDK. However, I find that, one queue is enough. Hence we could make this change in DPDK. examples/distributor/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/distributor/main.c b/examples/distributor/main.c index c681e237ea..02bf91f555 100644 --- a/examples/distributor/main.c +++ b/examples/distributor/main.c @@ -108,7 +108,7 @@ static inline int port_init(uint16_t port, struct rte_mempool *mbuf_pool) { struct rte_eth_conf port_conf = port_conf_default; - const uint16_t rxRings = 1, txRings = rte_lcore_count() - 1; + const uint16_t rxRings = 1, txRings = 1; int retval; uint16_t q; uint16_t nb_rxd = RX_RING_SIZE;