[v3,03/21] net/ena: remove unused enumeration

Message ID 20220223121944.24156-4-mk@semihalf.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series net/ena: v2.6.0 driver update |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Michal Krawczyk Feb. 23, 2022, 12:19 p.m. UTC
  The enumeration seems to be leftover from porting the Linux driver to
the DPDK. It was used nowhere and refers to the ethtool which is not
present in the DPDK.

Signed-off-by: Michal Krawczyk <mk@semihalf.com>
Reviewed-by: Artur Rojek <ar@semihalf.com>
Reviewed-by: Dawid Gorecki <dgr@semihalf.com>
Reviewed-by: Igor Chauskin <igorch@amazon.com>
Reviewed-by: Shai Brandes <shaibran@amazon.com>
---
 drivers/net/ena/ena_ethdev.c | 5 -----
 1 file changed, 5 deletions(-)
  

Comments

Ferruh Yigit Feb. 23, 2022, 5:25 p.m. UTC | #1
On 2/23/2022 12:19 PM, Michal Krawczyk wrote:
> The enumeration seems to be leftover from porting the Linux driver to
> the DPDK. It was used nowhere and refers to the ethtool which is not
> present in the DPDK.
> 

     Fixes: 372c1af5ed8f ("net/ena: add dedicated memory area for extra device info")
     Cc: stable@dpdk.org


> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> Reviewed-by: Artur Rojek <ar@semihalf.com>
> Reviewed-by: Dawid Gorecki <dgr@semihalf.com>
> Reviewed-by: Igor Chauskin <igorch@amazon.com>
> Reviewed-by: Shai Brandes <shaibran@amazon.com>
> ---
>   drivers/net/ena/ena_ethdev.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
> index 34fb43cb00..2de2dcf12f 100644
> --- a/drivers/net/ena/ena_ethdev.c
> +++ b/drivers/net/ena/ena_ethdev.c
> @@ -38,11 +38,6 @@
>   
>   #define ENA_PTYPE_HAS_HASH	(RTE_PTYPE_L4_TCP | RTE_PTYPE_L4_UDP)
>   
> -enum ethtool_stringset {
> -	ETH_SS_TEST             = 0,
> -	ETH_SS_STATS,
> -};
> -
>   struct ena_stats {
>   	char name[ETH_GSTRING_LEN];
>   	int stat_offset;
  

Patch

diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 34fb43cb00..2de2dcf12f 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -38,11 +38,6 @@ 
 
 #define ENA_PTYPE_HAS_HASH	(RTE_PTYPE_L4_TCP | RTE_PTYPE_L4_UDP)
 
-enum ethtool_stringset {
-	ETH_SS_TEST             = 0,
-	ETH_SS_STATS,
-};
-
 struct ena_stats {
 	char name[ETH_GSTRING_LEN];
 	int stat_offset;