From patchwork Wed Feb 23 12:19:25 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 108146 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B240A034C; Wed, 23 Feb 2022 13:20:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C43B8426E1; Wed, 23 Feb 2022 13:20:35 +0100 (CET) Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) by mails.dpdk.org (Postfix) with ESMTP id 8AF79426DF for ; Wed, 23 Feb 2022 13:20:32 +0100 (CET) Received: by mail-ej1-f53.google.com with SMTP id r13so28945275ejd.5 for ; Wed, 23 Feb 2022 04:20:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7KiXXJkZFs2qCSF+Mclhm1PBHziNSclPNxIDnRkxyaY=; b=ovm7hZxfwFdv0pSqxU/vr9xjmgABcutct/3fFNH/B3OOOqEyWMu1kNOAuo7XWO3NJN JunA7T8qOiwdsiTUmL9KBoJekuBy11Jhs8TeArrZXiutGdtZVCEpxMnLY79TZNJ/QpGV rUY0QaHdygkyJeuzS4HwpCdJhRlS8Oe75o6e6wuFdMzFI2eoUVHIllGbwOEyQALejzdo +lSBhMr/ht85OPm6bRXTrcYH4aAm+mNWJYH9nRhuW/6ian+HWYAYhGvmHbCXVGpa1e1X X1I30neWpqY/hrybm0F1YN+YJZS5vsDnu3OMVXQODwe8Y9glAYJ52JbButcrSR5KnWK+ 8Uxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7KiXXJkZFs2qCSF+Mclhm1PBHziNSclPNxIDnRkxyaY=; b=Cvs7t4EimyLFAPZ+EvnJMSDOu4JRk4LFKfidHdylNsxPI8Ka8iXrFTxsAWtxqDPqHO dSt8V6U7HMESMSIUpYsm1SQAjcwmi3cCwzzB7YT2lHHZYF55qA3hDTNl6T+jTiQBhgV/ YtyqHmtteIQ4N0vN+b/G9ylIjDgCst9kACqFYWMiwzIENNeRi5RsGxcMfrMxPhoJdKMa Hv6i2GmuCpj9FU159LyvtvTAQ+hJZuCyvywFa1AtjVL2uXQTa+DEL2agU/zHERBmQCxH /sZMIPchC5YMl+CZduv8OQmAUCvafUlnX7UdmcCKLes73TZbngx0uvlSWKD1QU39lczo fgLw== X-Gm-Message-State: AOAM531odsftMqnEvwS1a47AO9cMhXR/BW8AWPU423zbUNqG6UDxus2l hiJ1PH+fV8wIQ76emPeZbg2qCgURlgv7BA== X-Google-Smtp-Source: ABdhPJyVPaRwPxD3AnT1TaYcheazEw/wffFD1R3o3pQHbaGkHjmJTHg3Kvw/Do03WaNZMXo7cStUNg== X-Received: by 2002:a17:906:2695:b0:6ce:b94d:9f07 with SMTP id t21-20020a170906269500b006ceb94d9f07mr23494193ejc.297.1645618831858; Wed, 23 Feb 2022 04:20:31 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id v12sm11629224edr.8.2022.02.23.04.20.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 04:20:31 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: ferruh.yigit@intel.com, shaibran@amazon.com, upstream@semihalf.com, Michal Krawczyk , Dawid Gorecki Subject: [PATCH v3 02/21] net/ena: add assertion on Tx info mbuf Date: Wed, 23 Feb 2022 13:19:25 +0100 Message-Id: <20220223121944.24156-3-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220223121944.24156-1-mk@semihalf.com> References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org To make sure there is no outstanding mbuf in the reused Tx queue (due to unproper cleanup, or some invalid logic on Tx path), the assertion was added on the Tx path. As it's being compiled out in the release version, it won't affect the IO path performance. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index deaee30664..34fb43cb00 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2661,6 +2661,7 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf) req_id = tx_ring->empty_tx_reqs[next_to_use]; tx_info = &tx_ring->tx_buffer_info[req_id]; tx_info->num_of_bufs = 0; + RTE_ASSERT(tx_info->mbuf == NULL); ena_tx_map_mbuf(tx_ring, tx_info, mbuf, &push_header, &header_len);