From patchwork Wed Feb 23 12:19:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 108163 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EF218A034C; Wed, 23 Feb 2022 13:22:15 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BC8E4274A; Wed, 23 Feb 2022 13:20:57 +0100 (CET) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by mails.dpdk.org (Postfix) with ESMTP id 9E03142701 for ; Wed, 23 Feb 2022 13:20:53 +0100 (CET) Received: by mail-ed1-f48.google.com with SMTP id bq11so22571688edb.2 for ; Wed, 23 Feb 2022 04:20:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=sYF9oKYnjBsRPnacHorjguRyi3Iq8jyPaApiXFQLrw0=; b=oI+sohUX70i8VhYbwxqB9mTW+NqyevyYgfldDXISjJSKuF2DVpYfXlrTy4gRsmyzWT +9OGruC+Oi6w4SjYVkEDjHhTewQzGdTl8vJlrfmCCNub60pqULrwfs0DILVBagAeSZxk IlcycI0joPcBs5an4x1viHlO5NV4AuRc9U6/Coiqs7tz0VfaW3aBt8rIIbA8QKe65RSU YrXW+1D6dZMwVBm44WXFOrnyA9VHJjN6Apx29VgLwC2Tb4yVRUYhzCXIbniZaPmEZ6WC kYJtXoH4mtrTEszYoc2TmwFRgL2MRCU+MU97XYamaiNU/TVc7dhEOrvsRA9R0aaX5ayL Iq3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=sYF9oKYnjBsRPnacHorjguRyi3Iq8jyPaApiXFQLrw0=; b=OTS6nrXpCF+YSf+/iwGQk0RGTGirrMSmK1GnmGZqHgn8/Mt3fJfaw+C3bKCnJAo4AZ 4UDB1Cjf3jDET8nzJqDe279Rj2hV8itSOG+Z9DXuTOfLyD7TVm5g9qmEEE0KPkE+6CCV PqbyLE20vglk1948Zk6czn7VGaI1R3LTDeAT36rDsI3HKI5+KmdN/BbYCGVJBDOsqVuw 1gRYkeqrepqRGS7EDgth2M43smqkXhTQJD26cdvzLeLsalaIRJdHzFKQ6S9vgv/xSgc6 guMFxIQKzWXFvjkMU/BugoO+oShp2lzbweqS9ROk2lVasFvHMqu7aIST3iOrABkwJ04x Pp5A== X-Gm-Message-State: AOAM533YgA/Fvfn+Ax/dTVeDcE2c5d+s/v9oeSdwdkOHDUPu34xwZuka v/oIglYjCa7cl1ZegS/TYNzO9TDc7Td82g== X-Google-Smtp-Source: ABdhPJwxppp44C468ka+fxQiHJtBZQYxx0CpQ3urjlZXAPDzZjHW16jGb9vOn+y9mx7hCeJa7ym1Dw== X-Received: by 2002:a50:d086:0:b0:413:38a6:24a7 with SMTP id v6-20020a50d086000000b0041338a624a7mr2399426edd.183.1645618853142; Wed, 23 Feb 2022 04:20:53 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id v12sm11629224edr.8.2022.02.23.04.20.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 04:20:52 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: ferruh.yigit@intel.com, shaibran@amazon.com, upstream@semihalf.com, Dawid Gorecki , stable@dpdk.org, Michal Krawczyk Subject: [PATCH v3 19/21] net/ena: don't initialize LLQ when membar isn't exposed Date: Wed, 23 Feb 2022 13:19:42 +0100 Message-Id: <20220223121944.24156-20-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220223121944.24156-1-mk@semihalf.com> References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dawid Gorecki The ena_com_config_dev_mode() performs many calculations related to LLQ and then performs an admin queue call to configure LLQ in the device. All of the operations performed by ena_com_config_dev_mode() are unnecessary if membar hasn't been found. Move the dev_mem_base check before ena_com_config_dev_mode() call. This prevents the unnecessary operations from being performed. Fixes: 2fca2a98c0d1 ("net/ena: support LLQv2") Cc: stable@dpdk.org Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index b471102ea9..151c688eec 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1953,6 +1953,13 @@ ena_set_queues_placement_policy(struct ena_adapter *adapter, return 0; } + if (adapter->dev_mem_base == NULL) { + PMD_DRV_LOG(ERR, + "LLQ is advertised as supported, but device doesn't expose mem bar\n"); + ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; + return 0; + } + rc = ena_com_config_dev_mode(ena_dev, llq, llq_default_configurations); if (unlikely(rc)) { PMD_INIT_LOG(WARNING, @@ -1965,13 +1972,6 @@ ena_set_queues_placement_policy(struct ena_adapter *adapter, if (ena_dev->tx_mem_queue_type == ENA_ADMIN_PLACEMENT_POLICY_HOST) return 0; - if (!adapter->dev_mem_base) { - PMD_DRV_LOG(ERR, - "Unable to access LLQ BAR resource. Fallback to host mode policy.\n"); - ena_dev->tx_mem_queue_type = ENA_ADMIN_PLACEMENT_POLICY_HOST; - return 0; - } - ena_dev->mem_bar = adapter->dev_mem_base; return 0;