From patchwork Wed Feb 23 12:19:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 108162 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D00EA034C; Wed, 23 Feb 2022 13:22:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0B1F242743; Wed, 23 Feb 2022 13:20:56 +0100 (CET) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) by mails.dpdk.org (Postfix) with ESMTP id 7A9EF42726 for ; Wed, 23 Feb 2022 13:20:52 +0100 (CET) Received: by mail-ed1-f50.google.com with SMTP id h15so26859091edv.7 for ; Wed, 23 Feb 2022 04:20:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QUHrkGN7+wvIDSCwzq8c4SjCkUXayVvM3ShSIS9n6WA=; b=r4OHM1UAy8RXSDXr9abQm4tberH62lO9E6CP+RqPYwtbL5Vp8oVcY4dHH/NMGekLjW FAuchp+N0Pll0dixEyVeXe6iDp5MZASVsnKKORbaUouUVTup+1fQY3s2vrRuQG5+MRT5 fYN7gYE3IenJWh5UvKMBv1IKwFqS6dTHeN1N8Kh4YcRt6bmEeqUGLhhB3a66jUpmR6NG Kv5fLK5yN9ArSRANGowdub85ayPyA3HroF7IewtxIZaotleWWWowgIlC5YTYYR+wVrGH hU54us+gNkCk865Nni/Il0vlRhEO0ZvIpfqIXScNpqtspeCXJ+ZoSUVuH31Ht0sOYTiA 7FVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QUHrkGN7+wvIDSCwzq8c4SjCkUXayVvM3ShSIS9n6WA=; b=MJkeugtS8AtEhejLPd++QcGososeMkax155lGJiMXc8H5H6uWEp+XkCY12ZgxFx4rj piA2a9DoVoMweulJgAYl1SCz01/qO+beIV5xose1NuOCmYO8o6sJAXOdJsgINCve/jLb 3dqh1NITpAOFQjgTFBrfdzRPYLW7Rgb3iHXVsnwEZ0PxYbM18yykzg4Mul56yI5oPqhj w5A1BwqtdCID0vQ7y4489QKORf55kh073Cg8sMBXwVPre5Yy7i3i4fMsEZFzJ1hW3t3M NMCpKD5i/KSyEnw+P8/eAmlRACq6yorDnRnrjA8TQVeChOPRAn8ePr9ZDwVhfPoeYbvR evZw== X-Gm-Message-State: AOAM532ea1Gr/YlBBncZojzI3zphnvP5JYm9d/LyiUZEWDdPPfOOcDUx 1OJi54ULKQ2OpIJA1cIGoWcGvNmMW1L98w== X-Google-Smtp-Source: ABdhPJx+K0HBESLcCDVE6aL/6AK/eKvRy7VUp1/JtGfD+YdWhWH1gLF9w6xFwlbpFFo49yOval4XHg== X-Received: by 2002:a50:f118:0:b0:413:2c9e:d519 with SMTP id w24-20020a50f118000000b004132c9ed519mr5155422edl.387.1645618851954; Wed, 23 Feb 2022 04:20:51 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id v12sm11629224edr.8.2022.02.23.04.20.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Feb 2022 04:20:51 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: ferruh.yigit@intel.com, shaibran@amazon.com, upstream@semihalf.com, Dawid Gorecki , Michal Krawczyk Subject: [PATCH v3 18/21] net/ena: extend debug prints for invalid req ID resets Date: Wed, 23 Feb 2022 13:19:41 +0100 Message-Id: <20220223121944.24156-19-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220223121944.24156-1-mk@semihalf.com> References: <20220222181146.28882-1-mk@semihalf.com> <20220223121944.24156-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dawid Gorecki Add information about port id, queue id and req_id to error logs in validate_tx_req_id. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 53a8071968..b471102ea9 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -675,9 +675,11 @@ static int validate_tx_req_id(struct ena_ring *tx_ring, u16 req_id) } if (tx_info) - PMD_TX_LOG(ERR, "tx_info doesn't have valid mbuf\n"); + PMD_TX_LOG(ERR, "tx_info doesn't have valid mbuf. queue %d:%d req_id %u\n", + tx_ring->port_id, tx_ring->id, req_id); else - PMD_TX_LOG(ERR, "Invalid req_id: %hu\n", req_id); + PMD_TX_LOG(ERR, "Invalid req_id: %hu in queue %d:%d\n", + req_id, tx_ring->port_id, tx_ring->id); /* Trigger device reset */ ++tx_ring->tx_stats.bad_req_id;