From patchwork Tue Feb 22 18:11:29 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 108012 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55371A034E; Tue, 22 Feb 2022 19:12:32 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 26AC641156; Tue, 22 Feb 2022 19:12:18 +0100 (CET) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) by mails.dpdk.org (Postfix) with ESMTP id D428641151 for ; Tue, 22 Feb 2022 19:12:14 +0100 (CET) Received: by mail-ej1-f46.google.com with SMTP id d10so45433166eje.10 for ; Tue, 22 Feb 2022 10:12:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=essxYOnKPPe+crKy13EzyluvIY0P3kBRk7ehFkEAhZ4=; b=UhttmVJbsK+wXIzPFcjV/NWMyKs8AQbRMiPxOI9tav7JshWCrD54mgaC5W9SAzjRcj GrSgKlc96CEaBtz51rK8tYJTtjPFXbpWCS2Z7Guq6RGYjn3OKKUBeAMLLNi8ET3scCO3 tRmc+hV5mI4cXrQaWFUOAhGKU/RFSRspDxjQRWsRaGKFiwvSxZwFkqz7gc9pMRZn/DjT Y0+kOJh7UpD3tsh+eXgqIxKwR7cYcofoP3D3f13I9Ne96mShWE47luzUYjzTHCMergym PdD5cGBLoT9n9Mij8jfIL+VgAiw7lVt9x9bNvs0mtoyjKpi8WCP12HBR/Ajk2Pi9lu7S IUOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=essxYOnKPPe+crKy13EzyluvIY0P3kBRk7ehFkEAhZ4=; b=5DKsVTkU/mMOHmiYS32ijiGU/X2ckCkWIDCdMYctcL8dnDCY+XSMR/TLADLy10CpjQ DsCYwQ0rp9lvrj/7rwGp39pNQpXNc7Xly60n+8cUoUSwSELmZAF6lw81CFBcNmYXUsJ6 qCCCILPb27H05ZZnGkSreFjL5q4RM2NCQ54nfi9Qj7WFQh1J4Bxu6lCI6TUJIR82z2aJ l3OOxKF5RNHbmlGhiUhw2fhhLc+DC2tE3qnMQN+qI2iiUTPnNqv+wOBBjFmny4FC66/3 Am+mjGUo3Rz9uTcmxx/M95Huqp9uHepb83/KLBIHuRQVFs1yGWsriVZJ4kTZ1EEFORvn YR1Q== X-Gm-Message-State: AOAM531k19aANZtxpADmYqZ6iS28uT8EqfELB2XFWXiweYUUb9c13Ou0 /97dCv8Qjmvgtk2fSlNpZ93hVXEcKhEP0w== X-Google-Smtp-Source: ABdhPJxfV5HJh4kcZRlG9b/UeoDjBhsZuzyG3gS7bRBF7ok06fXXLJiPMLlOOF9UUIrGP9lNKpVu5A== X-Received: by 2002:a17:906:848f:b0:6cf:7234:8ae with SMTP id m15-20020a170906848f00b006cf723408aemr20733070ejx.620.1645553533929; Tue, 22 Feb 2022 10:12:13 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id y21sm10610153eda.38.2022.02.22.10.12.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 10:12:13 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: shaibran@amazon.com, upstream@semihalf.com, Michal Krawczyk , Artur Rojek , Dawid Gorecki , Igor Chauskin Subject: [PATCH v2 04/21] net/ena: remove unused offloads variables Date: Tue, 22 Feb 2022 19:11:29 +0100 Message-Id: <20220222181146.28882-5-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222181146.28882-1-mk@semihalf.com> References: <20220222160634.24489-1-mk@semihalf.com> <20220222181146.28882-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Those variables are being set, but never read. As they seem to be leftover from the old offloads API and don't have any purpose right now, they are simply being removed. Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 --- drivers/net/ena/ena_ethdev.h | 5 ----- 2 files changed, 8 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 2de2dcf12f..de5fdb8f1d 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) */ adapter->tx_cleanup_stall_delay = adapter->missing_tx_completion_to / 2; - adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; - adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; - return 0; } diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h index f47ba3fb02..4dfa604d51 100644 --- a/drivers/net/ena/ena_ethdev.h +++ b/drivers/net/ena/ena_ethdev.h @@ -278,11 +278,6 @@ struct ena_adapter { struct ena_driver_stats *drv_stats; enum ena_adapter_state state; - uint64_t tx_supported_offloads; - uint64_t tx_selected_offloads; - uint64_t rx_supported_offloads; - uint64_t rx_selected_offloads; - bool link_status; enum ena_regs_reset_reason_types reset_reason;