From patchwork Tue Feb 22 18:11:27 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 108010 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02F35A034E; Tue, 22 Feb 2022 19:12:21 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F1CF4114E; Tue, 22 Feb 2022 19:12:14 +0100 (CET) Received: from mail-ej1-f50.google.com (mail-ej1-f50.google.com [209.85.218.50]) by mails.dpdk.org (Postfix) with ESMTP id 0687741143 for ; Tue, 22 Feb 2022 19:12:12 +0100 (CET) Received: by mail-ej1-f50.google.com with SMTP id p9so45455798ejd.6 for ; Tue, 22 Feb 2022 10:12:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7KiXXJkZFs2qCSF+Mclhm1PBHziNSclPNxIDnRkxyaY=; b=YhNhrXaD3F3p0QmJ+ns2dEIxODum2kG++lOfDkuTRocfwAgcVKsHBQZ8tWBrKY6xq7 XTkXUO4ZHVX7Ig/4CAodnH/EDEBJifK9QvVhX1nkEGP9vqS1vNf6kPNQR6H5uKQ5CPZd JE/HR8GmO9N6TS6e8a9PxoHAPMcCxzbBVU8p2O/iVeH+wZVX24vXk8LJfpdcXiScKc6b Hb2Ywc7xhk5az2MQnshRoTEMkZz22wjZreoaTUEyolElYvjX3+9ltUJ78lclcw81k0Lo 9Xb7uqedxvtGRT45G+z/VZ7mSSrWQdEeQ6uHYstXPr0e3Zk/K4MV8vM1Fe56zDQLsHLJ hJlA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7KiXXJkZFs2qCSF+Mclhm1PBHziNSclPNxIDnRkxyaY=; b=07aAPFx8AJ6MMkEiBqArNSK6gr31FrmPRC9u3mWoSpGGFobMJBhTtVnTxlERPvfJRd On6Zua+ldevwOd8FArlHfqezPhGItbX1KU8b0yMB8pupPz2wMFW2L7Ghavbi8GEwKfMh NwjKWGmuss+uPnMs6+I0UMnu0O1IoelU7XWqX4joL/fT4fISZIGWkz0LEXvtVJDXy31O ISeZM1vyspP0nzkoLMhe985Qj+VXAZ7YhCNjpGTLtP/SsIb5kOFStO3i36BFDcGE3KTS DQV67lwcHb8b7zUyCEt4xayExPAPa7pKuLkMOfH11VrjLqSW8Zukx3OzhTcS0j2yTUnT NkHg== X-Gm-Message-State: AOAM53077HoNk/n6MxQUuDThOJWbgyScfdIwdt6xhM7fKtpuOsSrew4L +NG9ojN8l7rRi8kUik/ss+VaXgS8BWTDpA== X-Google-Smtp-Source: ABdhPJyynoX4Xta2zif+tiob5+Nswy1NPFH6Rd6/vtWcXpOJzZ7NzhOZbMwECb02Uo+qLaRxH8HtlA== X-Received: by 2002:a17:907:8a04:b0:6b7:ebf1:efbe with SMTP id sc4-20020a1709078a0400b006b7ebf1efbemr19593518ejc.488.1645553531233; Tue, 22 Feb 2022 10:12:11 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id y21sm10610153eda.38.2022.02.22.10.12.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 10:12:10 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: shaibran@amazon.com, upstream@semihalf.com, Michal Krawczyk , Dawid Gorecki Subject: [PATCH v2 02/21] net/ena: add assertion on Tx info mbuf Date: Tue, 22 Feb 2022 19:11:27 +0100 Message-Id: <20220222181146.28882-3-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222181146.28882-1-mk@semihalf.com> References: <20220222160634.24489-1-mk@semihalf.com> <20220222181146.28882-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org To make sure there is no outstanding mbuf in the reused Tx queue (due to unproper cleanup, or some invalid logic on Tx path), the assertion was added on the Tx path. As it's being compiled out in the release version, it won't affect the IO path performance. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index deaee30664..34fb43cb00 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2661,6 +2661,7 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf) req_id = tx_ring->empty_tx_reqs[next_to_use]; tx_info = &tx_ring->tx_buffer_info[req_id]; tx_info->num_of_bufs = 0; + RTE_ASSERT(tx_info->mbuf == NULL); ena_tx_map_mbuf(tx_ring, tx_info, mbuf, &push_header, &header_len);