From patchwork Tue Feb 22 18:11:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 108026 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28A4CA034E; Tue, 22 Feb 2022 19:14:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70354426DB; Tue, 22 Feb 2022 19:12:40 +0100 (CET) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by mails.dpdk.org (Postfix) with ESMTP id 9645841C25 for ; Tue, 22 Feb 2022 19:12:37 +0100 (CET) Received: by mail-ej1-f49.google.com with SMTP id p15so45317616ejc.7 for ; Tue, 22 Feb 2022 10:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vcddAaizyn5sLXx3xZcAF+hqmtWlFvZ5hFLtEZeVVmg=; b=Pi6fag43QBZKjDK8FE54OTzcyGMvua8KAyAEXkkondgWHzurSgZXrNv+s0mNYTiB4F yBeoaBevl77yi3+q9LsLSKjc5OkR3z0P9WIAk1je/ZQ+3335TvFBy0gPsTMA9lgf2fNV O5rYzTzpKAp/WCf9KUM2t5sFDmWbcVQATSLz7d/o127Ps1HX1CrRorKS3XVyK3xHxJ/7 KwVYphjnBa2AJlQhn3/la/m2tj++1tq7cNRNl90MJ8k7DVCuI73WEr3n4lSSSKGZxoiu hodyk3DN3z0uSVj2bV0l28yf3SurkHzoM7pKQHIWHcAJzxpSmn1T6m1WLbYZblrLt5s/ VtBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vcddAaizyn5sLXx3xZcAF+hqmtWlFvZ5hFLtEZeVVmg=; b=xciaoryR0m8F/SdvxhejBZEwpYK21I+c+bMIDOQj5C4E75s26+xqTaARHsIFyqzEBC Hon2lxcpY45roI9hnhQr6Kuu67fxVox1aJjdcK2u5/ju66+q1bouhmIGvhhqgC8bI95Y xrEIesYctmZ8iD/oP8C/1pmsQga5CZgQgcOVxZkUI28l5if4MdFFut/prM855hnbCiHx 3Ezu0Zo0aHREMO00TcHgtwP5qURGO3uKxybNWPSsTrvKXUELnh4pMWAmLroh1fMYjpDT 4SCNx27A8WIyl64VqieV4cDxi5WEXx5O0l6OSzNTQubn79TEDbSLWKelV7q4EbNoK5H+ su7Q== X-Gm-Message-State: AOAM533nnXpZ1VKgk+aF8mryD+cW3ZAQ1cqa+mrpgEUeB0DAvRGrqxv4 gnw5P5ltAwFFgC+JutV7uKuMgdmO3ClN3g== X-Google-Smtp-Source: ABdhPJyGEvDBoIndd2rcpXhwiFhCTyjcmulmG5U6hUKvFlWqAWzMurdt1Cghc9xPFkyN5xyjgvMt5g== X-Received: by 2002:a17:906:b348:b0:6cf:5b66:2f80 with SMTP id cd8-20020a170906b34800b006cf5b662f80mr19619370ejb.638.1645553557102; Tue, 22 Feb 2022 10:12:37 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id y21sm10610153eda.38.2022.02.22.10.12.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 10:12:36 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: shaibran@amazon.com, upstream@semihalf.com, Dawid Gorecki , Michal Krawczyk Subject: [PATCH v2 18/21] net/ena: extend debug prints for invalid req ID resets Date: Tue, 22 Feb 2022 19:11:43 +0100 Message-Id: <20220222181146.28882-19-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222181146.28882-1-mk@semihalf.com> References: <20220222160634.24489-1-mk@semihalf.com> <20220222181146.28882-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dawid Gorecki Add information about port id, queue id and req_id to error logs in validate_tx_req_id. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 02b4144388..f4be79d240 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -675,9 +675,11 @@ static int validate_tx_req_id(struct ena_ring *tx_ring, u16 req_id) } if (tx_info) - PMD_TX_LOG(ERR, "tx_info doesn't have valid mbuf\n"); + PMD_TX_LOG(ERR, "tx_info doesn't have valid mbuf. queue %d:%d req_id %u\n", + tx_ring->port_id, tx_ring->id, req_id); else - PMD_TX_LOG(ERR, "Invalid req_id: %hu\n", req_id); + PMD_TX_LOG(ERR, "Invalid req_id: %hu in queue %d:%d\n", + req_id, tx_ring->port_id, tx_ring->id); /* Trigger device reset */ ++tx_ring->tx_stats.bad_req_id;