From patchwork Tue Feb 22 16:06:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 107983 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94B26A0352; Tue, 22 Feb 2022 17:07:43 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EF6241174; Tue, 22 Feb 2022 17:07:02 +0100 (CET) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by mails.dpdk.org (Postfix) with ESMTP id 0C48641145 for ; Tue, 22 Feb 2022 17:07:01 +0100 (CET) Received: by mail-ed1-f54.google.com with SMTP id u18so38116480edt.6 for ; Tue, 22 Feb 2022 08:07:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=acXqad0cBO68hPVlAp7yRXivrVnQ/a65u/HLvvhrlMk=; b=eGA6zgP/Jq1+ORcLu8RFRdQEGnVqYf+L0fAK4ABYHmgey6rb+X15dOILXpGXUbePNq Kx7McmGpgmqNv6Ub5KZt6ioCyvq5gznBYOJeib1grVV8Vr8WNYVDZ9mTOYRihzGvqzjt EmPMl2O3RcgrXXpNFmFS3QYRwGyctpNnx+EGcOWIfgJkRBQhM/7kaLyFUOKMHXcE5ZrR DTkhpNQ1cnu14e7+VzSqUflb5EbLbYbhOezK6gU8MMHLVO/IRBFl8NPYLM0aDbEE2qhK lsAV+agi0S9Kg0SSq9cv7yz1QHaOzgSqNe8OkdpO8PfncKLcNAgGmCzxORot8yCsinTY br8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=acXqad0cBO68hPVlAp7yRXivrVnQ/a65u/HLvvhrlMk=; b=7pf5pQMXhSWwbHoB5qVz6P4GMLQ8WrtgaUdMaPlZjDbEV2Jku1BvY4dybuI7uY6ZcU /JuASi7lU8kEAdFZ7JyaLXwjE8y2B4MmsQiqky+CugLMzbELAVn/B8+JIAn/eb8Nh6LO Vk9N93V4ELqXStOwJlyAWq2udBzo0XaBgqaawrZ5qySABUi9zcBlVInMq7KTa7I7cXU2 ynnWbr6uTUb6PS75W60NRnh+k66eUljMxrd5AuVY7iIdvjSyFKdsH/Psp6cCaNAs9gHV VXHLtiwSSJP7Lwrt72hE6sLeQFQTU8xSIcDd+1H6Oq2A1sIakniZMMn5LuPW0pv+u3Ve 4tgQ== X-Gm-Message-State: AOAM532VlGmaA2ik99WjakV9ZffxAx7bmmth9/W0Qr35L5Wp5CrKf9kM MDscmw2nIKX9C2gAqkLl4TR6t5LHLk61Bw== X-Google-Smtp-Source: ABdhPJwl0/9Tbf9J9lmUfS3roJfUD91Y69bsRQwqiBQs3QPes2OsYn3/w+BVwR1casN+aNJrHlJACw== X-Received: by 2002:a05:6402:3583:b0:410:a99b:59ee with SMTP id y3-20020a056402358300b00410a99b59eemr27430560edc.454.1645546019969; Tue, 22 Feb 2022 08:06:59 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id x6sm10013477edv.109.2022.02.22.08.06.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 08:06:59 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: shaibran@amazon.com, upstream@semihalf.com, Michal Krawczyk , stable@dpdk.org Subject: [PATCH 07/21] net/ena: skip timer if the reset is triggered Date: Tue, 22 Feb 2022 17:06:20 +0100 Message-Id: <20220222160634.24489-8-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222160634.24489-1-mk@semihalf.com> References: <20220222160634.24489-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Some user applications may not support PMD reset handling. If they will support timer service it could cause a situation, when information about the reset trigger is being showed every time the timer service is being called. Timer service is now being skipped if the reset was already triggered. Fixes: d9b8b106bf9d ("net/ena: add watchdog and keep alive AENQ handler") Cc: stable@dpdk.org Signed-off-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index a2793f13cd..4b82372155 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -1624,6 +1624,9 @@ static void ena_timer_wd_callback(__rte_unused struct rte_timer *timer, struct rte_eth_dev *dev = arg; struct ena_adapter *adapter = dev->data->dev_private; + if (unlikely(adapter->trigger_reset)) + return; + check_for_missing_keep_alive(adapter); check_for_admin_com_state(adapter); check_for_tx_completions(adapter);