From patchwork Tue Feb 22 16:06:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 107980 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 40C05A0352; Tue, 22 Feb 2022 17:07:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2819B41154; Tue, 22 Feb 2022 17:06:59 +0100 (CET) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mails.dpdk.org (Postfix) with ESMTP id 5720C41148 for ; Tue, 22 Feb 2022 17:06:56 +0100 (CET) Received: by mail-ed1-f41.google.com with SMTP id z22so38070307edd.1 for ; Tue, 22 Feb 2022 08:06:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=essxYOnKPPe+crKy13EzyluvIY0P3kBRk7ehFkEAhZ4=; b=hOQHz1kwLPn7GPUXZTFys1RXUIwSP1XDQjX7Pt96KHtRJTCk0RV/3cCMPmUIieu6Te z6h3M3KwSLO/LO8mQqIRQi1lZGYYoiv2ZrniEwF4tL04l7HSMLKvmCb5CFQYuOxhbjhR H3vIr/rrBYkBYnYq7J6diXCa570rf3iMg0KsyWn/NFFBUm7mx5rkzQnbLS5l1sSZBk/+ IoBM1+d5JrJVaqLTpFoCF4l84TPosrQ1+dqqE8wVDb3yIMEgJob9+Jagz5bbYileclef X1J9Wi7vFTLo60hxXu3rBrk3kJQUfrytXgIeWc+EzbpmZtLm+QE7xIYGdg3Zyb/PaItW p7Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=essxYOnKPPe+crKy13EzyluvIY0P3kBRk7ehFkEAhZ4=; b=Lk3FpCzdnWzt9qJ8D1qmL+L6sp/MQeTm3usJyCKGTFgS0EGH3cr0zdtBwOaRSvQAvU aTG2lYOqm6RRDkfbpFbvYiUunyqZ1yL8rxTykeGhnNq8YahqbWMntokDQIVInshOV317 LHIuNOSMtu7N8cB++lRBqgOWnWhPEZeyE5TpfSfdpBOqiHChE/SiJkcEBh6R3zoNuIFu FxwTtTdOg7WvpMqXnB6lldyA4Wm2+SnEk2/IhNTAxI3KQRrTLocdN4t2Bqv/rkvyhDtj CdBInZiCmthyDOf1Rg+N7X63mcXbylvVhKovzZ3tFW0iTrHHYWO1hjsla/YSVTIpIbmL B6KA== X-Gm-Message-State: AOAM532JcBnZjAsin/qWWu8zCIStBSbUsLiW2H7ZlshRS8O6otalLMZq CIgo58sEdnBpGgjUGFioBC4fByqfHs3Png== X-Google-Smtp-Source: ABdhPJyzgpSC45nET7TPGC2XG4GRTO9OZY8B+22FZNI5fy1gibVeYbBlBV1lkRRP9xJ3lYJWwH9T1w== X-Received: by 2002:a50:fc09:0:b0:40f:e199:b266 with SMTP id i9-20020a50fc09000000b0040fe199b266mr26576854edr.350.1645546015742; Tue, 22 Feb 2022 08:06:55 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id x6sm10013477edv.109.2022.02.22.08.06.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 08:06:55 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: shaibran@amazon.com, upstream@semihalf.com, Michal Krawczyk , Artur Rojek , Dawid Gorecki , Igor Chauskin Subject: [PATCH 04/21] net/ena: remove unused offloads variables Date: Tue, 22 Feb 2022 17:06:17 +0100 Message-Id: <20220222160634.24489-5-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222160634.24489-1-mk@semihalf.com> References: <20220222160634.24489-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Those variables are being set, but never read. As they seem to be leftover from the old offloads API and don't have any purpose right now, they are simply being removed. Signed-off-by: Michal Krawczyk Reviewed-by: Artur Rojek Reviewed-by: Dawid Gorecki Reviewed-by: Igor Chauskin Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 3 --- drivers/net/ena/ena_ethdev.h | 5 ----- 2 files changed, 8 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 2de2dcf12f..de5fdb8f1d 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2015,9 +2015,6 @@ static int ena_dev_configure(struct rte_eth_dev *dev) */ adapter->tx_cleanup_stall_delay = adapter->missing_tx_completion_to / 2; - adapter->tx_selected_offloads = dev->data->dev_conf.txmode.offloads; - adapter->rx_selected_offloads = dev->data->dev_conf.rxmode.offloads; - return 0; } diff --git a/drivers/net/ena/ena_ethdev.h b/drivers/net/ena/ena_ethdev.h index f47ba3fb02..4dfa604d51 100644 --- a/drivers/net/ena/ena_ethdev.h +++ b/drivers/net/ena/ena_ethdev.h @@ -278,11 +278,6 @@ struct ena_adapter { struct ena_driver_stats *drv_stats; enum ena_adapter_state state; - uint64_t tx_supported_offloads; - uint64_t tx_selected_offloads; - uint64_t rx_supported_offloads; - uint64_t rx_selected_offloads; - bool link_status; enum ena_regs_reset_reason_types reset_reason;