From patchwork Tue Feb 22 16:06:15 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 107978 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC6E1A0352; Tue, 22 Feb 2022 17:07:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 595D94114E; Tue, 22 Feb 2022 17:06:56 +0100 (CET) Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) by mails.dpdk.org (Postfix) with ESMTP id 8538041144 for ; Tue, 22 Feb 2022 17:06:53 +0100 (CET) Received: by mail-ed1-f41.google.com with SMTP id s14so20717238edw.0 for ; Tue, 22 Feb 2022 08:06:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=7KiXXJkZFs2qCSF+Mclhm1PBHziNSclPNxIDnRkxyaY=; b=37CN8PI2wln9l+Ej6bC27GHN6/adnwzjRqC4e3MTuOPo0s2SbwYf7EGB7FiPfMn3/6 3Dgb3XqrgU76zQGK8KSpr28KyAI6gy+u7tbLTrlfX7T572wdSRJesR+U/iIbi/fYgWwO STJBvjFfa+K9O7WFXl8THozSEmNBNSLCqNMbDRZ+uL/tMPexTukL8hTHLRvY6UoIh9p2 Qsq1gNKJ0l96fUqlT2uNUbDWEAQsV9XcxbQcZBRSLQfLcRZW2+RZT7No0kwUlcnRoWaz 59/coZunLLwNiOe6a9U2dKUhvxFI4Sld6/mM1U/zEtA/fDZdKOvTfVks04CsZHPFZTkg mSSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7KiXXJkZFs2qCSF+Mclhm1PBHziNSclPNxIDnRkxyaY=; b=tUfuJo49YtfcGmi0VJJCKaFZc/L2FalKWQ+bNBNPcSW+6e+BPRnNBq5FFNArGWLFF4 NzF3Gal6bU/36tlBUHbOqPMzWUKAb57837nvBGKuwzhTK6jfajDzeYFYCyS+TxdeqHJZ bbZhcIyIXpy21QjcqvqTHZFnGDr5iIiVtdNpmXFSeHnWe+V5zWVXc7qf/CuwGJ2Hdn5o C7YkdWWg+pGyAaYqjyX124PeCr6ozuEjlo6PoqNSfZb64u2Wt+KIdS0nnKvBdkgK8mxE +7S0b8VAvT1r+0y8cAfqAFA47W0cN2Bo3ASY0QbcFor4W5stTqfmSod4z7ZOg5H8GLkK BJVA== X-Gm-Message-State: AOAM532lZikwsV/rcISFfSlN6qlAP7Z9AJRvh88qDGbJYA1Wrriw3IyJ Y8jKkpUqepQb0z7QXzSHGJU/HdgWPp87PA== X-Google-Smtp-Source: ABdhPJzwqdFe1WKNZSYsD7eUqO5yCVHeT6m/FAvgzd8dN1YM8IxQpor/cRoA7MtElS/jyQgzVSgbbQ== X-Received: by 2002:aa7:d1d7:0:b0:410:d6cf:82b2 with SMTP id g23-20020aa7d1d7000000b00410d6cf82b2mr26423464edp.193.1645546012916; Tue, 22 Feb 2022 08:06:52 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id x6sm10013477edv.109.2022.02.22.08.06.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 08:06:52 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: shaibran@amazon.com, upstream@semihalf.com, Michal Krawczyk , Dawid Gorecki Subject: [PATCH 02/21] net/ena: add assertion on Tx info mbuf Date: Tue, 22 Feb 2022 17:06:15 +0100 Message-Id: <20220222160634.24489-3-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222160634.24489-1-mk@semihalf.com> References: <20220222160634.24489-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org To make sure there is no outstanding mbuf in the reused Tx queue (due to unproper cleanup, or some invalid logic on Tx path), the assertion was added on the Tx path. As it's being compiled out in the release version, it won't affect the IO path performance. Signed-off-by: Michal Krawczyk Reviewed-by: Dawid Gorecki Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index deaee30664..34fb43cb00 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -2661,6 +2661,7 @@ static int ena_xmit_mbuf(struct ena_ring *tx_ring, struct rte_mbuf *mbuf) req_id = tx_ring->empty_tx_reqs[next_to_use]; tx_info = &tx_ring->tx_buffer_info[req_id]; tx_info->num_of_bufs = 0; + RTE_ASSERT(tx_info->mbuf == NULL); ena_tx_map_mbuf(tx_ring, tx_info, mbuf, &push_header, &header_len);