From patchwork Tue Feb 22 16:06:31 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 107994 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C52CDA0352; Tue, 22 Feb 2022 17:09:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31C0A426DB; Tue, 22 Feb 2022 17:07:21 +0100 (CET) Received: from mail-ed1-f53.google.com (mail-ed1-f53.google.com [209.85.208.53]) by mails.dpdk.org (Postfix) with ESMTP id 73F9641C27 for ; Tue, 22 Feb 2022 17:07:15 +0100 (CET) Received: by mail-ed1-f53.google.com with SMTP id cm8so28496542edb.3 for ; Tue, 22 Feb 2022 08:07:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vcddAaizyn5sLXx3xZcAF+hqmtWlFvZ5hFLtEZeVVmg=; b=ci5We/P2zKUqihn+tYH0vl2Mk2+SduSmwuH/6Ek+Jo4m1iHwZME0Ru5fjgq8omqlcc SQklHEaQp5cbse1AUJorjDHOS1aQ/pO51ZkoGy1fRavHzjaWSs/FLG5Qb4FSJqYjxpoi XFZyNC4QXeTCsLoEIk1gNUomgI62f+EJ9e5Tr0rMSSnzIj4qT0//7eqJTrwsyrC2TK4B uhDuGNmNOZcfHg4+6YEBlCzGsAxrGljEPSP9Vg/m4dckuWBPeew+i/bHBtGaYX39hnNT YdWygqHfoSt0El4xr2xqyhS4Jz+TqFMij4IlMsOSViN5W+IDLASi2XE5iLB65z7oSf7n EPAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vcddAaizyn5sLXx3xZcAF+hqmtWlFvZ5hFLtEZeVVmg=; b=ALCXMDfH5mqEB6TqZLn6TFCnTpe6KJnkLQd8xRzW/1G0RgcIjzxExgP8aJ86nYTAtP PuW2Rzc7tKh2hhhnslbWuxOg7hGuTzcp83i66Kzk+LC0niOwfhaEOIhvXOGgtSi5YKQP +nGoYYaGM8QO+UjNsskDjQXw80Vjd/QiUOfHh8GrrKgwX1DNPIXIbwPIaHlQ2EsP8ROG Kof5CTWPipnUWUam8qtb4NXXX3gFuoGrLIaQFeZSpFB5T1/x+Gb3K86OKK0gV8T1FrID EDwYBPHGXxxlh+Fv0v2lRRTU/LzYXCv10QmEZFbmm67k6oFMV4WTgrV6/u5JTneJlNLI mEgQ== X-Gm-Message-State: AOAM531372rxE4VG7VL3VOogoSbzCIxi5vdqcNNfNDg9Q/KR1S2kmmaO LNLKDchzkQYJ/dgLrzE6Kkbj+cWHW9sStg== X-Google-Smtp-Source: ABdhPJxLp4jt60uRH/lICWoBcGg33sNjLq8WvhiHfOYl6GUDjJsm4pBwEp6RzZCgQ5PNAcC7ZI4tGA== X-Received: by 2002:aa7:c391:0:b0:410:83fb:abab with SMTP id k17-20020aa7c391000000b0041083fbababmr27349858edq.435.1645546034941; Tue, 22 Feb 2022 08:07:14 -0800 (PST) Received: from DESKTOP-U5LNN3J.localdomain (89-79-181-52.dynamic.chello.pl. [89.79.181.52]) by smtp.gmail.com with ESMTPSA id x6sm10013477edv.109.2022.02.22.08.07.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 08:07:14 -0800 (PST) From: Michal Krawczyk To: dev@dpdk.org Cc: shaibran@amazon.com, upstream@semihalf.com, Dawid Gorecki , Michal Krawczyk Subject: [PATCH 18/21] net/ena: extend debug prints for invalid req ID resets Date: Tue, 22 Feb 2022 17:06:31 +0100 Message-Id: <20220222160634.24489-19-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222160634.24489-1-mk@semihalf.com> References: <20220222160634.24489-1-mk@semihalf.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Dawid Gorecki Add information about port id, queue id and req_id to error logs in validate_tx_req_id. Signed-off-by: Dawid Gorecki Reviewed-by: Michal Krawczyk Reviewed-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 02b4144388..f4be79d240 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -675,9 +675,11 @@ static int validate_tx_req_id(struct ena_ring *tx_ring, u16 req_id) } if (tx_info) - PMD_TX_LOG(ERR, "tx_info doesn't have valid mbuf\n"); + PMD_TX_LOG(ERR, "tx_info doesn't have valid mbuf. queue %d:%d req_id %u\n", + tx_ring->port_id, tx_ring->id, req_id); else - PMD_TX_LOG(ERR, "Invalid req_id: %hu\n", req_id); + PMD_TX_LOG(ERR, "Invalid req_id: %hu in queue %d:%d\n", + req_id, tx_ring->port_id, tx_ring->id); /* Trigger device reset */ ++tx_ring->tx_stats.bad_req_id;