diff mbox series

add missing file to meson build for installation

Message ID 20220131224821.94408-1-gladdyu@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series add missing file to meson build for installation |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-compile-testing fail Testing issues
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Martijn Bakker Jan. 31, 2022, 10:48 p.m. UTC 
  Signed-off-by: Martijn Bakker <gladdyu@gmail.com>
---
 lib/eal/include/meson.build | 1 +
 1 file changed, 1 insertion(+)

Comments

Bruce Richardson Feb. 1, 2022, 9:26 a.m. UTC | #1 
On Mon, Jan 31, 2022 at 10:48:21PM +0000, Martijn Bakker wrote:
> Signed-off-by: Martijn Bakker <gladdyu@gmail.com>
> ---

+ Cc: stable@dpdk.org

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Originally buggy commit is hard to determine, but I believe the fixline
should be:

Fixes: 610beca42ea4 ("build: remove library special cases")


>  lib/eal/include/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build
> index 86468d1a2b..9700494816 100644
> --- a/lib/eal/include/meson.build
> +++ b/lib/eal/include/meson.build
> @@ -60,6 +60,7 @@ generic_headers = files(
>          'generic/rte_mcslock.h',
>          'generic/rte_memcpy.h',
>          'generic/rte_pause.h',
> +        'generic/rte_pflock.h',
>          'generic/rte_power_intrinsics.h',
>          'generic/rte_prefetch.h',
>          'generic/rte_rwlock.h',
> -- 
> 2.25.1
>
Thomas Monjalon Feb. 2, 2022, 1:33 p.m. UTC | #2 
01/02/2022 10:26, Bruce Richardson:
> On Mon, Jan 31, 2022 at 10:48:21PM +0000, Martijn Bakker wrote:
> > Signed-off-by: Martijn Bakker <gladdyu@gmail.com>
> > ---
> 
> + Cc: stable@dpdk.org
> 
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> 
> Originally buggy commit is hard to determine, but I believe the fixline
> should be:
> 
> Fixes: 610beca42ea4 ("build: remove library special cases")

The original issue is simpler, it has been forgotten when creating rte_pflock:
Fixes: 9667d97c2507 ("pflock: add phase-fair reader writer locks")

Applied, thanks
diff mbox series

Patch

diff --git a/lib/eal/include/meson.build b/lib/eal/include/meson.build
index 86468d1a2b..9700494816 100644
--- a/lib/eal/include/meson.build
+++ b/lib/eal/include/meson.build
@@ -60,6 +60,7 @@  generic_headers = files(
         'generic/rte_mcslock.h',
         'generic/rte_memcpy.h',
         'generic/rte_pause.h',
+        'generic/rte_pflock.h',
         'generic/rte_power_intrinsics.h',
         'generic/rte_prefetch.h',
         'generic/rte_rwlock.h',