diff mbox series

[1/2] net/nfp: remove duplicated check when setting MAC address

Message ID 20220105103203.7166-1-maxime.gouin@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [1/2] net/nfp: remove duplicated check when setting MAC address |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Maxime Gouin Jan. 5, 2022, 10:32 a.m. UTC 
  reported by code analysis tool C++test (version 10.4):

> /build/dpdk-20.11/drivers/net/nfp/nfp_net.c
> 546   Conditions "(hw->ctrl &NFP_NET_CFG_CTRL_ENABLE) &&
        !! (hw->cap &NFP_NET_CFG_C" is always evaluated to false
> 547   Condition "! (hw->cap &NFP_NET_CFG_C" is always evaluated to false

The previous "if" checks exactly the same condition. Removal of duplicate
code.

Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change")

Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
---
 drivers/net/nfp/nfp_common.c | 4 ----
 1 file changed, 4 deletions(-)

Comments

Kevin Traynor Jan. 11, 2022, 2:46 p.m. UTC | #1 
On 05/01/2022 10:32, Maxime Gouin wrote:
> reported by code analysis tool C++test (version 10.4):
> 
>> /build/dpdk-20.11/drivers/net/nfp/nfp_net.c
>> 546   Conditions "(hw->ctrl &NFP_NET_CFG_CTRL_ENABLE) &&
>          !! (hw->cap &NFP_NET_CFG_C" is always evaluated to false
>> 547   Condition "! (hw->cap &NFP_NET_CFG_C" is always evaluated to false
> 
> The previous "if" checks exactly the same condition. Removal of duplicate
> code.
> 
> Fixes: 2fe669f4bcd2 ("net/nfp: support MAC address change")
> 

Cc: stable@dpdk.org

> Signed-off-by: Maxime Gouin <maxime.gouin@6wind.com>
> Reviewed-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: Kevin Traynor <ktraynor@redhat.com>

> ---
>   drivers/net/nfp/nfp_common.c | 4 ----
>   1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c
> index f8978e803a0f..b26770dbfbe4 100644
> --- a/drivers/net/nfp/nfp_common.c
> +++ b/drivers/net/nfp/nfp_common.c
> @@ -280,10 +280,6 @@ nfp_set_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)
>   		return -EBUSY;
>   	}
>   
> -	if ((hw->ctrl & NFP_NET_CFG_CTRL_ENABLE) &&
> -	    !(hw->cap & NFP_NET_CFG_CTRL_LIVE_ADDR))
> -		return -EBUSY;
> -
>   	/* Writing new MAC to the specific port BAR address */
>   	nfp_net_write_mac(hw, (uint8_t *)mac_addr);
>   
>
diff mbox series

Patch

diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c
index f8978e803a0f..b26770dbfbe4 100644
--- a/drivers/net/nfp/nfp_common.c
+++ b/drivers/net/nfp/nfp_common.c
@@ -280,10 +280,6 @@  nfp_set_mac_addr(struct rte_eth_dev *dev, struct rte_ether_addr *mac_addr)
 		return -EBUSY;
 	}
 
-	if ((hw->ctrl & NFP_NET_CFG_CTRL_ENABLE) &&
-	    !(hw->cap & NFP_NET_CFG_CTRL_LIVE_ADDR))
-		return -EBUSY;
-
 	/* Writing new MAC to the specific port BAR address */
 	nfp_net_write_mac(hw, (uint8_t *)mac_addr);