[RFC,v1,2/4] ethdev: add API for direct re-arm mode
Checks
Commit Message
Add API for enabling direct re-arm mode and for mapping RX and TX
queues. Currently, the API supports 1:1(txq : rxq) mapping.
Suggested-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
lib/ethdev/ethdev_driver.h | 15 +++++++++++++++
lib/ethdev/rte_ethdev.c | 14 ++++++++++++++
lib/ethdev/rte_ethdev.h | 31 +++++++++++++++++++++++++++++++
lib/ethdev/version.map | 3 +++
4 files changed, 63 insertions(+)
Comments
On Sat, 25 Dec 2021 00:46:10 +0800
Feifei Wang <feifei.wang2@arm.com> wrote:
> +rte_eth_direct_rxrearm_map(uint16_t rx_port_id, uint16_t rx_queue_id,
> + uint16_t tx_port_id, uint16_t tx_queue_id)
> +{
> + struct rte_eth_dev *dev;
> +
> + dev = &rte_eth_devices[rx_port_id];
> + (*dev->dev_ops->rx_queue_direct_rearm_enable)(dev, rx_queue_id);
> + (*dev->dev_ops->rx_queue_direct_rearm_map)(dev, rx_queue_id,
> + tx_port_id, tx_queue_id);
> +
Indirect calls are expensive, maybe better to combine these?
> -----邮件原件-----
> 发件人: Stephen Hemminger <stephen@networkplumber.org>
> 发送时间: Saturday, December 25, 2021 3:38 AM
> 收件人: Feifei Wang <Feifei.Wang2@arm.com>
> 抄送: thomas@monjalon.net; Ferruh Yigit <ferruh.yigit@intel.com>; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Ray Kinsella
> <mdr@ashroe.eu>; dev@dpdk.org; nd <nd@arm.com>; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> <Ruifeng.Wang@arm.com>
> 主题: Re: [RFC PATCH v1 2/4] ethdev: add API for direct re-arm mode
>
> On Sat, 25 Dec 2021 00:46:10 +0800
> Feifei Wang <feifei.wang2@arm.com> wrote:
>
> > +rte_eth_direct_rxrearm_map(uint16_t rx_port_id, uint16_t rx_queue_id,
> > + uint16_t tx_port_id, uint16_t tx_queue_id) {
> > + struct rte_eth_dev *dev;
> > +
> > + dev = &rte_eth_devices[rx_port_id];
> > + (*dev->dev_ops->rx_queue_direct_rearm_enable)(dev,
> rx_queue_id);
> > + (*dev->dev_ops->rx_queue_direct_rearm_map)(dev, rx_queue_id,
> > + tx_port_id, tx_queue_id);
> > +
>
> Indirect calls are expensive, maybe better to combine these?
Thanks for your comment. I'm a little confused about this.
Whether 'expensive' is due to 'enable direct_rearm mode' and 'map queue' use
different api, and we should combine them into the same API.
If this, I think you are right, and just one api is enough to enable direct rearm mode and
map queue.
> From: Feifei Wang [mailto:Feifei.Wang2@arm.com]
> Sent: Sunday, 26 December 2021 10.50
>
> > 发件人: Stephen Hemminger <stephen@networkplumber.org>
> > 发送时间: Saturday, December 25, 2021 3:38 AM
> >
> > On Sat, 25 Dec 2021 00:46:10 +0800
> > Feifei Wang <feifei.wang2@arm.com> wrote:
> >
> > > +rte_eth_direct_rxrearm_map(uint16_t rx_port_id, uint16_t
> rx_queue_id,
> > > + uint16_t tx_port_id, uint16_t tx_queue_id) {
> > > + struct rte_eth_dev *dev;
> > > +
> > > + dev = &rte_eth_devices[rx_port_id];
> > > + (*dev->dev_ops->rx_queue_direct_rearm_enable)(dev,
> > rx_queue_id);
> > > + (*dev->dev_ops->rx_queue_direct_rearm_map)(dev, rx_queue_id,
> > > + tx_port_id, tx_queue_id);
> > > +
> >
> > Indirect calls are expensive, maybe better to combine these?
> Thanks for your comment. I'm a little confused about this.
>
> Whether 'expensive' is due to 'enable direct_rearm mode' and 'map
> queue' use
> different api, and we should combine them into the same API.
> If this, I think you are right, and just one api is enough to enable
> direct rearm mode and
> map queue.
>
It's used in the control plane, so prefer readability over performance.
Also, the Ethdev API has separate _enable/_disable/_configure functions for many features like this. I would prefer the API to this feature to be similar, i.e. separate functions for enable and configure.
In other words: Disregard Stephen's comment about combining.
@@ -476,6 +476,16 @@ typedef int (*eth_rx_enable_intr_t)(struct rte_eth_dev *dev,
typedef int (*eth_rx_disable_intr_t)(struct rte_eth_dev *dev,
uint16_t rx_queue_id);
+/** @internal Enable direct rearm of a receive queue of an Ethernet device. */
+typedef int (*eth_rx_direct_rearm_enable_t)(struct rte_eth_dev *dev,
+ uint16_t queue_id);
+
+/**< @internal map Rx/Tx queue of direct rearm mode */
+typedef int (*eth_rx_direct_rearm_map_t)(struct rte_eth_dev *dev,
+ uint16_t rx_queue_id,
+ uint16_t tx_port_id,
+ uint16_t tx_queue_id);
+
/** @internal Release memory resources allocated by given Rx/Tx queue. */
typedef void (*eth_queue_release_t)(struct rte_eth_dev *dev,
uint16_t queue_id);
@@ -1069,6 +1079,11 @@ struct eth_dev_ops {
/** Disable Rx queue interrupt */
eth_rx_disable_intr_t rx_queue_intr_disable;
+ /** Enable Rx queue direct rearm mode */
+ eth_rx_direct_rearm_enable_t rx_queue_direct_rearm_enable;
+ /** Map Rx/Tx queue for direct rearm mode */
+ eth_rx_direct_rearm_map_t rx_queue_direct_rearm_map;
+
eth_tx_queue_setup_t tx_queue_setup;/**< Set up device Tx queue */
eth_queue_release_t tx_queue_release; /**< Release Tx queue */
eth_tx_done_cleanup_t tx_done_cleanup;/**< Free Tx ring mbufs */
@@ -2485,6 +2485,20 @@ rte_eth_tx_hairpin_queue_setup(uint16_t port_id, uint16_t tx_queue_id,
return eth_err(port_id, ret);
}
+int
+rte_eth_direct_rxrearm_map(uint16_t rx_port_id, uint16_t rx_queue_id,
+ uint16_t tx_port_id, uint16_t tx_queue_id)
+{
+ struct rte_eth_dev *dev;
+
+ dev = &rte_eth_devices[rx_port_id];
+ (*dev->dev_ops->rx_queue_direct_rearm_enable)(dev, rx_queue_id);
+ (*dev->dev_ops->rx_queue_direct_rearm_map)(dev, rx_queue_id,
+ tx_port_id, tx_queue_id);
+
+ return 0;
+}
+
int
rte_eth_hairpin_bind(uint16_t tx_port, uint16_t rx_port)
{
@@ -5073,6 +5073,37 @@ __rte_experimental
int rte_eth_dev_hairpin_capability_get(uint16_t port_id,
struct rte_eth_hairpin_cap *cap);
+/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
+ *
+ * Enable direct re-arm mode. In this mode the RX queue will be re-armed using
+ * buffers that have completed transmission on the transmit side.
+ *
+ * @note
+ * It is assumed that the buffers have completed transmission belong to the
+ * mempool used at the receive side, and have refcnt = 1.
+ *
+ * @param rx_port_id
+ * Port identifying the receive side.
+ * @param rx_queue_id
+ * The index of the receive queue identifying the receive side.
+ * The value must be in the range [0, nb_rx_queue - 1] previously supplied
+ * to rte_eth_dev_configure().
+ * @param tx_port_id
+ * Port identifying the transmit side.
+ * @param tx_queue_id
+ * The index of the transmit queue identifying the transmit side.
+ * The value must be in the range [0, nb_tx_queue - 1] previously supplied
+ * to rte_eth_dev_configure().
+ *
+ * @return
+ * - (0) if successful.
+ */
+__rte_experimental
+int rte_eth_direct_rxrearm_map(uint16_t rx_port_id, uint16_t rx_queue_id,
+ uint16_t tx_port_id, uint16_t tx_queue_id);
+
/**
* @warning
* @b EXPERIMENTAL: this structure may change without prior notice.
@@ -256,6 +256,9 @@ EXPERIMENTAL {
rte_flow_flex_item_create;
rte_flow_flex_item_release;
rte_flow_pick_transfer_proxy;
+
+ # added in 22.02
+ rte_eth_direct_rxrearm_map;
};
INTERNAL {