diff mbox series

[v2] app/test-fib: fix possible division by zero

Message ID 20211223153742.760838-1-vladimir.medvedkin@intel.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series [v2] app/test-fib: fix possible division by zero |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-aarch64-unit-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Vladimir Medvedkin Dec. 23, 2021, 3:37 p.m. UTC 
  This patch fixes the division by 0, which occurs if
the number of routes is less than 10.
Can be triggered by passing -n argument with value < 10:

./dpdk-test-fib -- -n 9
...
Floating point exception (core dumped)

Fixes: 103809d032cd ("app/test-fib: add test application for FIB")
Cc: stable@dpdk.org

Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
---
 app/test-fib/main.c | 40 ++++++++++++++++++++++++----------------
 1 file changed, 24 insertions(+), 16 deletions(-)
diff mbox series

Patch

diff --git a/app/test-fib/main.c b/app/test-fib/main.c
index ecd420116a..9bc8b8a7ca 100644
--- a/app/test-fib/main.c
+++ b/app/test-fib/main.c
@@ -902,8 +902,9 @@  run_v4(void)
 				return -ret;
 			}
 		}
-		printf("AVG FIB add %"PRIu64"\n",
-			(rte_rdtsc_precise() - start) / j);
+		if (j != 0)
+			printf("AVG FIB add %"PRIu64"\n",
+				(rte_rdtsc_precise() - start) / j);
 		i += j;
 	}
 
@@ -930,8 +931,9 @@  run_v4(void)
 					return -ret;
 				}
 			}
-			printf("AVG LPM add %"PRIu64"\n",
-				(rte_rdtsc_precise() - start) / j);
+			if (j != 0)
+				printf("AVG LPM add %"PRIu64"\n",
+					(rte_rdtsc_precise() - start) / j);
 			i += j;
 		}
 	}
@@ -984,8 +986,9 @@  run_v4(void)
 		for (j = 0; j < (config.nb_routes - i) / k; j++)
 			rte_fib_delete(fib, rt[i + j].addr, rt[i + j].depth);
 
-		printf("AVG FIB delete %"PRIu64"\n",
-			(rte_rdtsc_precise() - start) / j);
+		if (j != 0)
+			printf("AVG FIB delete %"PRIu64"\n",
+				(rte_rdtsc_precise() - start) / j);
 		i += j;
 	}
 
@@ -996,8 +999,9 @@  run_v4(void)
 				rte_lpm_delete(lpm, rt[i + j].addr,
 					rt[i + j].depth);
 
-			printf("AVG LPM delete %"PRIu64"\n",
-				(rte_rdtsc_precise() - start) / j);
+			if (j != 0)
+				printf("AVG LPM delete %"PRIu64"\n",
+					(rte_rdtsc_precise() - start) / j);
 			i += j;
 		}
 	}
@@ -1097,8 +1101,9 @@  run_v6(void)
 				return -ret;
 			}
 		}
-		printf("AVG FIB add %"PRIu64"\n",
-			(rte_rdtsc_precise() - start) / j);
+		if (j != 0)
+			printf("AVG FIB add %"PRIu64"\n",
+				(rte_rdtsc_precise() - start) / j);
 		i += j;
 	}
 
@@ -1125,8 +1130,9 @@  run_v6(void)
 					return -ret;
 				}
 			}
-			printf("AVG LPM add %"PRIu64"\n",
-				(rte_rdtsc_precise() - start) / j);
+			if (j != 0)
+				printf("AVG LPM add %"PRIu64"\n",
+					(rte_rdtsc_precise() - start) / j);
 			i += j;
 		}
 	}
@@ -1183,8 +1189,9 @@  run_v6(void)
 		for (j = 0; j < (config.nb_routes - i) / k; j++)
 			rte_fib6_delete(fib, rt[i + j].addr, rt[i + j].depth);
 
-		printf("AVG FIB delete %"PRIu64"\n",
-			(rte_rdtsc_precise() - start) / j);
+		if (j != 0)
+			printf("AVG FIB delete %"PRIu64"\n",
+				(rte_rdtsc_precise() - start) / j);
 		i += j;
 	}
 
@@ -1195,8 +1202,9 @@  run_v6(void)
 				rte_lpm6_delete(lpm, rt[i + j].addr,
 					rt[i + j].depth);
 
-			printf("AVG LPM delete %"PRIu64"\n",
-				(rte_rdtsc_precise() - start) / j);
+			if (j != 0)
+				printf("AVG LPM delete %"PRIu64"\n",
+					(rte_rdtsc_precise() - start) / j);
 			i += j;
 		}
 	}