diff mbox series

[v1] net/iavf: remove the extra symbol '+'

Message ID 20211216044342.25551-1-haiyue.wang@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series [v1] net/iavf: remove the extra symbol '+' |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Wang, Haiyue Dec. 16, 2021, 4:43 a.m. UTC 
  This extra symbol '+' should be added when patch was reapplied, and the
compiler treats it as unsigned type, so the code still runs well.

Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message")
Cc: stable@dpdk.org

Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
---
 drivers/net/iavf/iavf_vchnl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xing, Beilei Dec. 16, 2021, 5:49 a.m. UTC | #1 
> -----Original Message-----
> From: Wang, Haiyue <haiyue.wang@intel.com>
> Sent: Thursday, December 16, 2021 12:44 PM
> To: dev@dpdk.org
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Sinha, Abhijit
> <abhijit.sinha@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>
> Subject: [PATCH v1] net/iavf: remove the extra symbol '+'
> 
> This extra symbol '+' should be added when patch was reapplied, and the
> compiler treats it as unsigned type, so the code still runs well.
> 
> Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel
> message")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> ---
>  drivers/net/iavf/iavf_vchnl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c index
> 145b059837..8fdd6f6d91 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)
>  		VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
>  		VIRTCHNL_VF_LARGE_NUM_QPAIRS |
>  		VIRTCHNL_VF_OFFLOAD_QOS |
> -+		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> +		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> 
>  	args.in_args = (uint8_t *)&caps;
>  	args.in_args_size = sizeof(caps);
> --
> 2.34.1

Acked-by: Beilei Xing <beilei.xing@intel.com>
Radu Nicolau Dec. 16, 2021, 10:05 a.m. UTC | #2 
On 12/16/2021 4:43 AM, Haiyue Wang wrote:
> This extra symbol '+' should be added when patch was reapplied, and the
> compiler treats it as unsigned type, so the code still runs well.
>
> Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel message")
> Cc:stable@dpdk.org
>
> Signed-off-by: Haiyue Wang<haiyue.wang@intel.com>
> ---
>   drivers/net/iavf/iavf_vchnl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
> index 145b059837..8fdd6f6d91 100644
> --- a/drivers/net/iavf/iavf_vchnl.c
> +++ b/drivers/net/iavf/iavf_vchnl.c
> @@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)
>   		VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
>   		VIRTCHNL_VF_LARGE_NUM_QPAIRS |
>   		VIRTCHNL_VF_OFFLOAD_QOS |
> -+		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> +		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
>   
>   	args.in_args = (uint8_t *)&caps;
>   	args.in_args_size = sizeof(caps);

Acked-by: Radu Nicolau <radu.nicolau@intel.com>
Qi Zhang Jan. 2, 2022, 8:25 a.m. UTC | #3 
> -----Original Message-----
> From: Xing, Beilei <beilei.xing@intel.com>
> Sent: Thursday, December 16, 2021 1:49 PM
> To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org; Wu, Jingjing <jingjing.wu@intel.com>; Sinha, Abhijit
> <abhijit.sinha@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
> Nicolau, Radu <radu.nicolau@intel.com>
> Subject: RE: [PATCH v1] net/iavf: remove the extra symbol '+'
> 
> 
> 
> > -----Original Message-----
> > From: Wang, Haiyue <haiyue.wang@intel.com>
> > Sent: Thursday, December 16, 2021 12:44 PM
> > To: dev@dpdk.org
> > Cc: Wang, Haiyue <haiyue.wang@intel.com>; stable@dpdk.org; Wu,
> > Jingjing <jingjing.wu@intel.com>; Xing, Beilei
> > <beilei.xing@intel.com>; Sinha, Abhijit <abhijit.sinha@intel.com>;
> > Doherty, Declan <declan.doherty@intel.com>; Nicolau, Radu
> > <radu.nicolau@intel.com>
> > Subject: [PATCH v1] net/iavf: remove the extra symbol '+'
> >
> > This extra symbol '+' should be added when patch was reapplied, and
> > the compiler treats it as unsigned type, so the code still runs well.
> >
> > Fixes: 84108425054a ("net/iavf: support asynchronous virtual channel
> > message")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>
> > ---
> >  drivers/net/iavf/iavf_vchnl.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/iavf/iavf_vchnl.c
> > b/drivers/net/iavf/iavf_vchnl.c index
> > 145b059837..8fdd6f6d91 100644
> > --- a/drivers/net/iavf/iavf_vchnl.c
> > +++ b/drivers/net/iavf/iavf_vchnl.c
> > @@ -502,7 +502,7 @@ iavf_get_vf_resource(struct iavf_adapter *adapter)
> >  		VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
> >  		VIRTCHNL_VF_LARGE_NUM_QPAIRS |
> >  		VIRTCHNL_VF_OFFLOAD_QOS |
> > -+		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> > +		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
> >
> >  	args.in_args = (uint8_t *)&caps;
> >  	args.in_args_size = sizeof(caps);
> > --
> > 2.34.1
> 
> Acked-by: Beilei Xing <beilei.xing@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/iavf/iavf_vchnl.c b/drivers/net/iavf/iavf_vchnl.c
index 145b059837..8fdd6f6d91 100644
--- a/drivers/net/iavf/iavf_vchnl.c
+++ b/drivers/net/iavf/iavf_vchnl.c
@@ -502,7 +502,7 @@  iavf_get_vf_resource(struct iavf_adapter *adapter)
 		VIRTCHNL_VF_OFFLOAD_VLAN_V2 |
 		VIRTCHNL_VF_LARGE_NUM_QPAIRS |
 		VIRTCHNL_VF_OFFLOAD_QOS |
-+		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
+		VIRTCHNL_VF_OFFLOAD_INLINE_IPSEC_CRYPTO;
 
 	args.in_args = (uint8_t *)&caps;
 	args.in_args_size = sizeof(caps);