[v2] compress/mlx5: fix double close for context device
Checks
Commit Message
From: Michael Baum <michaelba@nvidia.com>
The context of the device opens once in the common probe and closes with
its removal.
If the probe of one of the drivers fails, it releases its resources and
then the common closes the context.
But mistakenly in the compress probe, if there isn't enough capabilities
to support compress operations, it closes the device and then common
probe closes it again.
Remove the redundant closing from compress probe.
Fixes: 2efd26544554 ("compress/mlx5: support partial transformation")
Cc: stable@dpdk.org
Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
v2: Improve commit log according to checkpatch warning.
Add "Acked-by" inside.
drivers/compress/mlx5/mlx5_compress.c | 1 -
1 file changed, 1 deletion(-)
Comments
> From: Michael Baum <michaelba@nvidia.com>
>
> The context of the device opens once in the common probe and closes with
> its removal.
>
> If the probe of one of the drivers fails, it releases its resources and
> then the common closes the context.
> But mistakenly in the compress probe, if there isn't enough capabilities
> to support compress operations, it closes the device and then common
> probe closes it again.
>
> Remove the redundant closing from compress probe.
>
> Fixes: 2efd26544554 ("compress/mlx5: support partial transformation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Michael Baum <michaelba@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Applied to dpdk-next-crypto
Please cc all crypto/compression related patches to me in future.
@@ -723,7 +723,6 @@ mlx5_compress_dev_probe(struct mlx5_common_device *cdev)
&& !attr->mmo_compress_qp_en && !attr->mmo_compress_sq_en
&& !attr->mmo_dma_qp_en && !attr->mmo_dma_sq_en) {
DRV_LOG(ERR, "Not enough capabilities to support compress operations, maybe old FW/OFED version?");
- claim_zero(mlx5_glue->close_device(cdev->ctx));
rte_errno = ENOTSUP;
return -ENOTSUP;
}