diff mbox series

[v2] app/testpmd: fix DCB configuration

Message ID 20211110090842.912936-1-jie1x.wang@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] app/testpmd: fix DCB configuration |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Jie Wang Nov. 10, 2021, 9:08 a.m. UTC 
  When set port DCB mode enabled, it should remove RSS HASH offload
before reconfiguring the device and queues.

Because port multi-queue mode is changed from RSS to DCB.

Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")

Signed-off-by: Jie Wang <jie1x.wang@intel.com>
---
v2:
 * update commit log.
 * remove RSS HASH offload from port->rx_conf[i].offloads.
---
 app/test-pmd/testpmd.c | 3 +++
 1 file changed, 3 insertions(+)

Comments

Singh, Aman Deep Nov. 12, 2021, 9:08 a.m. UTC | #1 
On 11/10/2021 2:38 PM, Jie Wang wrote:
> When set port DCB mode enabled, it should remove RSS HASH offload
> before reconfiguring the device and queues.
>
> Because port multi-queue mode is changed from RSS to DCB.
>
> Fixes: 2a977b891f99 ("app/testpmd: fix DCB configuration")
>
> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
> ---
> v2:
>   * update commit log.
>   * remove RSS HASH offload from port->rx_conf[i].offloads.
> ---
>   app/test-pmd/testpmd.c | 3 +++
>   1 file changed, 3 insertions(+)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
> index a66dfb297c..661be341a0 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -3948,6 +3948,9 @@ init_port_dcb_config(portid_t pid,
>   	if (retval < 0)
>   		return retval;
>   	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
> +	port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
> +	for (i = 0; i < nb_rxq; i++)
> +		rte_port->rx_conf[i].offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;

I think this change will effect DCB_ENABLED case also ( without VT). In 
that case RSS offload is allowed.

Please check with configuration "port config 0 dcb vt off 4 pfc off".

>   
>   	/* re-configure the device . */
>   	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);
diff mbox series

Patch

diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c
index a66dfb297c..661be341a0 100644
--- a/app/test-pmd/testpmd.c
+++ b/app/test-pmd/testpmd.c
@@ -3948,6 +3948,9 @@  init_port_dcb_config(portid_t pid,
 	if (retval < 0)
 		return retval;
 	port_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_VLAN_FILTER;
+	port_conf.rxmode.offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
+	for (i = 0; i < nb_rxq; i++)
+		rte_port->rx_conf[i].offloads &= ~RTE_ETH_RX_OFFLOAD_RSS_HASH;
 
 	/* re-configure the device . */
 	retval = rte_eth_dev_configure(pid, nb_rxq, nb_rxq, &port_conf);