[v1] eal: fix random device arguments in device iterator
Checks
Commit Message
Devargs used in device iterator initialization wasn't set to zero, random
data like bus string lead to invalid address access.
This patch initializes devargs.
Fixes: c99a2d4c6b7f ("eal: implement device iteration initialization")
Cc: stable@dpdk.org
Cc: Gaetan Rivet <grive@u256.net>
Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
lib/eal/common/eal_common_dev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Oct 27, 2021 at 10:23 AM Xueming Li <xuemingl@nvidia.com> wrote:
>
> Devargs used in device iterator initialization wasn't set to zero, random
> data like bus string lead to invalid address access.
>
> This patch initializes devargs.
>
> Fixes: c99a2d4c6b7f ("eal: implement device iteration initialization")
> Cc: stable@dpdk.org
>
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Applied, thanks.
It seems a basic issue, could it be caught with a unit test?
Thanks.
@@ -573,7 +573,7 @@ int
rte_dev_iterator_init(struct rte_dev_iterator *it,
const char *dev_str)
{
- struct rte_devargs devargs;
+ struct rte_devargs devargs = { .bus = NULL };
struct rte_class *cls = NULL;
struct rte_bus *bus = NULL;