diff mbox series

[v5] doc: document a limitation for a meter with RSS action

Message ID 20211026115325.129308-1-lizh@nvidia.com (mailing list archive)
State Superseded, archived
Delegated to: Raslan Darawsheh
Headers
Series [v5] doc: document a limitation for a meter with RSS action |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-spell-check-testing warning Testing issues
ci/github-robot: build success github build: passed
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance fail Performance Testing issues
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS

Commit Message

Li Zhang Oct. 26, 2021, 11:53 a.m. UTC 
  A meter policy with RSS/Queue action is not supported
when ``dv_xmeta_en`` enabled.

When ``dv_xmeta_en`` enabled in legacy creating flow,
it will split into two flows
(one set_tag with jump flow and one RSS/queue action flow).
For meter policy as termination table,
it cannot split flow and
cannot support when ``dv_xmeta_en`` enabled.

Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
Cc: stable@dpdk.org

Signed-off-by: Li Zhang <lizh@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
 doc/guides/nics/mlx5.rst | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon Oct. 26, 2021, 12:28 p.m. UTC | #1 
The title should mention "mlx5 guide" as the scope.

26/10/2021 13:53, Li Zhang:
> A meter policy with RSS/Queue action is not supported
> when ``dv_xmeta_en`` enabled.

The quotes are RST syntax.
Raslan, while merging, you can remove the quotes from the commit log.

> 
> When ``dv_xmeta_en`` enabled in legacy creating flow,
> it will split into two flows
> (one set_tag with jump flow and one RSS/queue action flow).
> For meter policy as termination table,
> it cannot split flow and
> cannot support when ``dv_xmeta_en`` enabled.
> 
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/nics/mlx5.rst | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 47709d93b3..cd28c04c1e 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -435,6 +435,7 @@ Limitations
>       - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
>       - RED: must be DROP.
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
>    - meter profile packet mode is supported.
>    - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
Li Zhang Oct. 27, 2021, 5:41 a.m. UTC | #2 
Thanks!
I will update it into patch v6 according to your comments.
Please take a look.

Regards,
Li Zhang

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Tuesday, October 26, 2021 8:28 PM
To: Li Zhang <lizh@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>
Cc: Ori Kam <orika@nvidia.com>; Slava Ovsiienko <viacheslavo@nvidia.com>; Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>; Shun Hao <shunh@nvidia.com>; dev@dpdk.org; Roni Bar Yanai <roniba@nvidia.com>; stable@dpdk.org
Subject: Re: [PATCH v5] doc: document a limitation for a meter with RSS action

External email: Use caution opening links or attachments


The title should mention "mlx5 guide" as the scope.

26/10/2021 13:53, Li Zhang:
> A meter policy with RSS/Queue action is not supported when 
> ``dv_xmeta_en`` enabled.

The quotes are RST syntax.
Raslan, while merging, you can remove the quotes from the commit log.

>
> When ``dv_xmeta_en`` enabled in legacy creating flow, it will split 
> into two flows (one set_tag with jump flow and one RSS/queue action 
> flow).
> For meter policy as termination table, it cannot split flow and cannot 
> support when ``dv_xmeta_en`` enabled.
>
> Fixes: 51ec04d ("net/mlx5: connect meter policy to created flows")
> Cc: stable@dpdk.org
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
> ---
>  doc/guides/nics/mlx5.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 
> 47709d93b3..cd28c04c1e 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -435,6 +435,7 @@ Limitations
>       - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
>       - RED: must be DROP.
>    - Policy actions of RSS for green and yellow should have the same configuration except queues.
> +  - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
>    - meter profile packet mode is supported.
>    - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.
diff mbox series

Patch

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 47709d93b3..cd28c04c1e 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -435,6 +435,7 @@  Limitations
      - yellow: QUEUE, RSS, PORT_ID, REPRESENTED_PORT, JUMP, DROP, MARK and SET_TAG.
      - RED: must be DROP.
   - Policy actions of RSS for green and yellow should have the same configuration except queues.
+  - Policy with RSS/queue action is not supported when ``dv_xmeta_en`` enabled.
   - meter profile packet mode is supported.
   - meter profiles of RFC2697, RFC2698 and RFC4115 are supported.