[v2,2/3] dmadev: enable build on Windows
Checks
Commit Message
The dmadev library was not added to the list of libraries built on
Windows, meaning it was skipped in those builds and also that none of
the drivers were being considered for build. Adding dmadev to the list
fixes this, and also enables the skeleton dmadev driver to be built -
all-be-it with a small fix necessary.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/dma/skeleton/skeleton_dmadev.c | 2 +-
lib/meson.build | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
--
2.30.2
Comments
On Wed, Oct 20, 2021 at 12:25:53PM +0100, Bruce Richardson wrote:
> The dmadev library was not added to the list of libraries built on
> Windows, meaning it was skipped in those builds and also that none of
> the drivers were being considered for build. Adding dmadev to the list
> fixes this, and also enables the skeleton dmadev driver to be built -
> all-be-it with a small fix necessary.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Adding missed reviewed tag from V1:
Reviewed-by: Chengwen Feng <fengchengwen@huawei.com>
> From: dev <dev-bounces@dpdk.org> On Behalf Of Bruce Richardson
> Sent: Wednesday 20 October 2021 12:26
> To: dev@dpdk.org
> Cc: david.marchand@redhat.com; dmitry.kozliuk@gmail.com;
> navasile@linux.microsoft.com; dmitrym@microsoft.com; Kadam, Pallavi
> <pallavi.kadam@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Chengwen Feng
> <fengchengwen@huawei.com>
> Subject: [dpdk-dev] [PATCH v2 2/3] dmadev: enable build on Windows
>
> The dmadev library was not added to the list of libraries built on
> Windows, meaning it was skipped in those builds and also that none of
> the drivers were being considered for build. Adding dmadev to the list
> fixes this, and also enables the skeleton dmadev driver to be built -
> all-be-it with a small fix necessary.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Tested-by: Conor Walsh <conor.walsh@intel.com>
(with MinGW and the Intel DMA drivers)
@@ -153,7 +153,7 @@ skeldma_stop(struct rte_dma_dev *dev)
hw->exit_flag = true;
rte_delay_ms(1);
- pthread_cancel(hw->thread);
+ (void)pthread_cancel(hw->thread);
pthread_join(hw->thread, NULL);
return 0;
@@ -75,6 +75,7 @@ if is_windows
'net',
'meter',
'ethdev',
+ 'dmadev',
'pci',
'cmdline',
'metrics',