diff mbox series

[v2] hash: promote APIs to stable

Message ID 20211015022710.13296-1-honnappa.nagarahalli@arm.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers show
Series [v2] hash: promote APIs to stable | expand

Checks

Context Check Description
ci/iol-aarch64-compile-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch warning coding style issues

Commit Message

Honnappa Nagarahalli Oct. 15, 2021, 2:27 a.m. UTC
Promote APIs to stable.

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
---
v2:
1) Removed EXPERIMENTAL warning in comments
2) Promoted all the APIs except rte_thash_*** APIs

 lib/hash/rte_hash.h  | 17 -----------------
 lib/hash/version.map | 10 +++++-----
 2 files changed, 5 insertions(+), 22 deletions(-)

Comments

David Marchand Oct. 20, 2021, 7:23 p.m. UTC | #1
On Fri, Oct 15, 2021 at 4:27 AM Honnappa Nagarahalli
<honnappa.nagarahalli@arm.com> wrote:
>
> Promote APIs to stable.
>
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> ---
> v2:
> 1) Removed EXPERIMENTAL warning in comments
> 2) Promoted all the APIs except rte_thash_*** APIs

Yipeng, Vladimir,

Are we good?


Honnappa,

One nit which I can handle when applying, if others are ok with patch.

> @@ -217,7 +214,6 @@ rte_hash_count(const struct rte_hash *h);
>   *   - -EINVAL if parameters are invalid
>   *   - A value indicating the max key ID of key slots present in the table.
>   */
> -__rte_experimental
>  int32_t
>  rte_hash_max_key_id(const struct rte_hash *h);
>
> @@ -430,7 +426,6 @@ rte_hash_get_key_with_position(const struct rte_hash *h, const int32_t position,
>   *   - 0 if freed successfully
>   *   - -EINVAL if the parameters are invalid.
>   */
> -__rte_experimental
>  int
>  rte_hash_free_key_with_position(const struct rte_hash *h,
>                                 const int32_t position);

There is still a @b EXPERIMENTAL banner for this function.
Honnappa Nagarahalli Oct. 20, 2021, 7:45 p.m. UTC | #2
<snip>

> 
> On Fri, Oct 15, 2021 at 4:27 AM Honnappa Nagarahalli
> <honnappa.nagarahalli@arm.com> wrote:
> >
> > Promote APIs to stable.
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> > ---
> > v2:
> > 1) Removed EXPERIMENTAL warning in comments
> > 2) Promoted all the APIs except rte_thash_*** APIs
> 
> Yipeng, Vladimir,
> 
> Are we good?
> 
> 
> Honnappa,
> 
> One nit which I can handle when applying, if others are ok with patch.
Thanks. I have no words to explain.

> 
> > @@ -217,7 +214,6 @@ rte_hash_count(const struct rte_hash *h);
> >   *   - -EINVAL if parameters are invalid
> >   *   - A value indicating the max key ID of key slots present in the table.
> >   */
> > -__rte_experimental
> >  int32_t
> >  rte_hash_max_key_id(const struct rte_hash *h);
> >
> > @@ -430,7 +426,6 @@ rte_hash_get_key_with_position(const struct
> rte_hash *h, const int32_t position,
> >   *   - 0 if freed successfully
> >   *   - -EINVAL if the parameters are invalid.
> >   */
> > -__rte_experimental
> >  int
> >  rte_hash_free_key_with_position(const struct rte_hash *h,
> >                                 const int32_t position);
> 
> There is still a @b EXPERIMENTAL banner for this function.
> 
> 
> --
> David Marchand
Wang, Yipeng1 Oct. 20, 2021, 8:47 p.m. UTC | #3
> -----Original Message-----
> From: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
> Sent: Wednesday, October 20, 2021 12:45 PM
> To: David Marchand <david.marchand@redhat.com>; Wang, Yipeng1
> <yipeng1.wang@intel.com>; Medvedkin, Vladimir
> <vladimir.medvedkin@intel.com>
> Cc: dev <dev@dpdk.org>; Ray Kinsella <mdr@ashroe.eu>; Stephen
> Hemminger <stephen@networkplumber.org>; Dharmik Thakkar
> <Dharmik.Thakkar@arm.com>; nd <nd@arm.com>; Gobriel, Sameh
> <sameh.gobriel@intel.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; nd <nd@arm.com>
> Subject: RE: [dpdk-dev] [PATCH v2] hash: promote APIs to stable
> 
> <snip>
> 
> >
> > On Fri, Oct 15, 2021 at 4:27 AM Honnappa Nagarahalli
> > <honnappa.nagarahalli@arm.com> wrote:
> > >
> > > Promote APIs to stable.
> > >
> > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> > > ---
> > > v2:
> > > 1) Removed EXPERIMENTAL warning in comments
> > > 2) Promoted all the APIs except rte_thash_*** APIs
> >
> > Yipeng, Vladimir,
> >
> > Are we good?
> >
> >
> > Honnappa,
> >
> > One nit which I can handle when applying, if others are ok with patch.
> Thanks. I have no words to explain.
> 
Thanks Honnappa and David.
Acked-by: Yipeng Wang <yipeng1.wang@intel.com>
David Marchand Oct. 21, 2021, 7:42 a.m. UTC | #4
On Wed, Oct 20, 2021 at 10:47 PM Wang, Yipeng1 <yipeng1.wang@intel.com> wrote:
> > > > Promote APIs to stable.
> > > >
> > > > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > > > Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Acked-by: Yipeng Wang <yipeng1.wang@intel.com>

Applied with nit fixed.
Thanks.
diff mbox series

Patch

diff --git a/lib/hash/rte_hash.h b/lib/hash/rte_hash.h
index 73c415ff7e..7cefc4a380 100644
--- a/lib/hash/rte_hash.h
+++ b/lib/hash/rte_hash.h
@@ -205,9 +205,6 @@  int32_t
 rte_hash_count(const struct rte_hash *h);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Return the maximum key value ID that could possibly be returned by
  * rte_hash_add_key function.
  *
@@ -217,7 +214,6 @@  rte_hash_count(const struct rte_hash *h);
  *   - -EINVAL if parameters are invalid
  *   - A value indicating the max key ID of key slots present in the table.
  */
-__rte_experimental
 int32_t
 rte_hash_max_key_id(const struct rte_hash *h);
 
@@ -430,7 +426,6 @@  rte_hash_get_key_with_position(const struct rte_hash *h, const int32_t position,
  *   - 0 if freed successfully
  *   - -EINVAL if the parameters are invalid.
  */
-__rte_experimental
 int
 rte_hash_free_key_with_position(const struct rte_hash *h,
 				const int32_t position);
@@ -564,9 +559,6 @@  rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,
 		      uint32_t num_keys, uint64_t *hit_mask, void *data[]);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Find multiple keys in the hash table with precomputed hash value array.
  * This operation is multi-thread safe with regarding to other lookup threads.
  * Read-write concurrency can be enabled by setting flag during
@@ -589,15 +581,11 @@  rte_hash_lookup_bulk_data(const struct rte_hash *h, const void **keys,
  * @return
  *   -EINVAL if there's an error, otherwise 0.
  */
-__rte_experimental
 int
 rte_hash_lookup_with_hash_bulk(const struct rte_hash *h, const void **keys,
 		hash_sig_t *sig, uint32_t num_keys, int32_t *positions);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Find multiple keys in the hash table with precomputed hash value array.
  * This operation is multi-thread safe with regarding to other lookup threads.
  * Read-write concurrency can be enabled by setting flag during
@@ -618,7 +606,6 @@  rte_hash_lookup_with_hash_bulk(const struct rte_hash *h, const void **keys,
  * @return
  *   -EINVAL if there's an error, otherwise number of successful lookups.
  */
-__rte_experimental
 int
 rte_hash_lookup_with_hash_bulk_data(const struct rte_hash *h,
 		const void **keys, hash_sig_t *sig,
@@ -672,9 +659,6 @@  int32_t
 rte_hash_iterate(const struct rte_hash *h, const void **key, void **data, uint32_t *next);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Associate RCU QSBR variable with a Hash object.
  * This API should be called to enable the integrated RCU QSBR support and
  * should be called immediately after creating the Hash object.
@@ -691,7 +675,6 @@  rte_hash_iterate(const struct rte_hash *h, const void **key, void **data, uint32
  *   - EEXIST - already added QSBR
  *   - ENOMEM - memory allocation failure
  */
-__rte_experimental
 int rte_hash_rcu_qsbr_add(struct rte_hash *h, struct rte_hash_rcu_config *cfg);
 
 #ifdef __cplusplus
diff --git a/lib/hash/version.map b/lib/hash/version.map
index ce4309aa07..81854701c8 100644
--- a/lib/hash/version.map
+++ b/lib/hash/version.map
@@ -14,6 +14,7 @@  DPDK_22 {
 	rte_hash_del_key_with_hash;
 	rte_hash_find_existing;
 	rte_hash_free;
+	rte_hash_free_key_with_position;
 	rte_hash_get_key_with_position;
 	rte_hash_hash;
 	rte_hash_iterate;
@@ -22,7 +23,11 @@  DPDK_22 {
 	rte_hash_lookup_bulk_data;
 	rte_hash_lookup_data;
 	rte_hash_lookup_with_hash;
+	rte_hash_lookup_with_hash_bulk;
+	rte_hash_lookup_with_hash_bulk_data;
 	rte_hash_lookup_with_hash_data;
+	rte_hash_max_key_id;
+	rte_hash_rcu_qsbr_add;
 	rte_hash_reset;
 	rte_hash_set_cmp_func;
 
@@ -32,11 +37,6 @@  DPDK_22 {
 EXPERIMENTAL {
 	global:
 
-	rte_hash_free_key_with_position;
-	rte_hash_lookup_with_hash_bulk;
-	rte_hash_lookup_with_hash_bulk_data;
-	rte_hash_max_key_id;
-	rte_hash_rcu_qsbr_add;
 	rte_thash_add_helper;
 	rte_thash_adjust_tuple;
 	rte_thash_find_existing;