diff mbox series

[v8,10/12] test: enable bpf autotest

Message ID	20210913181510.46058-11-stephen@networkplumber.org (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Date: Mon, 13 Sep 2021 11:15:08 -0700 Message-Id: <20210913181510.46058-11-stephen@networkplumber.org> In-Reply-To: <20210913181510.46058-1-stephen@networkplumber.org> References: <20210903004732.109023-1-stephen@networkplumber.org> <20210913181510.46058-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v8 10/12] test: enable bpf autotest Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Packet capture framework enhancements \| [v8,00/12] Packet capture framework enhancements [v8,01/12] librte_pcapng: add new library for writing pcapng files [v8,02/12] lib: pdump is not supported on Windows [v8,03/12] bpf: allow self-xor operation [v8,04/12] bpf: add function to convert classic BPF to DPDK BPF [v8,05/12] bpf: add function to dump eBPF instructions [v8,06/12] pdump: support pcapng and filtering [v8,07/12] app/dumpcap: add new packet capture application [v8,08/12] test: add test for bpf_convert [v8,09/12] test: add a test for pcapng library [v8,10/12] test: enable bpf autotest [v8,11/12] doc: changes for new pcapng and dumpcap [v8,12/12] MAINTAINERS: add entry for new packet capture features

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Sept. 13, 2021, 6:15 p.m. UTC

  The BPF autotest is defined but not run automatically.
Since it is short, it should be added to the autotest suite.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test/meson.build | 2 ++
 1 file changed, 2 insertions(+)

Comments

Ananyev, Konstantin Sept. 15, 2021, 11:27 a.m. UTC | #1

> The BPF autotest is defined but not run automatically.
> Since it is short, it should be added to the autotest suite.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 0d551ac9c2b2..cd18484bb73a 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -194,6 +194,8 @@ test_deps = [
>  fast_tests = [
>          ['acl_autotest', true],
>          ['atomic_autotest', false],
> +        ['bpf_autotest', true],
> +        ['bpf_convert_autotest', true],
>          ['bitops_autotest', true],
>          ['byteorder_autotest', true],
>          ['cksum_autotest', true],
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.30.2

Stephen Hemminger Sept. 15, 2021, 11:36 p.m. UTC | #2

On Wed, 15 Sep 2021 11:27:15 +0000
"Ananyev, Konstantin" <konstantin.ananyev@intel.com> wrote:

> > The BPF autotest is defined but not run automatically.
> > Since it is short, it should be added to the autotest suite.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  app/test/meson.build | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/app/test/meson.build b/app/test/meson.build
> > index 0d551ac9c2b2..cd18484bb73a 100644
> > --- a/app/test/meson.build
> > +++ b/app/test/meson.build
> > @@ -194,6 +194,8 @@ test_deps = [
> >  fast_tests = [
> >          ['acl_autotest', true],
> >          ['atomic_autotest', false],
> > +        ['bpf_autotest', true],
> > +        ['bpf_convert_autotest', true],
> >          ['bitops_autotest', true],
> >          ['byteorder_autotest', true],
> >          ['cksum_autotest', true],
> > --  
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>
> 
> > 2.30.2  
> 

One oddity of original BPF test is that it constructs an mbuf where there
is no Ethernet header.  Didn't want to change that since not only
would the constructor have to be changed but also the hand written
BPF programs as well.

Not necessarily a bug, but the test is not doing what any application
using BPF on incoming mbuf's would expect to do.

Stephen Hemminger Sept. 16, 2021, 3:09 a.m. UTC | #3

On Mon, 13 Sep 2021 11:15:08 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> The BPF autotest is defined but not run automatically.
> Since it is short, it should be added to the autotest suite.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  app/test/meson.build | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/app/test/meson.build b/app/test/meson.build
> index 0d551ac9c2b2..cd18484bb73a 100644
> --- a/app/test/meson.build
> +++ b/app/test/meson.build
> @@ -194,6 +194,8 @@ test_deps = [
>  fast_tests = [
>          ['acl_autotest', true],
>          ['atomic_autotest', false],
> +        ['bpf_autotest', true],
> +        ['bpf_convert_autotest', true],
>          ['bitops_autotest', true],
>          ['byteorder_autotest', true],
>          ['cksum_autotest', true],

Note: this patch exposes a pre-existing bug in DPDK:
https://bugs.dpdk.org/show_bug.cgi?id=811

The BPF code does not work if built with Clang.
The test was just being ignored by the CI before!

diff mbox series

Patch

diff --git a/app/test/meson.build b/app/test/meson.build
index 0d551ac9c2b2..cd18484bb73a 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -194,6 +194,8 @@  test_deps = [
 fast_tests = [
         ['acl_autotest', true],
         ['atomic_autotest', false],
+        ['bpf_autotest', true],
+        ['bpf_convert_autotest', true],
         ['bitops_autotest', true],
         ['byteorder_autotest', true],
         ['cksum_autotest', true],