diff mbox series

[v2] test/atomic: fix false failures for 128-bit atomic compare exchange test

Message ID 20210908174820.3485359-1-drc@linux.vnet.ibm.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series [v2] test/atomic: fix false failures for 128-bit atomic compare exchange test |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

David Christensen Sept. 8, 2021, 5:48 p.m. UTC 
  When checking the results of the rte_atomic128_cmp_exchange() function,
current code compares the values of a uint32_t and a uint64_t variable.
If the number of lcores used by the test is large, or the value of the
iteration count N is increased, the variable size mismatch can cause a
false test failure.  Modify the comparison to compare uint64_t values.

Fixes: fa3253c534b1 ("test/atomic: add 128-bit atomic compare exchange test")
Cc: phil.yang@arm.com

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Tested-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
v2:
- Fixed commit message spelling error
---
 app/test/test_atomic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.27.0

Comments

David Marchand Oct. 14, 2021, 3:28 p.m. UTC | #1 
On Wed, Sep 8, 2021 at 7:48 PM David Christensen <drc@linux.vnet.ibm.com> wrote:
>
> When checking the results of the rte_atomic128_cmp_exchange() function,
> current code compares the values of a uint32_t and a uint64_t variable.
> If the number of lcores used by the test is large, or the value of the
> iteration count N is increased, the variable size mismatch can cause a
> false test failure.  Modify the comparison to compare uint64_t values.
>
> Fixes: fa3253c534b1 ("test/atomic: add 128-bit atomic compare exchange test")
>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> Tested-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c
index f10f555af8..ce0c259bd7 100644
--- a/app/test/test_atomic.c
+++ b/app/test/test_atomic.c
@@ -591,7 +591,7 @@  test_atomic(void)
 	rte_atomic32_clear(&synchro);

 	iterations = count128.val[0] - count128.val[1];
-	if (iterations != 4*N*(rte_lcore_count()-1)) {
+	if (iterations != (uint64_t)4*N*(rte_lcore_count()-1)) {
 		printf("128-bit compare and swap failed\n");
 		return -1;
 	}