[RFC,13/15] eventdev: promote event vector API to stable

Message ID 20210823194020.1229-13-pbhagavatula@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series [RFC,01/15] eventdev: make driver interface as internal |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Pavan Nikhilesh Bhagavatula Aug. 23, 2021, 7:40 p.m. UTC
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Promote event vector configuration APIs to stable.

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 lib/eventdev/rte_event_eth_rx_adapter.h | 2 --
 lib/eventdev/rte_eventdev.h             | 1 -
 lib/eventdev/version.map                | 6 +++---
 3 files changed, 3 insertions(+), 6 deletions(-)
  

Comments

Jayatheerthan, Jay Aug. 30, 2021, 2:43 p.m. UTC | #1
> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Tuesday, August 24, 2021 1:10 AM
> To: jerinj@marvell.com; Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Ray Kinsella <mdr@ashroe.eu>
> Cc: Ananyev, Konstantin <konstantin.ananyev@intel.com>; dev@dpdk.org; Pavan Nikhilesh <pbhagavatula@marvell.com>
> Subject: [dpdk-dev] [RFC 13/15] eventdev: promote event vector API to stable
> 
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Promote event vector configuration APIs to stable.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  lib/eventdev/rte_event_eth_rx_adapter.h | 2 --
>  lib/eventdev/rte_eventdev.h             | 1 -
>  lib/eventdev/version.map                | 6 +++---
>  3 files changed, 3 insertions(+), 6 deletions(-)
> 
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h
> index 182dd2e5dd..d13d817025 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.h
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.h
> @@ -543,7 +543,6 @@ int rte_event_eth_rx_adapter_cb_register(uint8_t id, uint16_t eth_dev_id,
>   *  - 0: Success.
>   *  - <0: Error code on failure.
>   */
> -__rte_experimental
>  int rte_event_eth_rx_adapter_vector_limits_get(
>  	uint8_t dev_id, uint16_t eth_port_id,
>  	struct rte_event_eth_rx_adapter_vector_limits *limits);
> @@ -570,7 +569,6 @@ int rte_event_eth_rx_adapter_vector_limits_get(
>   *  - 0: Success, Receive queue configured correctly.
>   *  - <0: Error code on failure.
>   */
> -__rte_experimental
>  int rte_event_eth_rx_adapter_queue_event_vector_config(
>  	uint8_t id, uint16_t eth_dev_id, int32_t rx_queue_id,
>  	struct rte_event_eth_rx_adapter_event_vector_config *config);

Looks good to me.
Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com>

> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> index 5853fadb0d..f73346167b 100644
> --- a/lib/eventdev/rte_eventdev.h
> +++ b/lib/eventdev/rte_eventdev.h
> @@ -1734,7 +1734,6 @@ int rte_event_dev_selftest(uint8_t dev_id);
>   *    - ENOMEM - no appropriate memory area found in which to create memzone
>   *    - ENAMETOOLONG - mempool name requested is too long.
>   */
> -__rte_experimental
>  struct rte_mempool *
>  rte_event_vector_pool_create(const char *name, unsigned int n,
>  			     unsigned int cache_size, uint16_t nb_elem,
> diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
> index d89cbc337e..062ca959e5 100644
> --- a/lib/eventdev/version.map
> +++ b/lib/eventdev/version.map
> @@ -38,10 +38,12 @@ DPDK_22 {
>  	rte_event_eth_rx_adapter_free;
>  	rte_event_eth_rx_adapter_queue_add;
>  	rte_event_eth_rx_adapter_queue_del;
> +	rte_event_eth_rx_adapter_queue_event_vector_config;
>  	rte_event_eth_rx_adapter_service_id_get;
>  	rte_event_eth_rx_adapter_start;
>  	rte_event_eth_rx_adapter_stats_get;
>  	rte_event_eth_rx_adapter_stats_reset;
> +	rte_event_eth_rx_adapter_vector_limits_get;
>  	rte_event_eth_rx_adapter_stop;
>  	rte_event_eth_tx_adapter_caps_get;
>  	rte_event_eth_tx_adapter_create;
> @@ -83,6 +85,7 @@ DPDK_22 {
>  	rte_event_timer_arm_burst;
>  	rte_event_timer_arm_tmo_tick_burst;
>  	rte_event_timer_cancel_burst;
> +	rte_event_vector_pool_create;
>  	rte_eventdevs;
> 
>  	#added in 21.11
> @@ -135,9 +138,6 @@ EXPERIMENTAL {
>  	__rte_eventdev_trace_port_setup;
> 
>  	#added in 21.05
> -	rte_event_vector_pool_create;
> -	rte_event_eth_rx_adapter_vector_limits_get;
> -	rte_event_eth_rx_adapter_queue_event_vector_config;
>  	__rte_eventdev_trace_crypto_adapter_enqueue;
>  };
> 
> --
> 2.17.1
  
Ray Kinsella Sept. 8, 2021, 12:05 p.m. UTC | #2
On 23/08/2021 20:40, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Promote event vector configuration APIs to stable.
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>  lib/eventdev/rte_event_eth_rx_adapter.h | 2 --
>  lib/eventdev/rte_eventdev.h             | 1 -
>  lib/eventdev/version.map                | 6 +++---
>  3 files changed, 3 insertions(+), 6 deletions(-)
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>
  

Patch

diff --git a/lib/eventdev/rte_event_eth_rx_adapter.h b/lib/eventdev/rte_event_eth_rx_adapter.h
index 182dd2e5dd..d13d817025 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.h
+++ b/lib/eventdev/rte_event_eth_rx_adapter.h
@@ -543,7 +543,6 @@  int rte_event_eth_rx_adapter_cb_register(uint8_t id, uint16_t eth_dev_id,
  *  - 0: Success.
  *  - <0: Error code on failure.
  */
-__rte_experimental
 int rte_event_eth_rx_adapter_vector_limits_get(
 	uint8_t dev_id, uint16_t eth_port_id,
 	struct rte_event_eth_rx_adapter_vector_limits *limits);
@@ -570,7 +569,6 @@  int rte_event_eth_rx_adapter_vector_limits_get(
  *  - 0: Success, Receive queue configured correctly.
  *  - <0: Error code on failure.
  */
-__rte_experimental
 int rte_event_eth_rx_adapter_queue_event_vector_config(
 	uint8_t id, uint16_t eth_dev_id, int32_t rx_queue_id,
 	struct rte_event_eth_rx_adapter_event_vector_config *config);
diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index 5853fadb0d..f73346167b 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1734,7 +1734,6 @@  int rte_event_dev_selftest(uint8_t dev_id);
  *    - ENOMEM - no appropriate memory area found in which to create memzone
  *    - ENAMETOOLONG - mempool name requested is too long.
  */
-__rte_experimental
 struct rte_mempool *
 rte_event_vector_pool_create(const char *name, unsigned int n,
 			     unsigned int cache_size, uint16_t nb_elem,
diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map
index d89cbc337e..062ca959e5 100644
--- a/lib/eventdev/version.map
+++ b/lib/eventdev/version.map
@@ -38,10 +38,12 @@  DPDK_22 {
 	rte_event_eth_rx_adapter_free;
 	rte_event_eth_rx_adapter_queue_add;
 	rte_event_eth_rx_adapter_queue_del;
+	rte_event_eth_rx_adapter_queue_event_vector_config;
 	rte_event_eth_rx_adapter_service_id_get;
 	rte_event_eth_rx_adapter_start;
 	rte_event_eth_rx_adapter_stats_get;
 	rte_event_eth_rx_adapter_stats_reset;
+	rte_event_eth_rx_adapter_vector_limits_get;
 	rte_event_eth_rx_adapter_stop;
 	rte_event_eth_tx_adapter_caps_get;
 	rte_event_eth_tx_adapter_create;
@@ -83,6 +85,7 @@  DPDK_22 {
 	rte_event_timer_arm_burst;
 	rte_event_timer_arm_tmo_tick_burst;
 	rte_event_timer_cancel_burst;
+	rte_event_vector_pool_create;
 	rte_eventdevs;
 
 	#added in 21.11
@@ -135,9 +138,6 @@  EXPERIMENTAL {
 	__rte_eventdev_trace_port_setup;
 
 	#added in 21.05
-	rte_event_vector_pool_create;
-	rte_event_eth_rx_adapter_vector_limits_get;
-	rte_event_eth_rx_adapter_queue_event_vector_config;
 	__rte_eventdev_trace_crypto_adapter_enqueue;
 };