From patchwork Thu Aug 19 06:11:25 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joyce Kong X-Patchwork-Id: 97097 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5DA6FA0C47; Thu, 19 Aug 2021 08:11:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E9C2A4067E; Thu, 19 Aug 2021 08:11:45 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id C3B0C40141; Thu, 19 Aug 2021 08:11:44 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 3D6BC101E; Wed, 18 Aug 2021 23:11:44 -0700 (PDT) Received: from net-arm-n1sdp.shanghai.arm.com (net-arm-n1sdp.shanghai.arm.com [10.169.208.222]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AF4D73F70D; Wed, 18 Aug 2021 23:11:41 -0700 (PDT) From: Joyce Kong To: jerin.jacob@caviumnetworks.com, harry.van.haaren@intel.com, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com Cc: dev@dpdk.org, nd@arm.com, stable@dpdk.org Date: Thu, 19 Aug 2021 01:11:25 -0500 Message-Id: <20210819061125.19929-1-joyce.kong@arm.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] test/service_cores: fix wrong comment X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Change the inaccurate comment of 'set pass flag' to 'clear pass flag' as the '*pass_test = 0' code actually implements clearing. Fixes: f038a81e1c56 ("service: add unit tests") Cc: stable@dpdk.org Signed-off-by: Joyce Kong Reviewed-by: Ruifeng Wang Acked-by: Harry van Haaren --- app/test/test_service_cores.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_service_cores.c b/app/test/test_service_cores.c index ece104054e..8659a1526c 100644 --- a/app/test/test_service_cores.c +++ b/app/test/test_service_cores.c @@ -68,7 +68,7 @@ static int32_t dummy_mt_unsafe_cb(void *args) rte_delay_ms(250); __atomic_store_n(lock, 0, __ATOMIC_RELAXED); } else { - /* 2nd thread will fail to take lock, so set pass flag */ + /* 2nd thread will fail to take lock, so clear pass flag */ *pass_test = 0; }