diff mbox series

[v2,2/2] ethdev: announce moving to general modify function

Message ID 20210803085754.643180-2-orika@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series [v2,1/2] ethdev: announce change to action modify data | expand

Checks

Context Check Description
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing fail Testing issues
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-spell-check-testing warning Testing issues
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/github-robot success github build: passed
ci/checkpatch success coding style OK

Commit Message

Ori Kam Aug. 3, 2021, 8:57 a.m. UTC
Currently there is a dedicated modify function for each
field that the application wants to change.
For example:
rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP.
rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.

A new function rte_flow_action_modify_field DPDK added the ability
to use the same function to modify any field, in addition to be able to
modify the value based on different field and not just immediate value.

Signed-off-by: Ori Kam <orika@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
V2:
  Fix typo.
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

Comments

Ajit Khaparde Aug. 3, 2021, 6:05 p.m. UTC | #1
On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote:
>
> Currently there is a dedicated modify function for each
> field that the application wants to change.
> For example:
> rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP.
> rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.
>
> A new function rte_flow_action_modify_field DPDK added the ability
> to use the same function to modify any field, in addition to be able to
> modify the value based on different field and not just immediate value.
>
> Signed-off-by: Ori Kam <orika@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

> ---
> V2:
>   Fix typo.
> ---
>  doc/guides/rel_notes/deprecation.rst | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index b530616281..77491c322f 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -162,3 +162,6 @@ Deprecation Notices
>  * ethdev: The struct ``rte_flow_action_modify_data`` will be modified
>    to support modifying larger fields than 64 bits.
>    In addition, documentation will be updated to clarify byte order.
> +
> +* ethdev: Announce moving from dedicated modify function for each field,
> +  to using the general ``rte_flow_modify_field`` action.
> --
> 2.25.1
>
Jerin Jacob Aug. 7, 2021, 1:33 p.m. UTC | #2
On Tue, Aug 3, 2021 at 11:35 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote:
> >
> > Currently there is a dedicated modify function for each
> > field that the application wants to change.
> > For example:
> > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP.
> > rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.
> >
> > A new function rte_flow_action_modify_field DPDK added the ability
> > to use the same function to modify any field, in addition to be able to
> > modify the value based on different field and not just immediate value.
> >
> > Signed-off-by: Ori Kam <orika@nvidia.com>
> > Acked-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>


>
> > ---
> > V2:
> >   Fix typo.
> > ---
> >  doc/guides/rel_notes/deprecation.rst | 3 +++
> >  1 file chanAcked-by: Jerin Jacob <jerinj@marvell.com>
ed, 3 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> > index b530616281..77491c322f 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -162,3 +162,6 @@ Deprecation Notices
> >  * ethdev: The struct ``rte_flow_action_modify_data`` will be modified
> >    to support modifying larger fields than 64 bits.
> >    In addition, documentation will be updated to clarify byte order.
> > +
> > +* ethdev: Announce moving from dedicated modify function for each field,
> > +  to using the general ``rte_flow_modify_field`` action.
> > --
> > 2.25.1
> >
Thomas Monjalon Aug. 7, 2021, 7:34 p.m. UTC | #3
> > > Currently there is a dedicated modify function for each
> > > field that the application wants to change.
> > > For example:
> > > rte_flow_action_type_set_tp_port to modify destination port of UDP/TCP.
> > > rte_flow_action_type_set_ipv4_dst to modify destination of IPv4.
> > >
> > > A new function rte_flow_action_modify_field DPDK added the ability
> > > to use the same function to modify any field, in addition to be able to
> > > modify the value based on different field and not just immediate value.
> > >
> > > Signed-off-by: Ori Kam <orika@nvidia.com>
> > > Acked-by: Matan Azrad <matan@nvidia.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Acked-by: Jerin Jacob <jerinj@marvell.com>

> > > +* ethdev: Announce moving from dedicated modify function for each field,
> > > +  to using the general ``rte_flow_modify_field`` action.

This is a very vague announce.
OK we can replace a lot of actions with rte_flow_modify_field,
but it doesn't say when and which functions will be removed.
I think we should make a more precise announce for removal of some actions
in DPDK 22.11.

In the meantime, let's introduce this hint that something is changing
as it is acked.

Applied.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b530616281..77491c322f 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -162,3 +162,6 @@  Deprecation Notices
 * ethdev: The struct ``rte_flow_action_modify_data`` will be modified
   to support modifying larger fields than 64 bits.
   In addition, documentation will be updated to clarify byte order.
+
+* ethdev: Announce moving from dedicated modify function for each field,
+  to using the general ``rte_flow_modify_field`` action.