Message ID | 20210803085754.643180-1-orika@nvidia.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 67357A0C41; Tue, 3 Aug 2021 10:59:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D51F411BF; Tue, 3 Aug 2021 10:58:27 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2041.outbound.protection.outlook.com [40.107.244.41]) by mails.dpdk.org (Postfix) with ESMTP id 344B9411BA for <dev@dpdk.org>; Tue, 3 Aug 2021 10:58:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kUjevqHEi/ywrEg6Pyrgn5ujgFBFVk9bn8Shn1RPeRFBA0YDK0lu0Ux/YVtqcXA4vFLrP8FILtawOCaOfsObEAcEoojHvUF52frDoutKqc347E948cInnPmGiQO/RdZKyrptgDF9GAm2QEq6DmbT1sFuEVLBcjAmNeDdNcc3C/ujhgmxLKzM9vtpY/nztgbZ/vumhlCUO5mLpobMEnfw9lW0UYQFkPVG02tvPnKG8GKAfGgcOeUCCiirgqP854dAU/Bq9Dg7PZRfzoqpyHYHsLvCn3ut1jMcNMnEJrPlNawJuuI65HLzedf2r1GhT5Zt9daShMPVUNYtFUUCyjhjqQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=magg347H+is8efoY/JflfFzHWUcL9njqC6Jgl1pAbuQ=; b=fw1MwMvP+IqVP0UqDUZiHrdNmfp9ihAcOHXDvh3lLW0ZUBu+21Z9t9yZ1ujv4lszxigZ5plLPu32REk8rf6TqrDxQPt0EfPhxW0c4Ipm7A8L6FeIM+hMfhNGvSDG+cVtBeO9B/63NofTML9AI7RgZnuhBUue2sIw8hqq4w8W1YtA19O1mg1zWkJlFjkkofm9yzGsMIa/IetugADmWxocOFs7NR97ZFZ03t9jHfiM8Oky/Cf9NeuuhfPoP0k2FQ8hL1TFMHqeFYv+D8CJmj3bblSlvD9xTjV9kvR7YBT2sgOiabtR3RRAv2gjObKkc20RhINZZcEFpLj44jJGQd3V5w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=quarantine sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=magg347H+is8efoY/JflfFzHWUcL9njqC6Jgl1pAbuQ=; b=VPCxA9g2Jhm1WFd9zLQPDddwxMFG+tZd+R+N1NjKd6gWqbBnPEyuwoURsyZGFJIGKX9DT/JUdjVp1p0SCkXflxzzrS5zhDhd7YcfvHISyh9ocPpcJedZejQyTizSa81x8KdsNRD/8dg0i7NRs2KhIQQX1Yho371cI9rutJPe8IuiwM3DkbCD+wTesEDA/NlQ4fbDax4IkwEYVjLfEvPrC/MeMSWUO0HD3jj7iML527zCQZCxZAgoTZVVLFmmDkBtSHN9vTR0gNn2EiiRcV2qI2s3xWp5/dPPrrRmyehgdVHBm2zHWqjpAuuN4bdHgiAgcgS1vMzoGlHHBZb/a9EgYQ== Received: from BN8PR12CA0005.namprd12.prod.outlook.com (2603:10b6:408:60::18) by BL0PR12MB5537.namprd12.prod.outlook.com (2603:10b6:208:1cc::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4373.18; Tue, 3 Aug 2021 08:58:24 +0000 Received: from BN8NAM11FT039.eop-nam11.prod.protection.outlook.com (2603:10b6:408:60:cafe::2f) by BN8PR12CA0005.outlook.office365.com (2603:10b6:408:60::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4394.15 via Frontend Transport; Tue, 3 Aug 2021 08:58:24 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT039.mail.protection.outlook.com (10.13.177.169) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4373.18 via Frontend Transport; Tue, 3 Aug 2021 08:58:23 +0000 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 3 Aug 2021 08:58:23 +0000 Received: from nvidia.com (172.20.187.6) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 3 Aug 2021 08:58:20 +0000 From: Ori Kam <orika@nvidia.com> To: <thomas@monjalon.net>, <andrew.rybchenko@oktetlabs.ru>, Ray Kinsella <mdr@ashroe.eu> CC: <orika@nvidia.com>, <dev@dpdk.org>, <ajit.khaparde@broadcom.com>, <viacheslavo@nvidia.com>, <ferruh.yigit@intel.com>, <matan@nvidia.com>, <rasland@nvidia.com>, <gakhil@marvell.com> Date: Tue, 3 Aug 2021 11:57:53 +0300 Message-ID: <20210803085754.643180-1-orika@nvidia.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210802141004.353754-1-matan@nvidia.com> References: <20210802141004.353754-1-matan@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.187.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To DRHQMAIL107.nvidia.com (10.27.9.16) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d7b30a7-b69a-4f93-6336-08d9565cd9b3 X-MS-TrafficTypeDiagnostic: BL0PR12MB5537: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: <BL0PR12MB5537945629FC568319ED0713D6F09@BL0PR12MB5537.namprd12.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 01fiAmxZ6ncHlDC76KB3XfKxjH13jd9NiKf2OuEsao2ldrXHguVK8Oa7eX26dMB6tM2mC0FRVL+OWcr4/fSHJZkq8XeUM2uz88VSovpO3tUBxzdQnJkipZEZseat8S0LR6c7sF1bTMLg69dqBC9oqNpcqJ0IjwKlLFKjxHZfgTUPUm+vDI6slHIcUax+OqkCg6ka7gVRhNUO2ReRXoIlNna1N1wVzy3j7emVvhyaQ7QageSbPcB5T9f0fvPvjiJSLxEQEwIZrz+b4oINKvqcSopwsexeudeF5qo+7+VHPl13tSb/LijEnd53kW4iSrV3EdGClTA5r40wT7Xs2Lqkrau4GinG1evivaEQYMSGSbxuLPHHVW7OE3zDU5qQNBK1VLxrN1/9bcHuSPHlTN19MkQEKCePFoVZWrGFWZZj88RIMlO01O8soI3E8rhIMW6PA4A7P2bPCgGAF6wqJ2wmO8CHj4dXK3ublrjPBdPNV4y1i2NSfuZPx4WH2i1q97FvpnkvEEquLq2zEa+FI3JGMIBXkwO72NAVZx8vCvzkvW/shbabwwQxU1daUrnDX8wu82DJkowa4C2r4IQnqb/wDTrmbqry6sMQMXuZTluSrPh/PCR58n3NyB4cXG5thXEYV4Jmbr/+5sRLVgsKhCbOwDf8LgEXOHkqnhzoJ5tbQQw0AscKikfTIgajU58LMtJvG1wSwcu1SvwPPsvdQzrFNQ== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(46966006)(36840700001)(6286002)(2906002)(36860700001)(47076005)(1076003)(7696005)(2616005)(426003)(55016002)(110136005)(54906003)(4326008)(356005)(316002)(36906005)(70206006)(6666004)(7636003)(86362001)(16526019)(186003)(8676002)(36756003)(8936002)(336012)(5660300002)(83380400001)(82310400003)(70586007)(508600001)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2021 08:58:23.7478 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d7b30a7-b69a-4f93-6336-08d9565cd9b3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT039.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB5537 Subject: [dpdk-dev] [PATCH v2 1/2] ethdev: announce change to action modify data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
[v2,1/2] ethdev: announce change to action modify data
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Ori Kam
Aug. 3, 2021, 8:57 a.m. UTC
In the current implementation, the action rte_flow_action_modify_field is not well defined for fields larger than 64 bits (for example IPv6 source) In addition, the byte order is also not well defined. Both of those issue should be fixed. Signed-off-by: Ori Kam <orika@nvidia.com> Acked-by: Matan Azrad <matan@nvidia.com> --- V2: Fix typo. --- doc/guides/rel_notes/deprecation.rst | 4 ++++ 1 file changed, 4 insertions(+)
Comments
On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote: > > In the current implementation, > the action rte_flow_action_modify_field is not well defined > for fields larger than 64 bits (for example IPv6 source) > In addition, the byte order is also not well defined. > > Both of those issue should be fixed. > > Signed-off-by: Ori Kam <orika@nvidia.com> > Acked-by: Matan Azrad <matan@nvidia.com> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > --- > V2: > Fix typo. > --- > doc/guides/rel_notes/deprecation.rst | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index d9c0e65921..b530616281 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -158,3 +158,7 @@ Deprecation Notices > * security: The functions ``rte_security_set_pkt_metadata`` and > ``rte_security_get_userdata`` will be made inline functions and additional > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. > + > +* ethdev: The struct ``rte_flow_action_modify_data`` will be modified > + to support modifying larger fields than 64 bits. > + In addition, documentation will be updated to clarify byte order. > -- > 2.25.1 >
On 8/3/21 9:10 PM, Ajit Khaparde wrote: > On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote: >> >> In the current implementation, >> the action rte_flow_action_modify_field is not well defined >> for fields larger than 64 bits (for example IPv6 source) >> In addition, the byte order is also not well defined. >> >> Both of those issue should be fixed. >> >> Signed-off-by: Ori Kam <orika@nvidia.com> >> Acked-by: Matan Azrad <matan@nvidia.com> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
On Wed, Aug 4, 2021 at 5:40 PM Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> wrote: > > On 8/3/21 9:10 PM, Ajit Khaparde wrote: > > On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote: > >> > >> In the current implementation, > >> the action rte_flow_action_modify_field is not well defined > >> for fields larger than 64 bits (for example IPv6 source) > >> In addition, the byte order is also not well defined. > >> > >> Both of those issue should be fixed. > >> > >> Signed-off-by: Ori Kam <orika@nvidia.com> > >> Acked-by: Matan Azrad <matan@nvidia.com> > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Acked-by: Jerin Jacob <jerinj@marvell.com> >
> > >> In the current implementation, > > >> the action rte_flow_action_modify_field is not well defined > > >> for fields larger than 64 bits (for example IPv6 source) > > >> In addition, the byte order is also not well defined. > > >> > > >> Both of those issue should be fixed. > > >> > > >> Signed-off-by: Ori Kam <orika@nvidia.com> > > >> Acked-by: Matan Azrad <matan@nvidia.com> > > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> > Acked-by: Jerin Jacob <jerinj@marvell.com> Applied, thanks.
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst index d9c0e65921..b530616281 100644 --- a/doc/guides/rel_notes/deprecation.rst +++ b/doc/guides/rel_notes/deprecation.rst @@ -158,3 +158,7 @@ Deprecation Notices * security: The functions ``rte_security_set_pkt_metadata`` and ``rte_security_get_userdata`` will be made inline functions and additional flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. + +* ethdev: The struct ``rte_flow_action_modify_data`` will be modified + to support modifying larger fields than 64 bits. + In addition, documentation will be updated to clarify byte order.