diff mbox series

[v3,2/2] ethdev: announce clarification of implicit filter by port

Message ID 20210802195723.2153114-2-andrew.rybchenko@oktetlabs.ru (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series [v3,1/2] ethdev: announce flow API action PORT_ID changes | expand

Checks

Context Check Description
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-spell-check-testing warning Testing issues
ci/github-robot success github build: passed
ci/checkpatch success coding style OK

Commit Message

Andrew Rybchenko Aug. 2, 2021, 7:57 p.m. UTC
Transfer flow rules may be applied to traffic entering switch from
many sources. There are flow API pattern items which allow to specify
ingress port match criteria explicitly, but it is not documented
if ethdev port used to create flow rule adds any implicit match
criteria and how it coexists with explicit ones.

These aspects should be documented and drivers and applications
which use it in a a different way must be fixed.

Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Acked-by: Ori Kam <orika@nvidia.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Ajit Khaparde Aug. 2, 2021, 9:17 p.m. UTC | #1
On Mon, Aug 2, 2021 at 12:57 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> Transfer flow rules may be applied to traffic entering switch from
> many sources. There are flow API pattern items which allow to specify
> ingress port match criteria explicitly, but it is not documented
> if ethdev port used to create flow rule adds any implicit match
> criteria and how it coexists with explicit ones.
>
> These aspects should be documented and drivers and applications
> which use it in a a different way must be fixed.
nit! "in a different way..."
otherwise

Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

>
> Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Acked-by: Ori Kam <orika@nvidia.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 6e6413c89f..4d174c8952 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -163,3 +163,8 @@ Deprecation Notices
>    clarification. Structure rte_flow_action_port_id will be extended to
>    specify traffic direction to represented entity or ethdev port itself in
>    DPDK 21.11.
> +
> +* ethdev: Flow API documentation is unclear if ethdev port used to create
> +  a flow rule adds any implicit match criteria in the case of transfer rules.
> +  The semantics will be clarified in DPDK 21.11 and it will require fixes in
> +  drivers and applications which interpret it in a different way.
> --
> 2.30.2
>
Thomas Monjalon Aug. 7, 2021, 9:10 p.m. UTC | #2
> > Transfer flow rules may be applied to traffic entering switch from
> > many sources. There are flow API pattern items which allow to specify
> > ingress port match criteria explicitly, but it is not documented
> > if ethdev port used to create flow rule adds any implicit match
> > criteria and how it coexists with explicit ones.
> >
> > These aspects should be documented and drivers and applications
> > which use it in a a different way must be fixed.
> nit! "in a different way..."
> otherwise
> 
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> 
> > Signed-off-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> > Acked-by: Ori Kam <orika@nvidia.com>

+1 for clarification
Acked-by: Thomas Monjalon <thomas@monjalon.net>

Applied, thanks.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 6e6413c89f..4d174c8952 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -163,3 +163,8 @@  Deprecation Notices
   clarification. Structure rte_flow_action_port_id will be extended to
   specify traffic direction to represented entity or ethdev port itself in
   DPDK 21.11.
+
+* ethdev: Flow API documentation is unclear if ethdev port used to create
+  a flow rule adds any implicit match criteria in the case of transfer rules.
+  The semantics will be clarified in DPDK 21.11 and it will require fixes in
+  drivers and applications which interpret it in a different way.