diff mbox series

[2/2] doc: announce eth new offload flag and group field

Message ID 20210802131056.2683266-2-xuemingl@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series [1/2] doc: announce eth queue release callback parameter change | expand

Checks

Context Check Description
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing fail Testing issues
ci/iol-spell-check-testing warning Testing issues
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot success github build: passed
ci/checkpatch success coding style OK

Commit Message

Xueming(Steven) Li Aug. 2, 2021, 1:10 p.m. UTC
To support shared Rx queue, this patch announces new offload flag
RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct
rte_eth_rxconf in DPDK v21.11.

[1] mail list discussion:
https://mails.dpdk.org/archives/dev/2021-July/215575.html

Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 doc/guides/rel_notes/deprecation.rst | 3 +++
 1 file changed, 3 insertions(+)

Comments

Viacheslav Ovsiienko Aug. 4, 2021, 8:08 a.m. UTC | #1
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
> Sent: Monday, August 2, 2021 16:11
> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Ray Kinsella
> <mdr@ashroe.eu>
> Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and
> group field
> 
> To support shared Rx queue, this patch announces new offload flag
> RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct
> rte_eth_rxconf in DPDK v21.11.
> 
> [1] mail list discussion:
> https://mails.dpdk.org/archives/dev/2021-July/215575.html
> 
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>

We need this change to handle shared queues - the same queue
object can be shared by multiple ports, and releasing routine should
know exactly on which port_id/queue_id  object is being released.

Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Andrew Rybchenko Aug. 4, 2021, 12:29 p.m. UTC | #2
On 8/4/21 11:08 AM, Slava Ovsiienko wrote:
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
>> Sent: Monday, August 2, 2021 16:11
>> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Ray Kinsella
>> <mdr@ashroe.eu>
>> Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and
>> group field
>>
>> To support shared Rx queue, this patch announces new offload flag
>> RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct
>> rte_eth_rxconf in DPDK v21.11.
>>
>> [1] mail list discussion:
>> https://mails.dpdk.org/archives/dev/2021-July/215575.html
>>
>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> 
> We need this change to handle shared queues - the same queue
> object can be shared by multiple ports, and releasing routine should
> know exactly on which port_id/queue_id  object is being released.
> 
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> 

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Jerin Jacob Aug. 7, 2021, 1:32 p.m. UTC | #3
On Wed, Aug 4, 2021 at 5:59 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> On 8/4/21 11:08 AM, Slava Ovsiienko wrote:
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
> >> Sent: Monday, August 2, 2021 16:11
> >> Cc: dev@dpdk.org; Xueming(Steven) Li <xuemingl@nvidia.com>; Ray Kinsella
> >> <mdr@ashroe.eu>
> >> Subject: [dpdk-dev] [PATCH 2/2] doc: announce eth new offload flag and
> >> group field
> >>
> >> To support shared Rx queue, this patch announces new offload flag
> >> RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct
> >> rte_eth_rxconf in DPDK v21.11.
> >>
> >> [1] mail list discussion:
> >> https://mails.dpdk.org/archives/dev/2021-July/215575.html
> >>
> >> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> >
> > We need this change to handle shared queues - the same queue
> > object can be shared by multiple ports, and releasing routine should
> > know exactly on which port_id/queue_id  object is being released.
> >
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> >
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Acked-by: Jerin Jacob <jerinj@marvell.com>
Thomas Monjalon Aug. 7, 2021, 7:15 p.m. UTC | #4
> > >> To support shared Rx queue, this patch announces new offload flag
> > >> RTE_ETH_RX_OFFLOAD_SHARED_RXQ and new shared_group field to struct
> > >> rte_eth_rxconf in DPDK v21.11.
> > >>
> > >> [1] mail list discussion:
> > >> https://mails.dpdk.org/archives/dev/2021-July/215575.html
> > >>
> > >> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> > >
> > > We need this change to handle shared queues - the same queue
> > > object can be shared by multiple ports, and releasing routine should
> > > know exactly on which port_id/queue_id  object is being released.
> > >
> > > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index c38aebe99d..14f1f2dca7 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -131,6 +131,9 @@  Deprecation Notices
   consistent with existing outer header checksum status flag naming, which
   should help in reducing confusion about its usage.
 
+* ethdev: add new Rx queue offload flag ``RTE_ETH_RX_OFFLOAD_SHARED_RXQ`` and
+  ``shared_group`` field to struct rte_eth_rxconf.
+
 * ethdev: queue release callback parameter will be changed to device and queue
   ID to align with other queue configureation callback.