diff mbox series

[v2] net/bnxt: fix rxq interrupt setting

Message ID 20210702012415.54208-1-ajit.khaparde@broadcom.com (mailing list archive)
State Accepted, archived
Delegated to: Ajit Khaparde
Headers show
Series [v2] net/bnxt: fix rxq interrupt setting | expand

Checks

Context Check Description
ci/iol-abi-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing fail Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot success github build: passed
ci/checkpatch success coding style OK

Commit Message

Ajit Khaparde July 2, 2021, 1:24 a.m. UTC
Don't set rxq interrupt config
Applications can set the rxq interrupt config to 1 or 0 as needed.
If an application is not interested in handling Rx interrupts and
prefers to poll Rx rings, there is no need for the PMD to set this
config option to 1.

Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt")
Cc: stable@dpdk.org

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
---
v1->v2: Setting 0 or 1 in PMD would override application setting.  So skip it.
---
 drivers/net/bnxt/bnxt_ethdev.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Ajit Khaparde July 2, 2021, 9:38 p.m. UTC | #1
On Thu, Jul 1, 2021 at 6:24 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:

> Don't set rxq interrupt config
> Applications can set the rxq interrupt config to 1 or 0 as needed.
> If an application is not interested in handling Rx interrupts and
> prefers to poll Rx rings, there is no need for the PMD to set this
> config option to 1.
>
> Fixes: 1fe427fd08ee ("net/bnxt: support enable/disable interrupt")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
> ---
> v1->v2: Setting 0 or 1 in PMD would override application setting.  So skip
> it.
> ---
>
Patch applied dpdk-next-net-brcm tree, for-next-net branch.



>  drivers/net/bnxt/bnxt_ethdev.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c
> b/drivers/net/bnxt/bnxt_ethdev.c
> index 495c6cd21e..ed09f1bf52 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -1011,7 +1011,6 @@ static int bnxt_dev_info_get_op(struct rte_eth_dev
> *eth_dev,
>         };
>         eth_dev->data->dev_conf.intr_conf.lsc = 1;
>
> -       eth_dev->data->dev_conf.intr_conf.rxq = 1;
>         dev_info->rx_desc_lim.nb_min = BNXT_MIN_RING_DESC;
>         dev_info->rx_desc_lim.nb_max = BNXT_MAX_RX_RING_DESC;
>         dev_info->tx_desc_lim.nb_min = BNXT_MIN_RING_DESC;
> --
> 2.21.1 (Apple Git-122.3)
>
>
diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
index 495c6cd21e..ed09f1bf52 100644
--- a/drivers/net/bnxt/bnxt_ethdev.c
+++ b/drivers/net/bnxt/bnxt_ethdev.c
@@ -1011,7 +1011,6 @@  static int bnxt_dev_info_get_op(struct rte_eth_dev *eth_dev,
 	};
 	eth_dev->data->dev_conf.intr_conf.lsc = 1;
 
-	eth_dev->data->dev_conf.intr_conf.rxq = 1;
 	dev_info->rx_desc_lim.nb_min = BNXT_MIN_RING_DESC;
 	dev_info->rx_desc_lim.nb_max = BNXT_MAX_RX_RING_DESC;
 	dev_info->tx_desc_lim.nb_min = BNXT_MIN_RING_DESC;