crypto/mvsam: fix capabilities for crypto algorithms

Message ID 20210701065853.31052-1-danat@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series crypto/mvsam: fix capabilities for crypto algorithms |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/iol-intel-Performance fail Performance Testing issues
ci/iol-intel-Functional success Functional Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-testing fail Testing issues
ci/iol-mellanox-Functional fail Functional Testing issues
ci/iol-abi-testing success Testing PASS

Commit Message

danat@marvell.com July 1, 2021, 6:58 a.m. UTC
  From: Michael Shamis <michaelsh@marvell.com>

Increased AAD max size up to 64B and allowed AAD increment step
1B according to EIP197 token HW limitation.
In addition, some capabilities were found incorrect due to
running FIPS tests. The patch fix the capabilities.

Fixes: 8a61c83af2f ("crypto/mrvl: add mrvl crypto driver")
Fixes: 2c22aa4f8f6 ("crypto/mvsam: update hash digest sizes")
Fixes: a84226fc055 ("crypto/mvsam: support HMAC SHA224")
Cc: stable@dpdk.org

Signed-off-by: Michael Shamis <michaelsh@marvell.com>
Reviewed-by: Liron Himi <lironh@marvell.com>
Tested-by: Liron Himi <lironh@marvell.com>
---
 drivers/crypto/mvsam/rte_mrvl_pmd_ops.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)
  

Comments

Akhil Goyal July 7, 2021, 3:38 p.m. UTC | #1
> Increased AAD max size up to 64B and allowed AAD increment step
> 1B according to EIP197 token HW limitation.
> In addition, some capabilities were found incorrect due to
> running FIPS tests. The patch fix the capabilities.
> 
> Fixes: 8a61c83af2f ("crypto/mrvl: add mrvl crypto driver")
> Fixes: 2c22aa4f8f6 ("crypto/mvsam: update hash digest sizes")
> Fixes: a84226fc055 ("crypto/mvsam: support HMAC SHA224")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Michael Shamis <michaelsh@marvell.com>
> Reviewed-by: Liron Himi <lironh@marvell.com>
> Tested-by: Liron Himi <lironh@marvell.com>
> ---
Applied to dpdk-next-crypto

Thanks.
  

Patch

diff --git a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
index e4dfda7fa..3cb7e3b9c 100644
--- a/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
+++ b/drivers/crypto/mvsam/rte_mrvl_pmd_ops.c
@@ -112,7 +112,7 @@  static const struct rte_cryptodev_capabilities
 					.increment = 1
 				},
 				.digest_size = {
-					.min = 28,
+					.min = 12,
 					.max = 28,
 					.increment = 0
 				},
@@ -233,7 +233,7 @@  static const struct rte_cryptodev_capabilities
 				},
 				.digest_size = {
 					.min = 12,
-					.max = 48,
+					.max = 64,
 					.increment = 4
 				},
 			}, }
@@ -253,7 +253,7 @@  static const struct rte_cryptodev_capabilities
 				},
 				.digest_size = {
 					.min = 12,
-					.max = 48,
+					.max = 64,
 					.increment = 0
 				},
 			}, }
@@ -337,9 +337,9 @@  static const struct rte_cryptodev_capabilities
 					.increment = 0
 				},
 				.aad_size = {
-					.min = 8,
-					.max = 12,
-					.increment = 4
+					.min = 0,
+					.max = 64,
+					.increment = 1
 				},
 				.iv_size = {
 					.min = 12,