From patchwork Mon Jun 28 10:58:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiawei Wang X-Patchwork-Id: 94888 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3C77DA0C3F; Mon, 28 Jun 2021 12:58:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BE54940692; Mon, 28 Jun 2021 12:58:50 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2089.outbound.protection.outlook.com [40.107.95.89]) by mails.dpdk.org (Postfix) with ESMTP id 2D3F64068A; Mon, 28 Jun 2021 12:58:49 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Xx91aTzaedNdFbtMhbLpYod/W3YmJapUDIfyPCESWDMjM4xOHTONwTma+TkSwK/t6MfXwvBViD5AwPD8eMaquIROrbm9WVZx/PpqY+ISJUr+3GOORrj0fmZ6fI3ABsVbDJxXlhSAm+/gLaQgK2EZDa2pij7EC+ccxjagpQsLnFakpyWowo6Conzwp7D3HSHWKR0oAOcrxODdoyonHFrUfXnZYBc+ns58KnnC3CLs1hXk5PAC2q+o0AXMa+CIFDu0y8CCgh5dk1+WlUNuxrZTRTPGNERA1hL8fEie6ZEnEZBlcGlkuOnUQ0twoD3S/pEow0WXu4LtMNp9rO+6LZdy4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8RbeKhAaap+KBE5ygYuFdGuT7ur2i/GoifaPIgP3z8Q=; b=KlMDfm6/uGQoX3bGJOjdeOr8G8eIpABQXX+UUvQ135cWsJ9VsWGuRdS1HbMDyPJaAr7/QxxQauR+w/PctTYqZSqF0u21VhwriwW+TBAO0m4DQcXOmKrHHevmVMw6rw5MDXKIBw3DMVnS2WtE/hFO1seaWXQtg2tOFWmuqdSnVkokw+ZqfdVc9RuccojSSBkm+ajDALeG50hQltEYCMa18E2qc30Mb/Ww0n8Lu1k7LTZVSFl85IYlL4zgkGxPdeQyhnoPeKDaY5FDwNH8OW5wUHBTfZmsYMY/4hePQ9fk++WeHQcWNQxMjmUh5EfQ6DK6CLDnfPinU9YbAqBlpvGRuw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8RbeKhAaap+KBE5ygYuFdGuT7ur2i/GoifaPIgP3z8Q=; b=cgh/Fykujaq8vF5WYKNdgxRD+N6ec0lBBdKoaQoEza1hm7Lj+/D3jYcDbZ29i4NwZodszn+5vfnjymXIG4npp8k+UQ/3Tgxopp3ejrSMM2FpTUKZ+Bk6CzwavxxcXR554DwlQBGDjleS+QbTFEYcxNoHwQHPQQtYgBCCkyh4pgbFbpRGRNT5WUnFLKvZigyLqSueRocHtHkdUMR5a93mx8HffohAtZ8mk+I8EMoX6ckK3Mwq+tjSxAZSwIVAdQAbdDjDmdUCM+I8PV4Jaaamz+ghTTUseUoWiEyvTQlhLhcaxptPIRG6ZYwJpR0W3QyGUXD6jKkxqwl5o2cQk/vLtg== Received: from BN6PR14CA0006.namprd14.prod.outlook.com (2603:10b6:404:79::16) by BN6PR12MB1268.namprd12.prod.outlook.com (2603:10b6:404:1a::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.19; Mon, 28 Jun 2021 10:58:47 +0000 Received: from BN8NAM11FT036.eop-nam11.prod.protection.outlook.com (2603:10b6:404:79:cafe::c8) by BN6PR14CA0006.outlook.office365.com (2603:10b6:404:79::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Mon, 28 Jun 2021 10:58:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT036.mail.protection.outlook.com (10.13.177.168) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4264.18 via Frontend Transport; Mon, 28 Jun 2021 10:58:47 +0000 Received: from nvidia.com (172.20.187.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 28 Jun 2021 10:58:44 +0000 From: Jiawei Wang To: , , , , Shahaf Shuler , Alexander Kozyrev CC: , , Date: Mon, 28 Jun 2021 13:58:28 +0300 Message-ID: <20210628105828.14850-1-jiaweiw@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [172.20.187.5] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c54db6ad-438a-448a-0c80-08d93a23b49d X-MS-TrafficTypeDiagnostic: BN6PR12MB1268: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: RbGfRkjDvSa7Y7k2oOT9DqzOSB5Kc+kAoJxieg0A7j9T+1ybh7wb4CcbIFEnm0M12hCvIMxiRum1UxzuXDFgdgdga4fgmGSTVR+jCTqLLuoYlUH8hcLIMjsqTBUSPzqu65gfCBHkTlBxynSI7zTIaD/+tX8eW1nYpolxG6QvTXfRK8Cn8yAzWMHifaAqTLyc43e2szoWmQx8Yah6vk9I3DykvCaai3wV8s0j+aDC+p/tq3DGNkIbETQx9xP3MpictNnP3oZRuvzMhU8RXmF5u11ddTHLvbjb2Knt4+4mFJKgnJE8EGLqRz188O/T5cuw/9mmc40fp5AQ6WPQLY/J9XbEtQgkSvOaiFbqXTwYqz3RsiL8sSonZG1TElmjcSJOVjtF1Kf2D5RqpJ3SMQOUdtlwxfH9uDA/6U0yJ8LwBeqFz8+WaxCrMUS5tQ03aqDbdnrIqSB9ymqEgGEK8hUs6CZxpe8VuR0jZw4EZhUJZVqBFSEfflqLWX2YLzVEjBL1eTC5l4PZl/XS21VVLdpn/VloUbs7iKV1fI6oqNc5X/juZY63fgb9PbUm+0f1G8Nsvq4j/9GMm02mLTu879/MVCedwuu5aBsQl0dXPQxvQulHPdrP69P3P0Li6VN3OwbIhgNrmf+bcepxIp02oaZvQBdsRklfqDCMeigNBK9rGX35WL+KVvK5dvF8NFuzIf+M7VJ0y3DOZbeiEP1pLELrzg== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(346002)(39860400002)(376002)(136003)(396003)(46966006)(36840700001)(426003)(4326008)(26005)(70206006)(70586007)(6636002)(8676002)(6286002)(7696005)(5660300002)(36756003)(336012)(36860700001)(82740400003)(82310400003)(8936002)(186003)(16526019)(55016002)(2616005)(7636003)(6666004)(478600001)(316002)(36906005)(54906003)(2906002)(1076003)(86362001)(356005)(83380400001)(110136005)(47076005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2021 10:58:47.6234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: c54db6ad-438a-448a-0c80-08d93a23b49d X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT036.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1268 Subject: [dpdk-dev] [PATCH] net/mlx5: fix the modify field action flag checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The introduced MODIFY_FIELD action was used to manipulate the packet header field through copy or set operations. These modify header actions should be counted as one action in low level, the current code used wrong actions flags checking for modify field action. This patch update the action flags checking into the correct MODIFY_HDR_ACTIONS set. Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action") Cc: stable@dpdk.org Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index c5d4b01e57..20f068c522 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -7573,7 +7573,7 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr, if (action_flags & MLX5_FLOW_ACTION_SAMPLE) modify_after_mirror = 1; /* Count all modify-header actions as one action. */ - if (!(action_flags & MLX5_FLOW_ACTION_MODIFY_FIELD)) + if (!(action_flags & MLX5_FLOW_MODIFY_HDR_ACTIONS)) ++actions_n; action_flags |= MLX5_FLOW_ACTION_MODIFY_FIELD; rw_act_num += ret;