From patchwork Wed Jun 16 19:57:23 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Owen Hilyard X-Patchwork-Id: 94312 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F18A3A0C49; Wed, 16 Jun 2021 21:57:27 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDB0140683; Wed, 16 Jun 2021 21:57:27 +0200 (CEST) Received: from mail-ot1-f97.google.com (mail-ot1-f97.google.com [209.85.210.97]) by mails.dpdk.org (Postfix) with ESMTP id 416174067A for ; Wed, 16 Jun 2021 21:57:27 +0200 (CEST) Received: by mail-ot1-f97.google.com with SMTP id q5-20020a9d66450000b02903f18d65089fso3714479otm.11 for ; Wed, 16 Jun 2021 12:57:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WqTAQ3woA0koi1G+cBGYiGlgQSGCUZnmZNY7dQ2dCX4=; b=DmZqpLOhxq9KxTKXGkGx9w1s70CoeNI9pxUrqCztkTkR84JMTL/ULFIgz1k2sngyJ9 xY9jLRy+FUnFndMmT3TIUjmXsLlEP3cyUKdOF7mUOv6PehmKz1UmXQcFCJC6WmDcBOAf alRtDrGpiPgtGnBH2Bmj+FJWvIceMctMkNJa4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=WqTAQ3woA0koi1G+cBGYiGlgQSGCUZnmZNY7dQ2dCX4=; b=F/tAC0qEqr9LJsFC5X9BNQ/PY4BFY79V/MrukkiVh5dZ3pnIfFtndb6nuCN6KZoovA GWcBtovAn17ok6N0W9NycgTGU4xVq1W/0+T/jqjwMGVRC/uyvQUylc95J+1VP2+AvcDq Va+hhcRpURvUzqYc+VyOAWPE0N05NvTtbTYe4SxvT7dTdfqmjxkg1rN8fme6vizof/sD 7KmlUuKTxs7n/zbhCN4pJ6kNqiGRuxMTCQA5Fab+KvTNyk6x0jvOL2wBBXTwII4qMy3F jwwhb+OvX5iCZtvb9iOzIwcKYJdCuto15BULIfmnekP40PQmlPOqXQ7G0RBey5qm5Aky uWPQ== X-Gm-Message-State: AOAM530vJJfUCP5NbsIL9X7FmF0+zEf8KkR7Ge+F69E+UVIMKjwFVQDK WHFAksXjrAutF3GvDn2dUV4IR4WPBw9dd/IV53ba4yu/wsS8ytxVi7dS8fbrHk0QZAtRpHcsgju w+fRFVYuZew4XuaRkCHXlOkvijS3TQO2zFLMBCoMHwgW2VFBlLis2n2YHrY6WOfCoT0LGbwGhao yY1zsNoJ4eIpyayw== X-Google-Smtp-Source: ABdhPJxnunxwcdC1sHWqwdN5X7+dC3q1J1L2W7v4NQesdAUItSZIlSV/bYBAf5K97VDcZjFR84dwY+0ovzGC X-Received: by 2002:a05:6830:34a7:: with SMTP id c39mr1373167otu.133.1623873446519; Wed, 16 Jun 2021 12:57:26 -0700 (PDT) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id z21sm1250470oor.12.2021.06.16.12.57.26 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 16 Jun 2021 12:57:26 -0700 (PDT) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1220:5e2f:685e:142b:54c3]) by postal.iol.unh.edu (Postfix) with ESMTP id 0B3F6605246B; Wed, 16 Jun 2021 15:57:26 -0400 (EDT) From: ohilyard@iol.unh.edu To: bernard.iremonger@intel.com Cc: dev@dpdk.org, david.marchand@redhat.com, Owen Hilyard Date: Wed, 16 Jun 2021 15:57:23 -0400 Message-Id: <20210616195724.366103-1-ohilyard@iol.unh.edu> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] lib/flow_classify: fix leaking rules on delete X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Owen Hilyard Rules in a classify table were not freed if the table had a delete function. Fixes: be41ac2a3 ("flow_classify: introduce flow classify library") Signed-off-by: Owen Hilyard --- lib/flow_classify/rte_flow_classify.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/flow_classify/rte_flow_classify.c b/lib/flow_classify/rte_flow_classify.c index f125267e8..06aed3b70 100644 --- a/lib/flow_classify/rte_flow_classify.c +++ b/lib/flow_classify/rte_flow_classify.c @@ -579,7 +579,7 @@ rte_flow_classify_table_entry_delete(struct rte_flow_classifier *cls, &rule->u.key.key_del, &rule->key_found, &rule->entry); - + free(rule); return ret; } }