From patchwork Tue Jun 1 01:56:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Feifei Wang X-Patchwork-Id: 93675 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16423A0524; Tue, 1 Jun 2021 03:57:09 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D0C240FDF; Tue, 1 Jun 2021 03:57:05 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 9B61340E78 for ; Tue, 1 Jun 2021 03:57:04 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1677F1FB; Mon, 31 May 2021 18:57:04 -0700 (PDT) Received: from net-x86-dell-8268.shanghai.arm.com (net-x86-dell-8268.shanghai.arm.com [10.169.210.132]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id B951D3F774; Mon, 31 May 2021 18:57:01 -0700 (PDT) From: Feifei Wang To: Bruce Richardson Cc: dev@dpdk.org, nd@arm.com, Phil Yang , Feifei Wang , =?utf-8?q?Juraj_Linke=C5=A1?= , Ruifeng Wang Date: Tue, 1 Jun 2021 09:56:52 +0800 Message-Id: <20210601015653.14499-2-feifei.wang2@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20210601015653.14499-1-feifei.wang2@arm.com> References: <20210601015653.14499-1-feifei.wang2@arm.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v1 1/2] devtools: add relative path support for ABI compatibility check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Phil Yang Because dpdk guide does not limit the relative path for ABI compatibility check, users maybe set 'DPDK_ABI_REF_DIR' as a relative path: ~/dpdk/devtools$ DPDK_ABI_REF_VERSION=v19.11 DPDK_ABI_REF_DIR=build-gcc-shared ./test-meson-builds.sh And if the DESTDIR is not an absolute path, ninja complains: + install_target build-gcc-shared/v19.11/build build-gcc-shared/v19.11/build-gcc-shared + rm -rf build-gcc-shared/v19.11/build-gcc-shared + echo 'DESTDIR=build-gcc-shared/v19.11/build-gcc-shared ninja -C build-gcc-shared/v19.11/build install' + DESTDIR=build-gcc-shared/v19.11/build-gcc-shared + ninja -C build-gcc-shared/v19.11/build install ... ValueError: dst_dir must be absolute, got build-gcc-shared/v19.11/build-gcc-shared/usr/local/share/dpdk/ examples/bbdev_app ... Error: install directory 'build-gcc-shared/v19.11/build-gcc-shared' does not exist. To fix this, add relative path support using 'readlink -f'. Signed-off-by: Phil Yang Signed-off-by: Feifei Wang Reviewed-by: Juraj Linkeš Reviewed-by: Ruifeng Wang Acked-by: Bruce Richardson --- devtools/test-meson-builds.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index daf817ac3e..43b906598d 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -168,7 +168,8 @@ build () # [meson options] config $srcdir $builds_dir/$targetdir $cross --werror $* compile $builds_dir/$targetdir if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then - abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION + abirefdir=$(readlink -f \ + ${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION) if [ ! -d $abirefdir/$targetdir ]; then # clone current sources if [ ! -d $abirefdir/src ]; then